Also show exception with no messages, raise exception into request if in debug mode for easier debugging of unexpected errors

This commit is contained in:
Roberto Rosario
2015-01-14 15:51:51 -04:00
parent f5e1adedfa
commit e4d68cb711

View File

@@ -158,8 +158,11 @@ def metadata_add(request, document_id=None, document_id_list=None):
try:
document_metadata, created = DocumentMetadata.objects.get_or_create(document=document, metadata_type=metadata_type, defaults={'value': u''})
except Exception as exception:
messages.error(request, _(u'Error adding metadata type "%(metadata_type)s" to document: %(document)s; %(exception)s') % {
'metadata_type': metadata_type, 'document': document, 'exception': ', '.join(exception.messages)})
if getattr(settings, 'DEBUG', False):
raise
else:
messages.error(request, _(u'Error adding metadata type "%(metadata_type)s" to document: %(document)s; %(exception)s') % {
'metadata_type': metadata_type, 'document': document, 'exception': ', '.join(getattr(exception, 'messages', exception))})
else:
if created:
messages.success(request, _(u'Metadata type: %(metadata_type)s successfully added to document %(document)s.') % {