From e4d68cb7111e06614ddb21cda0ff1e0d48817d3d Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Wed, 14 Jan 2015 15:51:51 -0400 Subject: [PATCH] Also show exception with no messages, raise exception into request if in debug mode for easier debugging of unexpected errors --- mayan/apps/metadata/views.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mayan/apps/metadata/views.py b/mayan/apps/metadata/views.py index c0a1d7a855..b7087eab76 100644 --- a/mayan/apps/metadata/views.py +++ b/mayan/apps/metadata/views.py @@ -158,8 +158,11 @@ def metadata_add(request, document_id=None, document_id_list=None): try: document_metadata, created = DocumentMetadata.objects.get_or_create(document=document, metadata_type=metadata_type, defaults={'value': u''}) except Exception as exception: - messages.error(request, _(u'Error adding metadata type "%(metadata_type)s" to document: %(document)s; %(exception)s') % { - 'metadata_type': metadata_type, 'document': document, 'exception': ', '.join(exception.messages)}) + if getattr(settings, 'DEBUG', False): + raise + else: + messages.error(request, _(u'Error adding metadata type "%(metadata_type)s" to document: %(document)s; %(exception)s') % { + 'metadata_type': metadata_type, 'document': document, 'exception': ', '.join(getattr(exception, 'messages', exception))}) else: if created: messages.success(request, _(u'Metadata type: %(metadata_type)s successfully added to document %(document)s.') % {