uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Kill the magic numbers of UsbCommand_WriteConfig()

Browse Source
This commit is contained in:
László Monda
2017-11-06 00:57:41 +01:00
parent 8c7014cf8c
commit 34b2875861
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
right/src/usb_commands/usb_command_write_config.c
View File

@@ -7,8 +7,9 @@ void UsbCommand_WriteConfig(bool isHardware)
{ {
uint8_t length = GET_USB_BUFFER_UINT8(1); uint8_t length = GET_USB_BUFFER_UINT8(1);
uint16_t offset = GET_USB_BUFFER_UINT16(2); uint16_t offset = GET_USB_BUFFER_UINT16(2);
const uint8_t paramsSize = USB_STATUS_CODE_SIZE + sizeof(length) + sizeof(offset);
if (length > USB_GENERIC_HID_OUT_BUFFER_LENGTH-4) { if (length > USB_GENERIC_HID_OUT_BUFFER_LENGTH - paramsSize) {
SET_USB_BUFFER_UINT8(0, UsbStatusCode_WriteConfig_LengthTooLarge); SET_USB_BUFFER_UINT8(0, UsbStatusCode_WriteConfig_LengthTooLarge);
return; return;
} }
@@ -21,5 +22,5 @@ void UsbCommand_WriteConfig(bool isHardware)
return; return;
} }
memcpy(buffer+offset, GenericHidInBuffer+4, length); memcpy(buffer + offset, GenericHidInBuffer + paramsSize, length);
} }