From 34b2875861a68575affcfbb50bb57d1a5591349d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A1szl=C3=B3=20Monda?= Date: Mon, 6 Nov 2017 00:57:41 +0100 Subject: [PATCH] Kill the magic numbers of UsbCommand_WriteConfig() --- right/src/usb_commands/usb_command_write_config.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/right/src/usb_commands/usb_command_write_config.c b/right/src/usb_commands/usb_command_write_config.c index 5e647c7..5a565f5 100644 --- a/right/src/usb_commands/usb_command_write_config.c +++ b/right/src/usb_commands/usb_command_write_config.c @@ -7,8 +7,9 @@ void UsbCommand_WriteConfig(bool isHardware) { uint8_t length = GET_USB_BUFFER_UINT8(1); uint16_t offset = GET_USB_BUFFER_UINT16(2); + const uint8_t paramsSize = USB_STATUS_CODE_SIZE + sizeof(length) + sizeof(offset); - if (length > USB_GENERIC_HID_OUT_BUFFER_LENGTH-4) { + if (length > USB_GENERIC_HID_OUT_BUFFER_LENGTH - paramsSize) { SET_USB_BUFFER_UINT8(0, UsbStatusCode_WriteConfig_LengthTooLarge); return; } @@ -21,5 +22,5 @@ void UsbCommand_WriteConfig(bool isHardware) return; } - memcpy(buffer+offset, GenericHidInBuffer+4, length); + memcpy(buffer + offset, GenericHidInBuffer + paramsSize, length); }