uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use ternary operators instead of if-else statements

Browse Source
This commit is contained in:
Eric Tang
2017-07-25 18:17:41 -07:00
parent eeeff4ec1a
commit 1709227a28
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
right/src/config/parse_keymap.c
View File

@@ -28,21 +28,15 @@ static parser_error_t parseKeyStrokeAction(key_action_t *keyAction, uint8_t keyS
default:
return ParserError_InvalidSerializedKeystrokeType;
}
if (keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_SCANCODE) {
keyAction->keystroke.scancode = keystrokeType == SerializedKeystrokeType_LongMedia ? readUInt16(buffer) : readUInt8(buffer);
} else {
keyAction->keystroke.scancode = 0;
}
if (keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_MODIFIERS) {
keyAction->keystroke.modifiers = readUInt8(buffer);
} else {
keyAction->keystroke.modifiers = 0;
}
if (keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_LONGPRESS) {
keyAction->keystroke.longPressAction = readUInt8(buffer);
} else {
keyAction->keystroke.longPressAction = 0;
}
keyAction->keystroke.scancode = keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_SCANCODE
? keystrokeType == SerializedKeystrokeType_LongMedia ? readUInt16(buffer) : readUInt8(buffer)
: 0;
keyAction->keystroke.modifiers = keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_MODIFIERS
? readUInt8(buffer)
: 0;
keyAction->keystroke.longPressAction = keyStrokeAction & SERIALIZED_KEYSTROKE_TYPE_MASK_HAS_LONGPRESS
? readUInt8(buffer)
: 0;
return ParserError_Success;
}