matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,066 Commits 36 Branches 0 Tags
205ca594f5b76bcf08d6aa9347ee549dcad88e34
Commit Graph

53 Commits

Author SHA1 Message Date
Roberto Rosario
205ca594f5 Replace filter_by_access with restrict_queryset 
With the interface finalized, replace .filter_by_access() in
the generic view mixins with restrict_queryset().

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2019-01-22 22:16:56 -04:00
Roberto Rosario
383d0fcc38 Remove support for raising 404 
Remove explict support for raising 404 error when the
object access fails.

The new method to use is to restrict the queryset using
the .restrict_queryset manager method and then .get() the
desired object. If the object access control failed then
the desired object will not be found in the queryset
and an error 404 will be raised. The end result is the same:
error 404, the method to raise the error is what differs now.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2019-01-19 01:12:39 -04:00
Roberto Rosario
125c133334 Audit common app 
Add support to override settings of the FilteredSelectionForm
via subclass attributes. Add keyword arguments to calls.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2019-01-02 14:34:41 -04:00
Roberto Rosario
b3a781d51a Add ContentTypeViewMixin, ExternalObjectViewMixin 
Add a mixin to ease the amount of code and imports required
for views that extract the content type from URL parameters.

Improve ExternalObjectViewMixin by adding a new class attribute
"external_object_pk_url_kwargs" to mechanize URL parameter
extraction. The external_object_pk_url_kwargs maps model
attributes using during manager get or filter from URL parameters.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2019-01-02 02:56:19 -04:00
Roberto Rosario
5cb674b7ab Allow external object permission via function 
Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2018-12-30 16:26:42 -04:00
Roberto Rosario
cd9d51db9e Improve document comment app 
Add keyword arguments to URL definitions and reverse resolution.
Raise HTTP error 404 instead of 403 to reduce the information
divulged. Add view tests.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2018-12-30 02:26:23 -04:00
Roberto Rosario
5a90d76005 Make list mode code its own mixin 
Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2018-12-26 05:59:31 -04:00
Roberto Rosario
55a30379bd Various apps: Sort imports 
Run imports as per Mayan EDMS best practices.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
 2018-12-06 01:57:24 -04:00
Roberto Rosario
8e69178e07 Project: Switch to full app paths 
Instead of inserting the path of the apps into the Python app,
the apps are now referenced by their full import path.

This app name claves with external or native Python libraries.
Example: Mayan statistics app vs. Python new statistics library.

Every app reference is now prepended with 'mayan.apps'.

Existing config.yml files need to be updated manually.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2018-12-05 02:04:20 -04:00
Roberto Rosario
ec44e81864 Add support to the ObjectActionMixin to report on instance action failures. Add also an error_message class property and the new ActionError exception. 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2018-08-23 01:48:43 -04:00
Roberto Rosario
7b38cffd85 Fix typo 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2018-04-06 02:03:46 -04:00
Roberto Rosario
b0c2d6cd76 Allow ObjectListPermissionFilterMixin to check access against a parent object and not just against the queryser of child objects. 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2018-04-06 01:13:10 -04:00
Michael Price
de65d96fe2 Update cabinets and document_index api views docstrings. Update multi level docstrings as per Python best practices. 
Signed-off-by: Michael Price <loneviking72@gmail.com>
 2018-04-01 20:27:45 -04:00
Roberto Rosario
2052caada4 Remove PreserveGetQuerySet mixin. Update SingleObjectList and 
MultipleObjectFormActionView views to use a new get_object_list method.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-08-16 22:12:24 -04:00
Roberto Rosario
6ec235afc0 Add support for multiple dashboards. 
Add support for removing dashboard widgets.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-08-10 02:56:40 -04:00
Roberto Rosario
d49a5f43ed Add missing replacements of reverse to resolve_url. 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-07-25 08:23:26 -04:00
Roberto Rosario
f09321f6ab Fix deprecation warnings for Django 1.11 and Django 2.0. 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-07-21 00:25:18 -04:00
Roberto Rosario
fb520d6f92 Add view mixin to make sure a subclass can't override its 
parent's get_queryset method.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-07-14 05:19:50 -04:00
Roberto Rosario
a72ac6eadb Add user mailer backends support. GitLab issue #286. 
Add support for creating dynamic forms.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-07-03 13:37:56 -04:00
Roberto Rosario
63682a2945 Merge remote-tracking branch 'origin/master' into feature/master_merge 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-03-14 15:57:38 -04:00
Roberto Rosario
6e1cf57079 Implement document workflows transition ACLs. GitLab issue #321. 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
 2017-02-20 02:37:42 -04:00
Roberto Rosario
5167bbadee Refactor the document metadata add, edit and remove views. 2016-12-28 00:57:04 -04:00
Roberto Rosario
c21eb6d4cf Refacto ActionView into MultipleObjectFormActionView and MultipleObjectConfirmActionView. 
Split ActionView into smaller mixins.
 2016-12-21 03:27:27 -04:00
Roberto Rosario
5893e149e0 Reduce the check_access boilerplate code. 2016-11-02 04:58:05 -04:00
Roberto Rosario
621c988809 Simplify filter_by_access boilerplate code 2016-11-02 03:48:16 -04:00
Roberto Rosario
6e3d99670c Complete conversion of download views to CBV views using django-downloadview. 
This also removes dependency on the filetransfers library.
 2016-10-31 01:00:35 -04:00
Roberto Rosario
286a6ba9b8 Enable object access check via related attribute in generic CBV. 2016-03-19 02:51:03 -04:00
Roberto Rosario
ed8ac47240 Extract context object name from the models meta options. 2016-03-19 01:57:30 -04:00
Roberto Rosario
27d8644438 Silence 90% of remaining Django 1.8 model warnings. 2016-01-28 05:43:08 -04:00
Roberto Rosario
ec4324a3d6 Make arguments explicit. 2015-11-04 01:42:43 -04:00
Roberto Rosario
a1a0a6da52 PEP8 Cleanups. 2015-10-28 02:14:48 -04:00
Roberto Rosario
6f82ee8cb5 Make MultipleInstanceActionMixin operate on a queryset and not on a list of objects. Get the id_list from GET or POST requests, not just GET requests. 2015-10-21 03:41:12 -04:00
Roberto Rosario
c796f2b2c4 TODO comment cleanups. Remove unused Document model method. 2015-09-26 23:50:57 -04:00
Roberto Rosario
e1a04d9838 Convert document trash view to CBV. Improve ConfirmView based CBVs. 2015-09-15 02:02:38 -04:00
Roberto Rosario
72c63bfedc Improve form and object data passing code. 2015-08-25 20:28:59 -04:00
Roberto Rosario
95cb49bfcb Add mixin to pass extra argument during object deletion. Used for logging the user performing an action. 2015-08-23 22:33:22 -04:00
Roberto Rosario
8cd14a2ae1 Add mixin to add extra instance data to the CBV create and edit views. 2015-08-23 21:37:17 -04:00
Roberto Rosario
68f3c6eee7 PEP8 cleanups. 2015-08-19 14:50:44 -04:00
Roberto Rosario
4527563d89 PEP8 cleanups, specially E501 line too long. 2015-07-22 18:21:37 -04:00
Roberto Rosario
69ea0a61e8 Get post_action_redirect and action_cancel_redirect from methods to allow overriding with context. 2015-07-07 20:46:49 -04:00
Roberto Rosario
924c07c9de Add support for redirection target on confirm dialog cancelation 2015-07-03 20:49:28 -04:00
Roberto Rosario
8575d02286 Add missing imports 2015-07-03 03:24:20 -04:00
Roberto Rosario
509c944df0 Add mixin to apply an action to many instances 2015-07-03 03:20:36 -04:00
Roberto Rosario
ace76fc69c Update apps for new ACLs refactor. 2015-07-01 16:36:20 -04:00
Roberto Rosario
1c084aa07b Split Permission and StoredPermission class and model into different modules. Simplified the Permission class. 2015-06-28 01:03:29 -04:00
Roberto Rosario
92ba52720a Add get_success_url to redirection mixin 2015-06-19 19:06:56 -04:00
Roberto Rosario
8aa4452162 Allow overriding the object on which to perform the permission check 2015-06-16 04:15:46 -04:00
Roberto Rosario
fe43d53aa2 Use tuples instead of lists to represent single permission collections 2015-06-16 04:14:18 -04:00
Roberto Rosario
23fc9f1e36 Merge main and common apps, extract authentication functionality to new authentication app. Closes issues #179 and #180 2015-04-06 16:09:54 -04:00
Roberto Rosario
f4d3767b15 PEP8 cleanup, remove unused imports, fix permission check when removing metadata from a document 2015-01-26 19:17:35 -04:00