Remove explict support for raising 404 error when the object access fails. The new method to use is to restrict the queryset using the .restrict_queryset manager method and then .get() the desired object. If the object access control failed then the desired object will not be found in the queryset and an error 404 will be raised. The end result is the same: error 404, the method to raise the error is what differs now. Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
441 lines
14 KiB
Python
441 lines
14 KiB
Python
from __future__ import unicode_literals
|
|
|
|
from django.conf import settings
|
|
from django.contrib import messages
|
|
from django.contrib.contenttypes.models import ContentType
|
|
from django.core.exceptions import ImproperlyConfigured, PermissionDenied
|
|
from django.db.models.query import QuerySet
|
|
from django.http import Http404, HttpResponseRedirect
|
|
from django.shortcuts import get_object_or_404, resolve_url
|
|
from django.utils.translation import ugettext_lazy as _
|
|
from django.utils.translation import ungettext
|
|
|
|
from mayan.apps.acls.models import AccessControlList
|
|
from mayan.apps.permissions import Permission
|
|
|
|
from .exceptions import ActionError
|
|
from .forms import DynamicForm
|
|
from .literals import (
|
|
PK_LIST_SEPARATOR, TEXT_CHOICE_ITEMS, TEXT_CHOICE_LIST,
|
|
TEXT_LIST_AS_ITEMS_PARAMETER, TEXT_LIST_AS_ITEMS_VARIABLE_NAME
|
|
)
|
|
|
|
__all__ = (
|
|
'DeleteExtraDataMixin', 'DynamicFormViewMixin', 'ExtraContextMixin',
|
|
'FormExtraKwargsMixin', 'ListModeMixin', 'MultipleObjectMixin',
|
|
'ObjectActionMixin', 'ObjectListPermissionFilterMixin', 'ObjectNameMixin',
|
|
'ObjectPermissionCheckMixin', 'RedirectionMixin',
|
|
'ViewPermissionCheckMixin'
|
|
)
|
|
|
|
|
|
class ContentTypeViewMixin(object):
|
|
def get_content_type(self):
|
|
return get_object_or_404(
|
|
klass=ContentType, app_label=self.kwargs['app_label'],
|
|
model=self.kwargs['model']
|
|
)
|
|
|
|
|
|
class DeleteExtraDataMixin(object):
|
|
def delete(self, request, *args, **kwargs):
|
|
self.object = self.get_object()
|
|
success_url = self.get_success_url()
|
|
if hasattr(self, 'get_delete_extra_data'):
|
|
self.object.delete(**self.get_delete_extra_data())
|
|
else:
|
|
self.object.delete()
|
|
|
|
return HttpResponseRedirect(redirect_to=success_url)
|
|
|
|
|
|
class DynamicFormViewMixin(object):
|
|
form_class = DynamicForm
|
|
|
|
def get_form_kwargs(self):
|
|
data = super(DynamicFormViewMixin, self).get_form_kwargs()
|
|
data.update({'schema': self.get_form_schema()})
|
|
return data
|
|
|
|
|
|
class ExtraContextMixin(object):
|
|
"""
|
|
Mixin that allows views to pass extra context to the template
|
|
"""
|
|
extra_context = {}
|
|
|
|
def get_extra_context(self):
|
|
return self.extra_context
|
|
|
|
def get_context_data(self, **kwargs):
|
|
context = super(ExtraContextMixin, self).get_context_data(**kwargs)
|
|
context.update(self.get_extra_context())
|
|
return context
|
|
|
|
|
|
class ExternalObjectMixin(object):
|
|
external_object_class = None
|
|
external_object_permission = None
|
|
external_object_pk_url_kwarg = 'pk'
|
|
external_object_pk_url_kwargs = None # Usage: {'pk': 'pk'}
|
|
external_object_queryset = None
|
|
|
|
def get_pk_url_kwargs(self):
|
|
pk_url_kwargs = {}
|
|
|
|
if self.external_object_pk_url_kwargs:
|
|
pk_url_kwargs = self.external_object_pk_url_kwargs
|
|
else:
|
|
pk_url_kwargs['pk'] = self.external_object_pk_url_kwarg
|
|
|
|
for key, value in pk_url_kwargs.items():
|
|
pk_url_kwargs[key] = self.kwargs[value]
|
|
|
|
return pk_url_kwargs
|
|
|
|
def get_external_object(self):
|
|
return get_object_or_404(
|
|
klass=self.get_external_object_queryset_filtered(),
|
|
**self.get_pk_url_kwargs()
|
|
)
|
|
|
|
def get_external_object_permission(self):
|
|
return self.external_object_permission
|
|
|
|
def get_external_object_queryset(self):
|
|
if not self.external_object_queryset and not self.external_object_class:
|
|
raise ImproperlyConfigured(
|
|
'View must provide either an external_object_queryset, '
|
|
'an external_object_class or a custom '
|
|
'get_external_object_queryset() method.'
|
|
)
|
|
|
|
return self.external_object_queryset or self.external_object_class.objects.all()
|
|
|
|
def get_external_object_queryset_filtered(self):
|
|
queryset = self.get_external_object_queryset()
|
|
permission = self.get_external_object_permission()
|
|
|
|
if permission:
|
|
queryset = AccessControlList.objects.filter_by_access(
|
|
permission=permission, queryset=queryset,
|
|
user=self.request.user
|
|
)
|
|
|
|
return queryset
|
|
|
|
|
|
class FormExtraKwargsMixin(object):
|
|
"""
|
|
Mixin that allows a view to pass extra keyword arguments to forms
|
|
"""
|
|
form_extra_kwargs = {}
|
|
|
|
def get_form_extra_kwargs(self):
|
|
return self.form_extra_kwargs
|
|
|
|
def get_form_kwargs(self):
|
|
result = super(FormExtraKwargsMixin, self).get_form_kwargs()
|
|
result.update(self.get_form_extra_kwargs())
|
|
return result
|
|
|
|
|
|
class ListModeMixin(object):
|
|
def get_context_data(self, **kwargs):
|
|
context = super(ListModeMixin, self).get_context_data(**kwargs)
|
|
|
|
if context.get(TEXT_LIST_AS_ITEMS_VARIABLE_NAME):
|
|
default_mode = TEXT_CHOICE_ITEMS
|
|
else:
|
|
default_mode = TEXT_CHOICE_LIST
|
|
|
|
list_mode = self.request.GET.get(
|
|
TEXT_LIST_AS_ITEMS_PARAMETER, default_mode
|
|
)
|
|
|
|
context.update(
|
|
{
|
|
TEXT_LIST_AS_ITEMS_VARIABLE_NAME: list_mode == TEXT_CHOICE_ITEMS
|
|
}
|
|
)
|
|
return context
|
|
|
|
|
|
class MultipleInstanceActionMixin(object):
|
|
# TODO: Deprecated, replace views using this with
|
|
# MultipleObjectFormActionView or MultipleObjectConfirmActionView
|
|
|
|
model = None
|
|
success_message = _('Operation performed on %(count)d object')
|
|
success_message_plural = _('Operation performed on %(count)d objects')
|
|
|
|
def get_pk_list(self):
|
|
return self.request.GET.get(
|
|
'id_list', self.request.POST.get('id_list', '')
|
|
).split(',')
|
|
|
|
def get_queryset(self):
|
|
return self.model.objects.filter(pk__in=self.get_pk_list())
|
|
|
|
def get_success_message(self, count):
|
|
return ungettext(
|
|
singular=self.success_message,
|
|
plural=self.success_message_plural,
|
|
number=count
|
|
) % {
|
|
'count': count,
|
|
}
|
|
|
|
def post(self, request, *args, **kwargs):
|
|
count = 0
|
|
for instance in self.get_queryset():
|
|
try:
|
|
self.object_action(instance=instance)
|
|
except PermissionDenied:
|
|
pass
|
|
else:
|
|
count += 1
|
|
|
|
messages.success(
|
|
request=self.request,
|
|
message=self.get_success_message(count=count)
|
|
)
|
|
|
|
return HttpResponseRedirect(redirect_to=self.get_success_url())
|
|
|
|
|
|
class MultipleObjectMixin(object):
|
|
"""
|
|
Mixin that allows a view to work on a single or multiple objects. It can
|
|
receive a pk, a slug or a list of IDs via an id_list query.
|
|
The pk, slug, and ID list parameter name can be changed using the
|
|
attributes: pk_url_kwargs, slug_url_kwarg, and pk_list_key.
|
|
"""
|
|
model = None
|
|
object_permission = None
|
|
pk_list_key = 'id_list'
|
|
pk_list_separator = PK_LIST_SEPARATOR
|
|
pk_url_kwarg = 'pk'
|
|
queryset = None
|
|
slug_url_kwarg = 'slug'
|
|
|
|
def get_pk_list(self):
|
|
result = self.request.GET.get(
|
|
self.pk_list_key, self.request.POST.get(self.pk_list_key)
|
|
)
|
|
|
|
if result:
|
|
return result.split(self.pk_list_separator)
|
|
else:
|
|
return None
|
|
|
|
def get_queryset(self):
|
|
if self.queryset is not None:
|
|
queryset = self.queryset
|
|
if isinstance(queryset, QuerySet):
|
|
queryset = queryset.all()
|
|
elif self.model is not None:
|
|
queryset = self.model._default_manager.all()
|
|
|
|
pk = self.kwargs.get(self.pk_url_kwarg)
|
|
slug = self.kwargs.get(self.slug_url_kwarg)
|
|
pk_list = self.get_pk_list()
|
|
|
|
if pk is not None:
|
|
queryset = queryset.filter(pk=pk)
|
|
|
|
# Next, try looking up by slug.
|
|
if slug is not None and (pk is None or self.query_pk_and_slug):
|
|
slug_field = self.get_slug_field()
|
|
queryset = queryset.filter(**{slug_field: slug})
|
|
|
|
if pk_list is not None:
|
|
queryset = queryset.filter(pk__in=self.get_pk_list())
|
|
|
|
if pk is None and slug is None and pk_list is None:
|
|
raise AttributeError(
|
|
'Generic detail view %s must be called with '
|
|
'either an object pk, a slug or an id list.'
|
|
% self.__class__.__name__
|
|
)
|
|
|
|
if self.object_permission:
|
|
return AccessControlList.objects.filter_by_access(
|
|
permission=self.object_permission, queryset=queryset,
|
|
user=self.request.user
|
|
)
|
|
else:
|
|
return queryset
|
|
|
|
|
|
class ObjectActionMixin(object):
|
|
"""
|
|
Mixin that performs an user action to a queryset
|
|
"""
|
|
error_message = 'Unable to perform operation on object %(instance)s.'
|
|
success_message = 'Operation performed on %(count)d object.'
|
|
success_message_plural = 'Operation performed on %(count)d objects.'
|
|
|
|
def get_success_message(self, count):
|
|
return ungettext(
|
|
singular=self.success_message,
|
|
plural=self.success_message_plural,
|
|
number=count
|
|
) % {
|
|
'count': count,
|
|
}
|
|
|
|
def object_action(self, instance, form=None):
|
|
# User supplied method
|
|
raise NotImplementedError
|
|
|
|
def view_action(self, form=None):
|
|
self.action_count = 0
|
|
|
|
for instance in self.get_queryset():
|
|
try:
|
|
self.object_action(form=form, instance=instance)
|
|
except PermissionDenied:
|
|
pass
|
|
except ActionError:
|
|
messages.error(
|
|
request=self.request,
|
|
message=self.error_message % {'instance': instance}
|
|
)
|
|
else:
|
|
self.action_count += 1
|
|
|
|
messages.success(
|
|
request=self.request,
|
|
message=self.get_success_message(count=self.action_count)
|
|
)
|
|
|
|
|
|
class ObjectListPermissionFilterMixin(object):
|
|
"""
|
|
access_object_retrieve_method is used to have the entire view check
|
|
against an object permission and not the individual secondary items.
|
|
"""
|
|
access_object_retrieve_method = None
|
|
object_permission = None
|
|
|
|
def dispatch(self, request, *args, **kwargs):
|
|
if self.access_object_retrieve_method and self.object_permission:
|
|
AccessControlList.objects.check_access(
|
|
obj=getattr(self, self.access_object_retrieve_method)(),
|
|
permissions=(self.object_permission,), user=request.user
|
|
)
|
|
return super(ObjectListPermissionFilterMixin, self).dispatch(
|
|
request, *args, **kwargs
|
|
)
|
|
|
|
def get_queryset(self):
|
|
queryset = super(ObjectListPermissionFilterMixin, self).get_queryset()
|
|
|
|
if not self.access_object_retrieve_method and self.object_permission:
|
|
return AccessControlList.objects.filter_by_access(
|
|
permission=self.object_permission, queryset=queryset,
|
|
user=self.request.user
|
|
)
|
|
else:
|
|
return queryset
|
|
|
|
|
|
class ObjectNameMixin(object):
|
|
def get_object_name(self, context=None):
|
|
if not context:
|
|
context = self.get_context_data()
|
|
|
|
object_name = context.get('object_name')
|
|
|
|
if not object_name:
|
|
try:
|
|
object_name = self.object._meta.verbose_name
|
|
except AttributeError:
|
|
object_name = _('Object')
|
|
|
|
return object_name
|
|
|
|
|
|
class ObjectPermissionCheckMixin(object):
|
|
"""
|
|
Filter the queryset of the view by the `object_permission` provided.
|
|
If no `object_permission` is provide the queryset will be returned
|
|
as is.
|
|
"""
|
|
object_permission = None
|
|
|
|
def get_queryset(self):
|
|
queryset = super(ObjectPermissionCheckMixin, self).get_queryset()
|
|
|
|
if self.object_permission:
|
|
return AccessControlList.objects.restrict_queryset(
|
|
permission=self.object_permission, queryset=queryset,
|
|
user=self.request.user
|
|
)
|
|
|
|
return queryset
|
|
|
|
|
|
class RedirectionMixin(object):
|
|
action_cancel_redirect = None
|
|
post_action_redirect = None
|
|
|
|
def dispatch(self, request, *args, **kwargs):
|
|
post_action_redirect = self.get_post_action_redirect()
|
|
action_cancel_redirect = self.get_action_cancel_redirect()
|
|
|
|
self.next_url = self.request.POST.get(
|
|
'next', self.request.GET.get(
|
|
'next', post_action_redirect if post_action_redirect else self.request.META.get(
|
|
'HTTP_REFERER', resolve_url(settings.LOGIN_REDIRECT_URL)
|
|
)
|
|
)
|
|
)
|
|
self.previous_url = self.request.POST.get(
|
|
'previous', self.request.GET.get(
|
|
'previous', action_cancel_redirect if action_cancel_redirect else self.request.META.get(
|
|
'HTTP_REFERER', resolve_url(settings.LOGIN_REDIRECT_URL)
|
|
)
|
|
)
|
|
)
|
|
|
|
return super(
|
|
RedirectionMixin, self
|
|
).dispatch(request, *args, **kwargs)
|
|
|
|
def get_action_cancel_redirect(self):
|
|
return self.action_cancel_redirect
|
|
|
|
def get_context_data(self, **kwargs):
|
|
context = super(RedirectionMixin, self).get_context_data(**kwargs)
|
|
context.update(
|
|
{
|
|
'next': self.next_url,
|
|
'previous': self.previous_url
|
|
}
|
|
)
|
|
|
|
return context
|
|
|
|
def get_post_action_redirect(self):
|
|
return self.post_action_redirect
|
|
|
|
def get_success_url(self):
|
|
return self.next_url or self.previous_url
|
|
|
|
|
|
class ViewPermissionCheckMixin(object):
|
|
view_permission = None
|
|
|
|
def dispatch(self, request, *args, **kwargs):
|
|
if self.view_permission:
|
|
Permission.check_permissions(
|
|
permissions=(self.view_permission,),
|
|
requester=self.request.user
|
|
)
|
|
|
|
return super(
|
|
ViewPermissionCheckMixin, self
|
|
).dispatch(request, *args, **kwargs)
|