Commit Graph

59 Commits

Author SHA1 Message Date
Roberto Rosario
5e4518211f Remove related attribute of check_access
Remove filter_by_access. Replaced by restrict_queryset.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-05-07 02:26:50 -04:00
Roberto Rosario
95a1df8072 Backport common mixin and generics improvements
* Rename get_object_list to get_source_queryset.
* Add uniqueness validation to SingleObjectCreateView.
* Remove MultipleInstanceActionMixin.
* Backport MultipleObjectMixin improvements.
* Remove ObjectListPermissionFilterMixin.
* Add and improve tests.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-05-06 02:07:35 -04:00
Roberto Rosario
8e731d6280 Backport ACL computation improvements
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-05-04 03:27:30 -04:00
Roberto Rosario
74c97314d7 Code style cleanups
Add keyword arguments. Sort arguments and models.
Move literals to their own module. Prepend handler_ to
signal handlers.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-04-26 03:32:35 -04:00
Roberto Rosario
4c0b3e9134 Add keyword arguments to the reverse use in views
Signed-off-by: Roberto Rosario <Roberto.Rosario.Gonzalez@gmail.com>
2019-04-16 19:25:37 -04:00
Roberto Rosario
6bd8206236 Add keyword arguments to messages uses
Signed-off-by: Roberto Rosario <Roberto.Rosario.Gonzalez@gmail.com>
2019-04-16 19:02:41 -04:00
Roberto Rosario
663eb1b360 Fix checkout list view
Add tests for the checkout list view.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-04-13 02:35:56 -04:00
Roberto Rosario
f6f9287e33 Add keyword arguments to get_object_or_404 uses
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-04-11 20:53:33 -04:00
Roberto Rosario
456c322c19 Move add_to_class functions to their own module
* The new module is called methods.py and found on each app.
* Add keyword arguments to add_to_class instances.
* Remove catch all exception handling for the check in and
  check out views.
* Improve checkouts tests code reducing redundant code.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-04-11 18:03:53 -04:00
Roberto Rosario
36a51eeb73 Switch to full app paths
Instead of inserting the path of the apps into the Python app,
the apps are now referenced by their full import path.

This solves name clashes with external or native Python libraries.
Example: Mayan statistics app vs. Python new statistics library.

Every app reference is now prepended with 'mayan.apps'.

Existing config.yml files need to be updated manually.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2019-04-05 02:02:57 -04:00
Roberto Rosario
64ca5a623f PEP8 cleanups.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2018-09-05 04:56:39 -04:00
Roberto Rosario
d6b767eb93 Fix typos from the 3-way "papercut" patch merge.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2018-08-24 01:23:13 -04:00
Roberto Rosario
9273eccbd6 Add support for extended templates when there are no results. Add help messages and useful links to several apps when there are no results available.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2018-08-23 19:45:48 -04:00
Roberto Rosario
4c3ca0de91 In addition to the document view permission, the checkout detail view permission is now needed to view the list of checked out document.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2018-08-23 03:34:49 -04:00
Roberto Rosario
f09321f6ab Fix deprecation warnings for Django 1.11 and Django 2.0.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2017-07-21 00:25:18 -04:00
Roberto Rosario
ff59f34b7f Add document list item view.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
2017-07-13 17:20:02 -04:00
Roberto Rosario
5893e149e0 Reduce the check_access boilerplate code. 2016-11-02 04:58:05 -04:00
Roberto Rosario
180c38b746 PEP8 cleanups. 2016-03-09 23:31:03 -04:00
Roberto Rosario
45e90da219 Convert the checkout detail view to use the DetailView CBV. Update usage the DetailView CBV in the DocumentProperties view. Add checkout details view permission. 2016-03-09 23:27:02 -04:00
Roberto Rosario
7e365de569 Code style updates. 2015-10-26 02:24:52 -04:00
Roberto Rosario
40b94e41d8 Fix document check in view. Fixes issue GH#238. 2015-10-09 23:42:34 -04:00
Roberto Rosario
6ca6cd9f21 PEP8 Cleanusp (549 warnings). 2015-09-16 04:15:10 -04:00
Roberto Rosario
e1a04d9838 Convert document trash view to CBV. Improve ConfirmView based CBVs. 2015-09-15 02:02:38 -04:00
Roberto Rosario
d9cc8520b1 Render remaining date usage properly. 2015-08-20 00:27:48 -04:00
Roberto Rosario
d04117d345 PEP8 and code style cleanups. Replace lists with tuples. 2015-08-12 04:41:59 -04:00
Roberto Rosario
49ec79b36a Code style updates. 2015-08-12 03:55:50 -04:00
Roberto Rosario
1e746c700a PEP8 cleanups. 2015-07-27 23:53:14 -04:00
Roberto Rosario
4527563d89 PEP8 cleanups, specially E501 line too long. 2015-07-22 18:21:37 -04:00
Roberto Rosario
afe6644321 Use shorter confirmation messages. 2015-07-17 19:52:17 -04:00
Roberto Rosario
a0ff961d59 Move get_object_name from common.utils to the only place it is used: checkouts. 2015-07-08 02:43:28 -04:00
Roberto Rosario
efad777656 Cleanups. 2015-07-07 20:52:10 -04:00
Roberto Rosario
e7224474e6 Convert document checkout view to CBV. 2015-07-07 20:49:20 -04:00
Roberto Rosario
23fda5561e Propery filter documents queryset on CBV that return a list of documents. 2015-07-01 17:01:41 -04:00
Roberto Rosario
ace76fc69c Update apps for new ACLs refactor. 2015-07-01 16:36:20 -04:00
Roberto Rosario
3754f45001 Reduce checked out document column label string size. Refactor roles: roles can only have groups as members, only roles can hold permissions. 2015-06-29 14:07:02 -04:00
Roberto Rosario
1c084aa07b Split Permission and StoredPermission class and model into different modules. Simplified the Permission class. 2015-06-28 01:03:29 -04:00
Roberto Rosario
d26402974a Allow registering permission from the permission namespace. Replace all permission variables to be lowercase (style guide reserver uppercase variables for constants and literals). 2015-06-28 00:19:49 -04:00
Roberto Rosario
91150a7f51 Change the user_object of the DocumentCheckout model to be just a FK to the User model 2015-06-16 23:35:23 -04:00
Roberto Rosario
c8268b1a5b Move new document version blocking logic to the checkouts app. Remove PERMISSION_DOCUMENT_RESTRICTIONS_OVERRIDE, overriding checkout restrictions even for admin users has the potential to confuse or corrupt data, removing it. Even admins must now checkin a document before trying to perform a restricted operation. 2015-06-16 20:38:45 -04:00
Roberto Rosario
9084c3c651 Simplify and remove old code 2015-04-07 16:04:09 -04:00
Roberto Rosario
d79f36bfcb Replace function views with class based views 2015-04-06 20:24:18 -04:00
Roberto Rosario
23fc9f1e36 Merge main and common apps, extract authentication functionality to new authentication app. Closes issues #179 and #180 2015-04-06 16:09:54 -04:00
Roberto Rosario
5dabc0a34a Add new appearance app to hold all of the base templates, images, icons and external packages related to the frontend and look of the project 2015-03-30 02:17:40 -04:00
Roberto Rosario
b55acb6e12 Normalize import style 2015-01-24 17:05:32 -04:00
Roberto Rosario
febe21db1b Improve document related views titles messages, improve pluralization. 2015-01-24 14:25:31 -04:00
Roberto Rosario
d59ea3ede2 Add from __future__ import unicode_literals, issue #37 2015-01-19 04:06:40 -04:00
Roberto Rosario
5b718da664 Simplify text messages, add proper pluralization 2015-01-18 02:41:01 -04:00
Roberto Rosario
1287cca3ac Remove validation from the form and views 2014-11-04 17:37:05 -04:00
Roberto Rosario
2c2dfa88cc Issue #84, Remove template context variable 'object_name' to improve ease of translation 2014-10-28 02:36:43 -04:00
Roberto Rosario
71e8502614 Remove confirmation template's form icon 2014-10-25 02:21:44 -04:00