Improve document indexing tests and add test for GitLab issue #268 @bat79a

mayan/apps/document_indexing/tests/literals.py

@@ -0,0 +1,9 @@
+from __future__ import unicode_literals
+
+TEST_INDEX_LABEL = 'test label'
+TEST_INDEX_LABEL_EDITED = 'test edited label'
+TEST_INDEX_SLUG = 'test_slug'
+TEST_METADATA_TYPE_LABEL = 'test metadata label'
+TEST_METADATA_TYPE_NAME = 'test_metadata_name'
+TEST_INDEX_TEMPLATE_METADATA_EXPRESSION = '{{ document.metadata_value_of.%s }}' % TEST_METADATA_TYPE_NAME
+TEST_INDEX_TEMPLATE_LABEL_EXPRESSION = '{{ document.labe }}'

mayan/apps/document_indexing/tests/test_models.py

@@ -9,6 +9,11 @@ from metadata.models import MetadataType, DocumentTypeMetadataType
 
 from ..models import Index, IndexInstanceNode, IndexTemplateNode
 
+from .literals import (
+    TEST_INDEX_LABEL, TEST_INDEX_TEMPLATE_METADATA_EXPRESSION,
+    TEST_METADATA_TYPE_LABEL, TEST_METADATA_TYPE_NAME
+)
+
 
 @override_settings(OCR_AUTO_OCR=False)
 class IndexTestCase(TestCase):
@@ -23,37 +28,33 @@ class IndexTestCase(TestCase):
             )
 
     def tearDown(self):
-        for document_type in DocumentType.objects.all():
-            document_type.delete()
+        self.document_type.delete()
 
     def test_indexing(self):
-        metadata_type = MetadataType.objects.create(name='test', label='test')
+        metadata_type = MetadataType.objects.create(
+            name=TEST_METADATA_TYPE_NAME, label=TEST_METADATA_TYPE_LABEL
+        )
         DocumentTypeMetadataType.objects.create(
             document_type=self.document_type, metadata_type=metadata_type
         )
 
         # Create empty index
-        index = Index.objects.create(label='test')
-        self.assertQuerysetEqual(Index.objects.all(), [repr(index)])
+        index = Index.objects.create(label=TEST_INDEX_LABEL)
 
         # Add our document type to the new index
         index.document_types.add(self.document_type)
-        self.assertQuerysetEqual(index.document_types.all(), [repr(self.document_type)])
 
         # Create simple index template
         root = index.template_root
         index.node_templates.create(
-            parent=root, expression='{{ document.metadata_value_of.test }}',
+            parent=root, expression=TEST_INDEX_TEMPLATE_METADATA_EXPRESSION,
             link_documents=True
         )
-        self.assertEqual(
-            list(
-                IndexTemplateNode.objects.values_list('expression', flat=True)
-            ), ['', '{{ document.metadata_value_of.test }}']
-        )
 
         # Add document metadata value to trigger index node instance creation
-        self.document.metadata.create(metadata_type=metadata_type, value='0001')
+        self.document.metadata.create(
+            metadata_type=metadata_type, value='0001'
+        )
         self.assertEqual(
             list(
                 IndexInstanceNode.objects.values_list('value', flat=True)
@@ -67,7 +68,9 @@ class IndexTestCase(TestCase):
         )
 
         # Change document metadata value to trigger index node instance update
-        document_metadata = self.document.metadata.get(metadata_type=metadata_type)
+        document_metadata = self.document.metadata.get(
+            metadata_type=metadata_type
+        )
         document_metadata.value = '0002'
         document_metadata.save()
         self.assertEqual(
@@ -90,7 +93,8 @@ class IndexTestCase(TestCase):
             ), ['']
         )
 
-        # Add document metadata value again to trigger index node instance creation
+        # Add document metadata value again to trigger index node instance
+        # creation
         self.document.metadata.create(
             metadata_type=metadata_type, value='0003'
         )

mayan/apps/document_indexing/tests/test_views.py

@@ -5,15 +5,16 @@ from user_management.tests import (
     TEST_USER_USERNAME, TEST_USER_PASSWORD
 )
 
-from ..models import Index
+from ..models import Index, IndexInstanceNode
 from ..permissions import (
     permission_document_indexing_create, permission_document_indexing_delete,
-    permission_document_indexing_edit
+    permission_document_indexing_edit, permission_document_indexing_view
 )
 
-TEST_INDEX_LABEL = 'test label'
-TEST_INDEX_EDITED_LABEL = 'test edited label'
-TEST_INDEX_SLUG = 'test_slug'
+from .literals import (
+    TEST_INDEX_LABEL, TEST_INDEX_LABEL_EDITED, TEST_INDEX_SLUG,
+    TEST_INDEX_TEMPLATE_LABEL_EXPRESSION
+)
 
 
 class IndexViewTestCase(GenericDocumentViewTestCase):
@@ -84,7 +85,7 @@ class IndexViewTestCase(GenericDocumentViewTestCase):
 
         response = self.post(
             'indexing:index_setup_edit', args=(index.pk,), data={
-                'label': TEST_INDEX_EDITED_LABEL, 'slug': TEST_INDEX_SLUG
+                'label': TEST_INDEX_LABEL_EDITED, 'slug': TEST_INDEX_SLUG
             }
         )
         self.assertEqual(response.status_code, 403)
@@ -104,10 +105,55 @@ class IndexViewTestCase(GenericDocumentViewTestCase):
 
         response = self.post(
             'indexing:index_setup_edit', args=(index.pk,), data={
-                'label': TEST_INDEX_EDITED_LABEL, 'slug': TEST_INDEX_SLUG
+                'label': TEST_INDEX_LABEL_EDITED, 'slug': TEST_INDEX_SLUG
             }, follow=True
         )
 
         index = Index.objects.get(pk=index.pk)
         self.assertContains(response, text='update', status_code=200)
-        self.assertEqual(index.label, TEST_INDEX_EDITED_LABEL)
+        self.assertEqual(index.label, TEST_INDEX_LABEL_EDITED)
+
+    def create_test_index(self):
+        # Create empty index
+        index = Index.objects.create(label=TEST_INDEX_LABEL)
+
+        # Add our document type to the new index
+        index.document_types.add(self.document_type)
+
+        # Create simple index template
+        root = index.template_root
+        index.node_templates.create(
+            parent=root, expression=TEST_INDEX_TEMPLATE_LABEL_EXPRESSION,
+            link_documents=True
+        )
+
+        # Rebuild indexes
+        IndexInstanceNode.objects.rebuild_all_indexes()
+
+        return index
+
+    def test_index_instance_node_view_no_permission(self):
+        index = self.create_test_index()
+
+        self.login(username=TEST_USER_USERNAME, password=TEST_USER_PASSWORD)
+
+        response = self.get(
+            'indexing:index_instance_node_view', args=(index.instance_root.pk,)
+        )
+
+        self.assertEqual(response.status_code, 403)
+
+    def test_index_instance_node_view_with_permission(self):
+        index = self.create_test_index()
+
+        self.login(username=TEST_USER_USERNAME, password=TEST_USER_PASSWORD)
+
+        self.role.permissions.add(
+            permission_document_indexing_view.stored_permission
+        )
+
+        response = self.get(
+            'indexing:index_instance_node_view', args=(index.instance_root.pk,)
+        )
+
+        self.assertContains(response, text=TEST_INDEX_LABEL, status_code=200)