Raise errors when DEBUG is True

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-06-14 00:20:14 -04:00
parent 8d0f14a40c
commit 891861eaf5

View File

@@ -1,5 +1,6 @@
from __future__ import absolute_import, unicode_literals
from django.conf import settings
from django.contrib import messages
from django.core.exceptions import ImproperlyConfigured, ValidationError
from django.db import transaction
@@ -513,6 +514,7 @@ class SingleObjectCreateView(
try:
self.object.validate_unique()
except ValidationError as exception:
raise
context = self.get_context_data()
error_message = self.get_error_message_duplicate() or _(
@@ -531,17 +533,21 @@ class SingleObjectCreateView(
try:
self.object.save(**save_extra_data)
except Exception as exception:
context = self.get_context_data()
raise
if settings.DEBUG:
raise
else:
context = self.get_context_data()
messages.error(
message=_('%(object)s not created, error: %(error)s') % {
'object': self.get_object_name(context=context),
'error': exception
}, request=self.request
)
return super(
SingleObjectCreateView, self
).form_invalid(form=form)
messages.error(
message=_('%(object)s not created, error: %(error)s') % {
'object': self.get_object_name(context=context),
'error': exception
}, request=self.request
)
return super(
SingleObjectCreateView, self
).form_invalid(form=form)
else:
context = self.get_context_data()
@@ -558,12 +564,6 @@ class SingleObjectCreateView(
return self.error_message_duplicate
class SingleObjectDynamicFormCreateView(
DynamicFormViewMixin, SingleObjectCreateView
):
pass
class SingleObjectDeleteView(
ObjectNameMixin, DeleteExtraDataMixin, ViewPermissionCheckMixin,
RestrictedQuerysetMixin, ExtraContextMixin, RedirectionMixin, DeleteView
@@ -597,8 +597,7 @@ class SingleObjectDeleteView(
'error': exception
}, request=self.request
)
raise exception
raise
else:
messages.success(
message=_(
@@ -659,6 +658,12 @@ class SingleObjectDownloadView(ViewPermissionCheckMixin, ObjectPermissionCheckMi
VirtualFile = VirtualFile
class SingleObjectDynamicFormCreateView(
DynamicFormViewMixin, SingleObjectCreateView
):
pass
class SingleObjectEditView(
ObjectNameMixin, ViewPermissionCheckMixin, RestrictedQuerysetMixin,
ExtraContextMixin, FormExtraKwargsMixin, RedirectionMixin, UpdateView
@@ -685,15 +690,18 @@ class SingleObjectEditView(
try:
self.object.save(**save_extra_data)
except Exception as exception:
messages.error(
message=_('%(object)s not updated, error: %(error)s.') % {
'object': object_name,
'error': exception
}, request=self.request
)
return super(
SingleObjectEditView, self
).form_invalid(form=form)
if settings.DEBUG:
raise
else:
messages.error(
message=_('%(object)s not updated, error: %(error)s.') % {
'object': object_name,
'error': exception
}, request=self.request
)
return super(
SingleObjectEditView, self
).form_invalid(form=form)
else:
messages.success(
message=_(