PEP8 cleanups.

This commit is contained in:
Roberto Rosario
2015-08-25 19:17:55 -04:00
parent 4432cb5c2e
commit 7a45164251
7 changed files with 38 additions and 23 deletions

View File

@@ -71,10 +71,3 @@ class Comment(models.Model):
ordering = ('-submit_date',)
verbose_name = _('Comment')
verbose_name_plural = _('Comments')

View File

@@ -4,8 +4,20 @@ from django.conf.urls import patterns, url
urlpatterns = patterns(
'document_signatures.views',
url(r'^verify/(?P<document_pk>\d+)/$', 'document_verify', name='document_verify'),
url(r'^upload/signature/(?P<document_pk>\d+)/$', 'document_signature_upload', name='document_signature_upload'),
url(r'^download/signature/(?P<document_pk>\d+)/$', 'document_signature_download', name='document_signature_download'),
url(r'^document/(?P<document_pk>\d+)/signature/delete/$', 'document_signature_delete', name='document_signature_delete'),
url(
r'^verify/(?P<document_pk>\d+)/$', 'document_verify',
name='document_verify'
),
url(
r'^upload/signature/(?P<document_pk>\d+)/$',
'document_signature_upload', name='document_signature_upload'
),
url(
r'^download/signature/(?P<document_pk>\d+)/$',
'document_signature_download', name='document_signature_download'
),
url(
r'^document/(?P<document_pk>\d+)/signature/delete/$',
'document_signature_delete', name='document_signature_delete'
),
)

View File

@@ -42,7 +42,7 @@ class DocumentPageSerializer(serializers.HyperlinkedModelSerializer):
'url': {'view_name': 'rest_api:documentpage-detail'},
'document_version': {
'view_name': 'rest_api:documentversion-detail'
}
}
}
model = DocumentPage

View File

@@ -968,7 +968,10 @@ class DocumentTypeDeleteView(SingleObjectDeleteView):
class DocumentTypeEditView(SingleObjectEditView):
fields = ('label', 'trash_time_period', 'trash_time_unit', 'delete_time_period', 'delete_time_unit')
fields = (
'label', 'trash_time_period', 'trash_time_unit', 'delete_time_period',
'delete_time_unit'
)
model = DocumentType
post_action_redirect = reverse_lazy('documents:document_type_list')
view_permission = permission_document_type_edit
@@ -981,7 +984,10 @@ class DocumentTypeEditView(SingleObjectEditView):
class DocumentTypeCreateView(SingleObjectCreateView):
fields = ('label', 'trash_time_period', 'trash_time_unit', 'delete_time_period', 'delete_time_unit')
fields = (
'label', 'trash_time_period', 'trash_time_unit', 'delete_time_period',
'delete_time_unit'
)
model = DocumentType
post_action_redirect = reverse_lazy('documents:document_type_list')
view_permission = permission_document_type_create
@@ -1107,13 +1113,19 @@ def document_clear_image_cache(request):
class DocumentVersionListView(SingleObjectListView):
def dispatch(self, request, *args, **kwargs):
try:
Permission.check_permissions(request.user, (permission_document_view,))
Permission.check_permissions(
request.user, (permission_document_view,)
)
except PermissionDenied:
AccessControlList.objects.check_access(permission_document_view, request.user, self.get_document())
AccessControlList.objects.check_access(
permission_document_view, request.user, self.get_document()
)
self.get_document().add_as_recent_document_for_user(request.user)
return super(DocumentVersionListView, self).dispatch(request, *args, **kwargs)
return super(
DocumentVersionListView, self
).dispatch(request, *args, **kwargs)
def get_document(self):
return get_object_or_404(Document, pk=self.kwargs['pk'])

View File

@@ -81,7 +81,7 @@ class MetadataTestCase(TestCase):
document_metadata.save()
# Should not return error
document_metadata.value=TEST_CORRECT_LOOKUP_VALUE
document_metadata.value = TEST_CORRECT_LOOKUP_VALUE
document_metadata.full_clean()
document_metadata.save()
@@ -100,7 +100,7 @@ class MetadataTestCase(TestCase):
document_metadata.save()
# Should not return error
document_metadata.value=TEST_VALID_DATE
document_metadata.value = TEST_VALID_DATE
document_metadata.full_clean()
document_metadata.save()
@@ -119,7 +119,7 @@ class MetadataTestCase(TestCase):
document_metadata.save()
# Should not return error
document_metadata.value=TEST_VALID_DATE
document_metadata.value = TEST_VALID_DATE
document_metadata.full_clean()
document_metadata.save()

View File

@@ -2,8 +2,6 @@ from __future__ import unicode_literals
from django.template import Library
from common.utils import return_attrib
from ..classes import Menu, SourceColumn
from ..forms import MultiItemForm

View File

@@ -220,7 +220,7 @@ def user_set_password(request, user_id=None, user_id_list=None):
except Exception as exception:
messages.error(
request, _(
'Error reseting password for user "%(user)s": %(error)s'
'Error reseting password for user "%(user)s": %(error)s'
) % {
'user': user, 'error': exception
}