Model.save() errors are being silently ignored by Django REST Framework.
Force raising a ValidationError on Model.save() errors. GitLab issue #348 and #349.
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
from __future__ import unicode_literals
|
||||
|
||||
from rest_framework import serializers
|
||||
from rest_framework.serializers import ValidationError
|
||||
|
||||
from common.models import SharedUploadedFile
|
||||
|
||||
@@ -81,6 +82,16 @@ class DocumentVersionSerializer(serializers.HyperlinkedModelSerializer):
|
||||
model = DocumentVersion
|
||||
read_only_fields = ('document', 'file')
|
||||
|
||||
def update(self, instance, validated_data):
|
||||
try:
|
||||
super(DocumentVersionSerializer, self).update(
|
||||
instance, validated_data
|
||||
)
|
||||
except Exception as exception:
|
||||
raise ValidationError(unicode(exception))
|
||||
|
||||
return instance
|
||||
|
||||
|
||||
class DocumentVersionRevertSerializer(DocumentVersionSerializer):
|
||||
class Meta(DocumentVersionSerializer.Meta):
|
||||
|
||||
Reference in New Issue
Block a user