From 288de26d2b357106c8026b246ff46032f21e6721 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Sat, 28 Jan 2017 18:13:27 -0400 Subject: [PATCH] Model.save() errors are being silently ignored by Django REST Framework. Force raising a ValidationError on Model.save() errors. GitLab issue #348 and #349. --- mayan/apps/documents/serializers.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/mayan/apps/documents/serializers.py b/mayan/apps/documents/serializers.py index 8a07cb12d4..4dbc21a21f 100644 --- a/mayan/apps/documents/serializers.py +++ b/mayan/apps/documents/serializers.py @@ -1,6 +1,7 @@ from __future__ import unicode_literals from rest_framework import serializers +from rest_framework.serializers import ValidationError from common.models import SharedUploadedFile @@ -81,6 +82,16 @@ class DocumentVersionSerializer(serializers.HyperlinkedModelSerializer): model = DocumentVersion read_only_fields = ('document', 'file') + def update(self, instance, validated_data): + try: + super(DocumentVersionSerializer, self).update( + instance, validated_data + ) + except Exception as exception: + raise ValidationError(unicode(exception)) + + return instance + class DocumentVersionRevertSerializer(DocumentVersionSerializer): class Meta(DocumentVersionSerializer.Meta):