matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'defect/619-fix-poplib-initialization' into 'master'

Browse Source 
Fix kwargs for poplib.POP3_SSL and poplib.POP3

Closes #619

See merge request mayan-edms/mayan-edms!50
This commit is contained in:
Roberto Rosario
2019-06-20 03:51:31 +00:00
parent ea7b4e46ac e09bd48d65
commit 0494fa9e6a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mayan/apps/sources/models/email_sources.py
View File

@@ -277,10 +277,10 @@ class POP3Email(EmailBaseModel):
logger.debug('ssl: %s', self.ssl)
if self.ssl:
mailbox = poplib.POP3_SSL(host=self.host, post=self.port)
mailbox = poplib.POP3_SSL(host=self.host, port=self.port)
else:
mailbox = poplib.POP3(
host=self.host, post=self.port, timeout=self.timeout
host=self.host, port=self.port, timeout=self.timeout
)
mailbox.getwelcome()

2
mayan/apps/sources/tests/test_models.py
View File

@@ -217,7 +217,7 @@ class POP3SourceTestCase(GenericDocumentTestCase):
def user(self, username):
return
@mock.patch('poplib.POP3_SSL')
@mock.patch('poplib.POP3_SSL', autospec=True)
def test_download_document(self, mock_poplib):
mock_poplib.return_value = POP3SourceTestCase.MockMailbox()
self.source = POP3Email.objects.create(