Applied readability-avoid-const-params-in-decls clang-tidy fixes

This commit is contained in:
Bartek Kryza
2022-12-21 17:19:50 +01:00
parent d6a5134ba7
commit 25f787785f
9 changed files with 20 additions and 22 deletions

View File

@@ -49,7 +49,7 @@ public:
const std::string &full_name) const override; const std::string &full_name) const override;
common::optional_ref<common::model::diagram_element> get( common::optional_ref<common::model::diagram_element> get(
const clanguml::common::model::diagram_element::id_t id) const override; clanguml::common::model::diagram_element::id_t id) const override;
const common::reference_vector<class_> &classes() const; const common::reference_vector<class_> &classes() const;
@@ -82,10 +82,10 @@ public:
void get_parents(clanguml::common::reference_set<class_> &parents) const; void get_parents(clanguml::common::reference_set<class_> &parents) const;
friend void print_diagram_tree(const diagram &d, const int level); friend void print_diagram_tree(const diagram &d, int level);
bool has_element( bool has_element(
const clanguml::common::model::diagram_element::id_t id) const override; clanguml::common::model::diagram_element::id_t id) const override;
inja::json context() const override; inja::json context() const override;

View File

@@ -43,7 +43,7 @@ public:
const std::string &full_name) const = 0; const std::string &full_name) const = 0;
virtual common::optional_ref<clanguml::common::model::diagram_element> get( virtual common::optional_ref<clanguml::common::model::diagram_element> get(
const diagram_element::id_t id) const = 0; diagram_element::id_t id) const = 0;
/// \brief Find element in diagram which can have full name or be /// \brief Find element in diagram which can have full name or be
/// relative to ns /// relative to ns
@@ -67,9 +67,9 @@ public:
bool should_include(const element &e) const; bool should_include(const element &e) const;
bool should_include(const std::string &e) const; bool should_include(const std::string &e) const;
bool should_include(const source_file &path) const; bool should_include(const source_file &path) const;
bool should_include(const relationship r) const; bool should_include(relationship r) const;
bool should_include(const relationship_t r) const; bool should_include(relationship_t r) const;
bool should_include(const access_t s) const; bool should_include(access_t s) const;
virtual bool has_element(const diagram_element::id_t id) const virtual bool has_element(const diagram_element::id_t id) const
{ {

View File

@@ -120,7 +120,7 @@ using relationship_hints_t = std::map<std::string, relationship_hint_t>;
using type_aliases_t = std::map<std::string, std::string>; using type_aliases_t = std::map<std::string, std::string>;
std::string to_string(const hint_t t); std::string to_string(hint_t t);
struct inheritable_diagram_options { struct inheritable_diagram_options {
option<std::vector<std::string>> glob{"glob"}; option<std::vector<std::string>> glob{"glob"};

View File

@@ -45,7 +45,7 @@ public:
const std::string &full_name) const override; const std::string &full_name) const override;
common::optional_ref<common::model::diagram_element> get( common::optional_ref<common::model::diagram_element> get(
const common::model::diagram_element::id_t id) const override; common::model::diagram_element::id_t id) const override;
void add_file(std::unique_ptr<common::model::source_file> &&f); void add_file(std::unique_ptr<common::model::source_file> &&f);
@@ -53,7 +53,7 @@ public:
const std::string &name) const; const std::string &name) const;
common::optional_ref<common::model::source_file> get_file( common::optional_ref<common::model::source_file> get_file(
const common::model::diagram_element::id_t id) const; common::model::diagram_element::id_t id) const;
std::string to_alias(const std::string &full_name) const; std::string to_alias(const std::string &full_name) const;

View File

@@ -56,11 +56,11 @@ public:
std::optional<common::id_t> process_internal_header( std::optional<common::id_t> process_internal_header(
const std::filesystem::path &include_path, bool is_system, const std::filesystem::path &include_path, bool is_system,
const common::id_t current_file_id); common::id_t current_file_id);
std::optional<common::id_t> process_external_system_header( std::optional<common::id_t> process_external_system_header(
const std::filesystem::path &include_path, const std::filesystem::path &include_path,
const common::id_t current_file_id); common::id_t current_file_id);
std::optional<common::id_t> process_source_file( std::optional<common::id_t> process_source_file(
const std::filesystem::path &file); const std::filesystem::path &file);

View File

@@ -123,8 +123,8 @@ void find_translation_units_for_diagrams(
*/ */
void generate_diagrams(const std::vector<std::string> &diagram_names, void generate_diagrams(const std::vector<std::string> &diagram_names,
clanguml::config::config &config, const std::string &od, clanguml::config::config &config, const std::string &od,
const std::unique_ptr<clang::tooling::CompilationDatabase> &db, const std::unique_ptr<clang::tooling::CompilationDatabase> &db, int verbose,
const int verbose, const unsigned int thread_count, unsigned int thread_count,
const std::map<std::string, std::vector<std::string>> const std::map<std::string, std::vector<std::string>>
&translation_units_map); &translation_units_map);

View File

@@ -46,7 +46,7 @@ public:
const std::string &full_name) const override; const std::string &full_name) const override;
common::optional_ref<clanguml::common::model::diagram_element> get( common::optional_ref<clanguml::common::model::diagram_element> get(
const clanguml::common::model::diagram_element::id_t id) const override; clanguml::common::model::diagram_element::id_t id) const override;
void add_package(std::unique_ptr<common::model::package> &&p); void add_package(std::unique_ptr<common::model::package> &&p);
@@ -54,10 +54,9 @@ public:
const std::string &name) const; const std::string &name) const;
common::optional_ref<common::model::package> get_package( common::optional_ref<common::model::package> get_package(
const clanguml::common::model::diagram_element::id_t id) const; clanguml::common::model::diagram_element::id_t id) const;
std::string to_alias( std::string to_alias(clanguml::common::model::diagram_element::id_t) const;
const clanguml::common::model::diagram_element::id_t) const;
inja::json context() const override; inja::json context() const override;

View File

@@ -42,7 +42,7 @@ public:
const std::string &full_name) const override; const std::string &full_name) const override;
common::optional_ref<common::model::diagram_element> get( common::optional_ref<common::model::diagram_element> get(
const common::model::diagram_element::id_t id) const override; common::model::diagram_element::id_t id) const override;
std::string to_alias(const std::string &full_name) const; std::string to_alias(const std::string &full_name) const;
@@ -139,8 +139,7 @@ public:
const std::set<common::model::diagram_element::id_t> & const std::set<common::model::diagram_element::id_t> &
active_participants() const; active_participants() const;
void add_catch_stmt( void add_catch_stmt(common::model::diagram_element::id_t current_caller_id,
const common::model::diagram_element::id_t current_caller_id,
std::string caught_type); std::string caught_type);
private: private:

View File

@@ -144,7 +144,7 @@ public:
template <typename T = model::participant> template <typename T = model::participant>
const common::optional_ref<T> get_participant( const common::optional_ref<T> get_participant(
const common::model::diagram_element::id_t id) const common::model::diagram_element::id_t id) const
{ {
if (diagram().participants().find(id) == diagram().participants().end()) if (diagram().participants().find(id) == diagram().participants().end())
return {}; return {};