From 25f787785f30085ad4bfd89dfeda38e59d524630 Mon Sep 17 00:00:00 2001 From: Bartek Kryza Date: Wed, 21 Dec 2022 17:19:50 +0100 Subject: [PATCH] Applied readability-avoid-const-params-in-decls clang-tidy fixes --- src/class_diagram/model/diagram.h | 6 +++--- src/common/model/diagram.h | 8 ++++---- src/config/config.h | 2 +- src/include_diagram/model/diagram.h | 4 ++-- src/include_diagram/visitor/translation_unit_visitor.h | 4 ++-- src/main.cc | 4 ++-- src/package_diagram/model/diagram.h | 7 +++---- src/sequence_diagram/model/diagram.h | 5 ++--- src/sequence_diagram/visitor/translation_unit_visitor.h | 2 +- 9 files changed, 20 insertions(+), 22 deletions(-) diff --git a/src/class_diagram/model/diagram.h b/src/class_diagram/model/diagram.h index c168c38d..f2fd0841 100644 --- a/src/class_diagram/model/diagram.h +++ b/src/class_diagram/model/diagram.h @@ -49,7 +49,7 @@ public: const std::string &full_name) const override; common::optional_ref get( - const clanguml::common::model::diagram_element::id_t id) const override; + clanguml::common::model::diagram_element::id_t id) const override; const common::reference_vector &classes() const; @@ -82,10 +82,10 @@ public: void get_parents(clanguml::common::reference_set &parents) const; - friend void print_diagram_tree(const diagram &d, const int level); + friend void print_diagram_tree(const diagram &d, int level); bool has_element( - const clanguml::common::model::diagram_element::id_t id) const override; + clanguml::common::model::diagram_element::id_t id) const override; inja::json context() const override; diff --git a/src/common/model/diagram.h b/src/common/model/diagram.h index 9524cf99..63883c03 100644 --- a/src/common/model/diagram.h +++ b/src/common/model/diagram.h @@ -43,7 +43,7 @@ public: const std::string &full_name) const = 0; virtual common::optional_ref get( - const diagram_element::id_t id) const = 0; + diagram_element::id_t id) const = 0; /// \brief Find element in diagram which can have full name or be /// relative to ns @@ -67,9 +67,9 @@ public: bool should_include(const element &e) const; bool should_include(const std::string &e) const; bool should_include(const source_file &path) const; - bool should_include(const relationship r) const; - bool should_include(const relationship_t r) const; - bool should_include(const access_t s) const; + bool should_include(relationship r) const; + bool should_include(relationship_t r) const; + bool should_include(access_t s) const; virtual bool has_element(const diagram_element::id_t id) const { diff --git a/src/config/config.h b/src/config/config.h index 9d02d4e7..5bd8d477 100644 --- a/src/config/config.h +++ b/src/config/config.h @@ -120,7 +120,7 @@ using relationship_hints_t = std::map; using type_aliases_t = std::map; -std::string to_string(const hint_t t); +std::string to_string(hint_t t); struct inheritable_diagram_options { option> glob{"glob"}; diff --git a/src/include_diagram/model/diagram.h b/src/include_diagram/model/diagram.h index 0805a889..231bd6c3 100644 --- a/src/include_diagram/model/diagram.h +++ b/src/include_diagram/model/diagram.h @@ -45,7 +45,7 @@ public: const std::string &full_name) const override; common::optional_ref get( - const common::model::diagram_element::id_t id) const override; + common::model::diagram_element::id_t id) const override; void add_file(std::unique_ptr &&f); @@ -53,7 +53,7 @@ public: const std::string &name) const; common::optional_ref get_file( - const common::model::diagram_element::id_t id) const; + common::model::diagram_element::id_t id) const; std::string to_alias(const std::string &full_name) const; diff --git a/src/include_diagram/visitor/translation_unit_visitor.h b/src/include_diagram/visitor/translation_unit_visitor.h index 2dd00530..3fe0cde4 100644 --- a/src/include_diagram/visitor/translation_unit_visitor.h +++ b/src/include_diagram/visitor/translation_unit_visitor.h @@ -56,11 +56,11 @@ public: std::optional process_internal_header( const std::filesystem::path &include_path, bool is_system, - const common::id_t current_file_id); + common::id_t current_file_id); std::optional process_external_system_header( const std::filesystem::path &include_path, - const common::id_t current_file_id); + common::id_t current_file_id); std::optional process_source_file( const std::filesystem::path &file); diff --git a/src/main.cc b/src/main.cc index 290bd1f8..0383dfb3 100644 --- a/src/main.cc +++ b/src/main.cc @@ -123,8 +123,8 @@ void find_translation_units_for_diagrams( */ void generate_diagrams(const std::vector &diagram_names, clanguml::config::config &config, const std::string &od, - const std::unique_ptr &db, - const int verbose, const unsigned int thread_count, + const std::unique_ptr &db, int verbose, + unsigned int thread_count, const std::map> &translation_units_map); diff --git a/src/package_diagram/model/diagram.h b/src/package_diagram/model/diagram.h index 643f5c63..bfdc5328 100644 --- a/src/package_diagram/model/diagram.h +++ b/src/package_diagram/model/diagram.h @@ -46,7 +46,7 @@ public: const std::string &full_name) const override; common::optional_ref get( - const clanguml::common::model::diagram_element::id_t id) const override; + clanguml::common::model::diagram_element::id_t id) const override; void add_package(std::unique_ptr &&p); @@ -54,10 +54,9 @@ public: const std::string &name) const; common::optional_ref get_package( - const clanguml::common::model::diagram_element::id_t id) const; + clanguml::common::model::diagram_element::id_t id) const; - std::string to_alias( - const clanguml::common::model::diagram_element::id_t) const; + std::string to_alias(clanguml::common::model::diagram_element::id_t) const; inja::json context() const override; diff --git a/src/sequence_diagram/model/diagram.h b/src/sequence_diagram/model/diagram.h index 9b64482e..a26a31c4 100644 --- a/src/sequence_diagram/model/diagram.h +++ b/src/sequence_diagram/model/diagram.h @@ -42,7 +42,7 @@ public: const std::string &full_name) const override; common::optional_ref get( - const common::model::diagram_element::id_t id) const override; + common::model::diagram_element::id_t id) const override; std::string to_alias(const std::string &full_name) const; @@ -139,8 +139,7 @@ public: const std::set & active_participants() const; - void add_catch_stmt( - const common::model::diagram_element::id_t current_caller_id, + void add_catch_stmt(common::model::diagram_element::id_t current_caller_id, std::string caught_type); private: diff --git a/src/sequence_diagram/visitor/translation_unit_visitor.h b/src/sequence_diagram/visitor/translation_unit_visitor.h index 606738b1..f932c2ae 100644 --- a/src/sequence_diagram/visitor/translation_unit_visitor.h +++ b/src/sequence_diagram/visitor/translation_unit_visitor.h @@ -144,7 +144,7 @@ public: template const common::optional_ref get_participant( - const common::model::diagram_element::id_t id) const + common::model::diagram_element::id_t id) const { if (diagram().participants().find(id) == diagram().participants().end()) return {};