matthias/clang-uml
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Applied performance-unnecessary-value-param clang-tidy fixes

Browse Source
This commit is contained in:
Bartek Kryza
2022-12-20 23:15:59 +01:00
parent 6b883c4562
commit 177c68158a
13 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/decorators/decorators.cc
View File

@@ -51,7 +51,7 @@ std::shared_ptr<decorator> decorator::from_string(std::string_view c)
return {};
}
bool decorator::applies_to_diagram(std::string name)
bool decorator::applies_to_diagram(const std::string &name)
{
return diagrams.empty() ||
(std::find(diagrams.begin(), diagrams.end(), name) != diagrams.end());
@@ -174,7 +174,7 @@ std::shared_ptr<decorator> association::from_string(std::string_view c)
}
std::vector<std::shared_ptr<decorator>> parse(
std::string documentation_block, std::string clanguml_tag)
std::string documentation_block, const std::string &clanguml_tag)
{
std::vector<std::shared_ptr<decorator>> res;
const std::string begin_tag{"@" + clanguml_tag};

4
src/decorators/decorators.h
View File

@@ -40,7 +40,7 @@ struct decorator {
static std::shared_ptr<decorator> from_string(std::string_view c);
bool applies_to_diagram(std::string name);
bool applies_to_diagram(const std::string &name);
protected:
decorator_toks tokenize(const std::string &label, std::string_view c);
@@ -97,7 +97,7 @@ struct association : public relationship {
};
std::vector<std::shared_ptr<decorator>> parse(
std::string documentation_block, std::string clanguml_tag = "uml");
std::string documentation_block, const std::string &clanguml_tag = "uml");
} // namespace decorators
} // namespace clanguml