From 177c68158aef3b9695bb175d11ac27740e58d42e Mon Sep 17 00:00:00 2001 From: Bartek Kryza Date: Tue, 20 Dec 2022 23:15:59 +0100 Subject: [PATCH] Applied performance-unnecessary-value-param clang-tidy fixes --- .clang-tidy | 3 +++ src/class_diagram/model/class.cc | 2 +- src/class_diagram/model/class.h | 2 +- src/class_diagram/model/template_parameter.cc | 3 ++- src/class_diagram/model/template_parameter.h | 3 ++- src/common/generators/plantuml/generator.cc | 2 +- src/common/generators/plantuml/generator.h | 2 +- src/common/model/diagram_filter.cc | 4 ++-- src/common/model/diagram_filter.h | 4 ++-- src/cx/util.cc | 3 ++- src/cx/util.h | 3 ++- src/decorators/decorators.cc | 4 ++-- src/decorators/decorators.h | 4 ++-- 13 files changed, 23 insertions(+), 16 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 18e33c02..e4dfeb10 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -17,11 +17,14 @@ Checks: >- -hicpp-no-array-decay, -google-readability-todo, -google-default-arguments, + -google-explicit-constructor, -hicpp-signed-bitwise, + -hicpp-explicit-conversions, -llvmlibc-*, -llvm-header-guard, -llvm-namespace-comment, -misc-no-recursion, + -modernize-use-nodiscard, -modernize-use-trailing-return-type, -mpi*, -objc*, diff --git a/src/class_diagram/model/class.cc b/src/class_diagram/model/class.cc index 2e66f55d..2788eb38 100644 --- a/src/class_diagram/model/class.cc +++ b/src/class_diagram/model/class.cc @@ -68,7 +68,7 @@ void class_::add_parent(class_parent &&parent) bases_.emplace_back(std::move(parent)); } -void class_::add_template(template_parameter tmplt) +void class_::add_template(template_parameter &&tmplt) { templates_.emplace_back(std::move(tmplt)); } diff --git a/src/class_diagram/model/class.h b/src/class_diagram/model/class.h index 71504874..308f8ead 100644 --- a/src/class_diagram/model/class.h +++ b/src/class_diagram/model/class.h @@ -56,7 +56,7 @@ public: void add_member(class_member &&member); void add_method(class_method &&method); void add_parent(class_parent &&parent); - void add_template(template_parameter tmplt); + void add_template(template_parameter &&tmplt); const std::vector &members() const; const std::vector &methods() const; diff --git a/src/class_diagram/model/template_parameter.cc b/src/class_diagram/model/template_parameter.cc index e3f1a218..1fe15bcc 100644 --- a/src/class_diagram/model/template_parameter.cc +++ b/src/class_diagram/model/template_parameter.cc @@ -180,7 +180,8 @@ bool template_parameter::find_nested_relationships( std::vector> &nested_relationships, common::model::relationship_t hint, - std::function should_include) const + const std::function &should_include) + const { bool added_aggregation_relationship{false}; diff --git a/src/class_diagram/model/template_parameter.h b/src/class_diagram/model/template_parameter.h index aa8c44b2..19335e21 100644 --- a/src/class_diagram/model/template_parameter.h +++ b/src/class_diagram/model/template_parameter.h @@ -97,7 +97,8 @@ public: std::vector> &nested_relationships, common::model::relationship_t hint, - std::function should_include) const; + const std::function &should_include) + const; private: /// Represents the type of non-type template parameters diff --git a/src/common/generators/plantuml/generator.cc b/src/common/generators/plantuml/generator.cc index 5c74f327..755bab23 100644 --- a/src/common/generators/plantuml/generator.cc +++ b/src/common/generators/plantuml/generator.cc @@ -19,7 +19,7 @@ namespace clanguml::common::generators::plantuml { -std::string to_plantuml(relationship_t r, std::string style) +std::string to_plantuml(relationship_t r, const std::string &style) { switch (r) { case relationship_t::kOwnership: diff --git a/src/common/generators/plantuml/generator.h b/src/common/generators/plantuml/generator.h index afdf30cc..0846517c 100644 --- a/src/common/generators/plantuml/generator.h +++ b/src/common/generators/plantuml/generator.h @@ -37,7 +37,7 @@ using clanguml::common::model::element; using clanguml::common::model::message_t; using clanguml::common::model::relationship_t; -std::string to_plantuml(relationship_t r, std::string style); +std::string to_plantuml(relationship_t r, const std::string &style); std::string to_plantuml(access_t scope); std::string to_plantuml(message_t r); diff --git a/src/common/model/diagram_filter.cc b/src/common/model/diagram_filter.cc index fc0e273e..69b64aec 100644 --- a/src/common/model/diagram_filter.cc +++ b/src/common/model/diagram_filter.cc @@ -354,7 +354,7 @@ tvl::value_t context_filter::match(const diagram &d, const element &e) const } paths_filter::paths_filter(filter_t type, const std::filesystem::path &root, - std::vector p) + const std::vector &p) : filter_visitor{type} , root_{root} { @@ -420,7 +420,7 @@ void diagram_filter::add_exclusive_filter(std::unique_ptr fv) } bool diagram_filter::should_include( - namespace_ ns, const std::string &name) const + const namespace_ &ns, const std::string &name) const { if (should_include(ns)) { element e{namespace_{}}; diff --git a/src/common/model/diagram_filter.h b/src/common/model/diagram_filter.h index 8ff0213b..7df1e343 100644 --- a/src/common/model/diagram_filter.h +++ b/src/common/model/diagram_filter.h @@ -314,7 +314,7 @@ private: struct paths_filter : public filter_visitor { paths_filter(filter_t type, const std::filesystem::path &root, - std::vector p); + const std::vector &p); virtual ~paths_filter() = default; @@ -334,7 +334,7 @@ public: void add_exclusive_filter(std::unique_ptr fv); - bool should_include(namespace_ ns, const std::string &name) const; + bool should_include(const namespace_ &ns, const std::string &name) const; template bool should_include(const T &e) const { diff --git a/src/cx/util.cc b/src/cx/util.cc index 56fcc7f0..cff5d3b4 100644 --- a/src/cx/util.cc +++ b/src/cx/util.cc @@ -41,7 +41,8 @@ std::pair split_ns( std::vector parse_unexposed_template_params(const std::string ¶ms, - std::function ns_resolve, int depth) + const std::function &ns_resolve, + int depth) { using class_diagram::model::template_parameter; diff --git a/src/cx/util.h b/src/cx/util.h index 3b0af753..7ff8b9c8 100644 --- a/src/cx/util.h +++ b/src/cx/util.h @@ -29,6 +29,7 @@ std::pair split_ns( std::vector parse_unexposed_template_params(const std::string ¶ms, - std::function ns_resolve, int depth = 0); + const std::function &ns_resolve, + int depth = 0); } // namespace clanguml::cx::util diff --git a/src/decorators/decorators.cc b/src/decorators/decorators.cc index 90ed3a58..e9629541 100644 --- a/src/decorators/decorators.cc +++ b/src/decorators/decorators.cc @@ -51,7 +51,7 @@ std::shared_ptr decorator::from_string(std::string_view c) return {}; } -bool decorator::applies_to_diagram(std::string name) +bool decorator::applies_to_diagram(const std::string &name) { return diagrams.empty() || (std::find(diagrams.begin(), diagrams.end(), name) != diagrams.end()); @@ -174,7 +174,7 @@ std::shared_ptr association::from_string(std::string_view c) } std::vector> parse( - std::string documentation_block, std::string clanguml_tag) + std::string documentation_block, const std::string &clanguml_tag) { std::vector> res; const std::string begin_tag{"@" + clanguml_tag}; diff --git a/src/decorators/decorators.h b/src/decorators/decorators.h index 554759c0..6223cfb7 100644 --- a/src/decorators/decorators.h +++ b/src/decorators/decorators.h @@ -40,7 +40,7 @@ struct decorator { static std::shared_ptr from_string(std::string_view c); - bool applies_to_diagram(std::string name); + bool applies_to_diagram(const std::string &name); protected: decorator_toks tokenize(const std::string &label, std::string_view c); @@ -97,7 +97,7 @@ struct association : public relationship { }; std::vector> parse( - std::string documentation_block, std::string clanguml_tag = "uml"); + std::string documentation_block, const std::string &clanguml_tag = "uml"); } // namespace decorators } // namespace clanguml