uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Various fixes and improvements (#96)

Browse Source 
* Global variables shared between an interrupt and the main code should be volatile

See: https://www.embedded.com/electronics-blogs/beginner-s-corner/4023801/Introduction-to-the-Volatile-Keyword

* There is no reason to change the active report if it has not changed

* Declare local functions and variables static

This both helps the compiler and the programmer
This commit is contained in:
Kristian Sloth Lauszus
2018-03-11 19:19:15 +01:00
committed by László Monda
parent 1742437f8b
commit e12e219b4e
17 changed files with 69 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
right/src/usb_interfaces/usb_interface_basic_keyboard.c
View File

@@ -4,10 +4,10 @@
static usb_basic_keyboard_report_t usbBasicKeyboardReports[2];
uint32_t UsbBasicKeyboardActionCounter;
usb_basic_keyboard_report_t* ActiveUsbBasicKeyboardReport = usbBasicKeyboardReports;
bool IsUsbBasicKeyboardReportSent = false;
volatile bool IsUsbBasicKeyboardReportSent = false;
static uint8_t usbBasicKeyboardInBuffer[USB_BASIC_KEYBOARD_REPORT_LENGTH];
usb_basic_keyboard_report_t* getInactiveUsbBasicKeyboardReport(void)
static usb_basic_keyboard_report_t* getInactiveUsbBasicKeyboardReport(void)
{
return ActiveUsbBasicKeyboardReport == usbBasicKeyboardReports ? usbBasicKeyboardReports+1 : usbBasicKeyboardReports;
}