uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Various fixes and improvements (#96)

Browse Source 
* Global variables shared between an interrupt and the main code should be volatile

See: https://www.embedded.com/electronics-blogs/beginner-s-corner/4023801/Introduction-to-the-Volatile-Keyword

* There is no reason to change the active report if it has not changed

* Declare local functions and variables static

This both helps the compiler and the programmer
This commit is contained in:
Kristian Sloth Lauszus
2018-03-11 19:19:15 +01:00
committed by László Monda
parent 1742437f8b
commit e12e219b4e
17 changed files with 69 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
right/src/usb_interfaces/usb_interface_basic_keyboard.c
View File

@@ -4,10 +4,10 @@
static usb_basic_keyboard_report_t usbBasicKeyboardReports[2];
uint32_t UsbBasicKeyboardActionCounter;
usb_basic_keyboard_report_t* ActiveUsbBasicKeyboardReport = usbBasicKeyboardReports;
bool IsUsbBasicKeyboardReportSent = false;
volatile bool IsUsbBasicKeyboardReportSent = false;
static uint8_t usbBasicKeyboardInBuffer[USB_BASIC_KEYBOARD_REPORT_LENGTH];
usb_basic_keyboard_report_t* getInactiveUsbBasicKeyboardReport(void)
static usb_basic_keyboard_report_t* getInactiveUsbBasicKeyboardReport(void)
{
return ActiveUsbBasicKeyboardReport == usbBasicKeyboardReports ? usbBasicKeyboardReports+1 : usbBasicKeyboardReports;
}

2
right/src/usb_interfaces/usb_interface_basic_keyboard.h
View File

@@ -31,7 +31,7 @@
// Variables:
extern bool IsUsbBasicKeyboardReportSent;
extern volatile bool IsUsbBasicKeyboardReportSent;
extern uint32_t UsbBasicKeyboardActionCounter;
extern usb_basic_keyboard_report_t* ActiveUsbBasicKeyboardReport;

4
right/src/usb_interfaces/usb_interface_media_keyboard.c
View File

@@ -3,9 +3,9 @@
uint32_t UsbMediaKeyboardActionCounter;
static usb_media_keyboard_report_t usbMediaKeyboardReports[2];
usb_media_keyboard_report_t* ActiveUsbMediaKeyboardReport = usbMediaKeyboardReports;
bool IsUsbMediaKeyboardReportSent = false;
volatile bool IsUsbMediaKeyboardReportSent = false;
usb_media_keyboard_report_t* getInactiveUsbMediaKeyboardReport(void)
static usb_media_keyboard_report_t* getInactiveUsbMediaKeyboardReport(void)
{
return ActiveUsbMediaKeyboardReport == usbMediaKeyboardReports ? usbMediaKeyboardReports+1 : usbMediaKeyboardReports;
}

2
right/src/usb_interfaces/usb_interface_media_keyboard.h
View File

@@ -28,7 +28,7 @@
// Variables:
extern bool IsUsbMediaKeyboardReportSent;
extern volatile bool IsUsbMediaKeyboardReportSent;
extern uint32_t UsbMediaKeyboardActionCounter;
extern usb_media_keyboard_report_t* ActiveUsbMediaKeyboardReport;

4
right/src/usb_interfaces/usb_interface_mouse.c
View File

@@ -3,9 +3,9 @@
uint32_t UsbMouseActionCounter;
static usb_mouse_report_t usbMouseReports[2];
usb_mouse_report_t* ActiveUsbMouseReport = usbMouseReports;
bool IsUsbMouseReportSent = false;
volatile bool IsUsbMouseReportSent = false;
usb_mouse_report_t* getInactiveUsbMouseReport(void)
static usb_mouse_report_t* getInactiveUsbMouseReport(void)
{
return ActiveUsbMouseReport == usbMouseReports ? usbMouseReports+1 : usbMouseReports;
}

2
right/src/usb_interfaces/usb_interface_mouse.h
View File

@@ -31,7 +31,7 @@
// Variables:
extern bool IsUsbMouseReportSent;
extern volatile bool IsUsbMouseReportSent;
extern uint32_t UsbMouseActionCounter;
extern usb_mouse_report_t* ActiveUsbMouseReport;

4
right/src/usb_interfaces/usb_interface_system_keyboard.c
View File

@@ -3,9 +3,9 @@
uint32_t UsbSystemKeyboardActionCounter;
static usb_system_keyboard_report_t usbSystemKeyboardReports[2];
usb_system_keyboard_report_t* ActiveUsbSystemKeyboardReport = usbSystemKeyboardReports;
bool IsUsbSystemKeyboardReportSent = false;
volatile bool IsUsbSystemKeyboardReportSent = false;
usb_system_keyboard_report_t* getInactiveUsbSystemKeyboardReport()
static usb_system_keyboard_report_t* getInactiveUsbSystemKeyboardReport()
{
return ActiveUsbSystemKeyboardReport == usbSystemKeyboardReports ? usbSystemKeyboardReports+1 : usbSystemKeyboardReports;
}

2
right/src/usb_interfaces/usb_interface_system_keyboard.h
View File

@@ -29,7 +29,7 @@
// Variables:
extern bool IsUsbSystemKeyboardReportSent;
extern volatile bool IsUsbSystemKeyboardReportSent;
extern uint32_t UsbSystemKeyboardActionCounter;
extern usb_system_keyboard_report_t* ActiveUsbSystemKeyboardReport;