uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Various fixes and improvements (#96)

Browse Source 
* Global variables shared between an interrupt and the main code should be volatile

See: https://www.embedded.com/electronics-blogs/beginner-s-corner/4023801/Introduction-to-the-Volatile-Keyword

* There is no reason to change the active report if it has not changed

* Declare local functions and variables static

This both helps the compiler and the programmer
This commit is contained in:
Kristian Sloth Lauszus
2018-03-11 19:19:15 +01:00
committed by László Monda
parent 1742437f8b
commit e12e219b4e
17 changed files with 69 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
right/src/main.c
View File

@@ -11,15 +11,15 @@
#include "peripherals/reset_button.h"
#include "usb_report_updater.h"
bool IsEepromInitialized = false;
bool IsConfigInitialized = false;
static bool IsEepromInitialized = false;
static bool IsConfigInitialized = false;
void userConfigurationReadFinished(void)
static void userConfigurationReadFinished(void)
{
IsEepromInitialized = true;
}
void hardwareConfigurationReadFinished(void)
static void hardwareConfigurationReadFinished(void)
{
EEPROM_LaunchTransfer(EepromOperation_Read, ConfigBufferId_StagingUserConfig, userConfigurationReadFinished);
}