From b93f2115025ff248cfb3666af2cbd4f421c31417 Mon Sep 17 00:00:00 2001 From: Eric Tang Date: Fri, 29 Jun 2018 22:44:42 -0700 Subject: [PATCH] Don't retry sending a report if it fails --- right/src/usb_report_updater.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/right/src/usb_report_updater.c b/right/src/usb_report_updater.c index fa23530..c82c46f 100644 --- a/right/src/usb_report_updater.c +++ b/right/src/usb_report_updater.c @@ -407,8 +407,6 @@ uint32_t UsbReportUpdateCounter; void UpdateUsbReports(void) { - usb_status_t status; - if (UsbReportUpdateSemaphore) { return; } @@ -433,31 +431,23 @@ void UpdateUsbReports(void) if (HasUsbBasicKeyboardReportChanged) { UsbReportUpdateSemaphore |= 1 << USB_BASIC_KEYBOARD_INTERFACE_INDEX; - do { - status = UsbBasicKeyboardAction(); - } while (status != kStatus_USB_Success); + UsbBasicKeyboardAction(); } if (HasUsbMediaKeyboardReportChanged) { UsbReportUpdateSemaphore |= 1 << USB_MEDIA_KEYBOARD_INTERFACE_INDEX; - do { - status = UsbMediaKeyboardAction(); - } while (status != kStatus_USB_Success); + UsbMediaKeyboardAction(); } if (HasUsbSystemKeyboardReportChanged) { UsbReportUpdateSemaphore |= 1 << USB_SYSTEM_KEYBOARD_INTERFACE_INDEX; - do { - status = UsbSystemKeyboardAction(); - } while (status != kStatus_USB_Success); + UsbSystemKeyboardAction(); } // Send out the mouse position and wheel values continuously if the report is not zeros, but only send the mouse button states when they change. if (HasUsbMouseReportChanged || ActiveUsbMouseReport->x || ActiveUsbMouseReport->y || ActiveUsbMouseReport->wheelX || ActiveUsbMouseReport->wheelY) { UsbReportUpdateSemaphore |= 1 << USB_MOUSE_INTERFACE_INDEX; - do { - status = UsbMouseAction(); - } while (status != kStatus_USB_Success); + UsbMouseAction(); } }