uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Try to fix chatter by maintaining the strobe between the invocations of KeyMatrix_ScanRow()

Browse Source
This commit is contained in:
László Monda
2019-03-29 09:26:37 +01:00
parent ff14aa8842
commit afb434a4bd
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/agent
+1 -1
Submodule lib/agent updated: f94b221ee9...1eb8720305
shared/key_matrix.c
+5 -5
View File
@@ -24,19 +24,19 @@ void KeyMatrix_ScanRow(key_matrix_t *keyMatrix)
{ {
uint8_t *keyState = keyMatrix->keyStates + keyMatrix->currentRowNum * keyMatrix->colNum; uint8_t *keyState = keyMatrix->keyStates + keyMatrix->currentRowNum * keyMatrix->colNum;
key_matrix_pin_t *row = keyMatrix->rows + keyMatrix->currentRowNum; key_matrix_pin_t *row = keyMatrix->rows + keyMatrix->currentRowNum;
GPIO_Type *rowGpio = row->gpio;
uint32_t rowPin = row->pin;
GPIO_WritePinOutput(rowGpio, rowPin, 1);
key_matrix_pin_t *colEnd = keyMatrix->cols + keyMatrix->colNum; key_matrix_pin_t *colEnd = keyMatrix->cols + keyMatrix->colNum;
for (key_matrix_pin_t *col = keyMatrix->cols; col<colEnd; col++) { for (key_matrix_pin_t *col = keyMatrix->cols; col<colEnd; col++) {
*(keyState++) = GPIO_ReadPinInput(col->gpio, col->pin); *(keyState++) = GPIO_ReadPinInput(col->gpio, col->pin);
} }
GPIO_WritePinOutput(rowGpio, rowPin, 0); GPIO_WritePinOutput(row->gpio, row->pin, 0);
if (++keyMatrix->currentRowNum >= keyMatrix->rowNum) { if (++keyMatrix->currentRowNum >= keyMatrix->rowNum) {
keyMatrix->currentRowNum = 0; keyMatrix->currentRowNum = 0;
} }
// This should come last to maintain the strobe for as long as possible to minimize the chance of chatter.
row = keyMatrix->rows + keyMatrix->currentRowNum;
GPIO_WritePinOutput(row->gpio, row->pin, 1);
} }