uhk/firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Lift out the LED brightness into a global

Browse Source 
Instead of passing the same constant to LedDisplay_SetLayerLed() all the time,
lift it out into a global.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
This commit is contained in:
Gergely Nagy
2016-12-13 23:23:16 +01:00
parent 2a7edbce6f
commit a59dcd1662
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
right/src/keyboard_layout.c
+1 -1
View File
@@ -82,7 +82,7 @@ bool handleKey(uhk_key_t key, int scancodeIdx, usb_keyboard_report_t *report, co
if (key_toggled_off(prevKeyStates, currKeyStates, keyId)) { if (key_toggled_off(prevKeyStates, currKeyStates, keyId)) {
ActiveLayer = LAYER_ID_BASE; ActiveLayer = LAYER_ID_BASE;
} }
LedDisplay_SetLayerLed(ActiveLayer, 0xff); LedDisplay_SetLayerLed(ActiveLayer);
return false; return false;
break; break;
default: default:
right/src/led_display.c
+4 -2
View File
@@ -4,8 +4,10 @@
#define LAYER_LED_FIRST FRAME_REGISTER_PWM_FIRST + 13 #define LAYER_LED_FIRST FRAME_REGISTER_PWM_FIRST + 13
#define LAYER_LED_DISTANCE 16 #define LAYER_LED_DISTANCE 16
void LedDisplay_SetLayerLed(uint8_t layerId, uint8_t brightness) { uint8_t LedDisplayBrightness = 0xff;
void LedDisplay_SetLayerLed(uint8_t layerId) {
for (uint8_t i = 0; i < LAYER_COUNT; i++) { for (uint8_t i = 0; i < LAYER_COUNT; i++) {
LedDriver_WriteRegister(I2C_ADDRESS_LED_DRIVER_LEFT, LAYER_LED_FIRST + (i * LAYER_LED_DISTANCE), brightness * (layerId == i + 1)); LedDriver_WriteRegister(I2C_ADDRESS_LED_DRIVER_LEFT, LAYER_LED_FIRST + (i * LAYER_LED_DISTANCE), LedDisplayBrightness * (layerId == i + 1));
} }
} }
right/src/led_display.h
+3 -1
View File
@@ -3,6 +3,8 @@
#include "led_driver.h" #include "led_driver.h"
void LedDisplay_SetLayerLed(uint8_t layerId, uint8_t brightness); extern uint8_t LedDisplayBrightness;
void LedDisplay_SetLayerLed(uint8_t layerId);
#endif #endif