diff --git a/right/src/usb_interfaces/usb_interface_basic_keyboard.c b/right/src/usb_interfaces/usb_interface_basic_keyboard.c index 49a26ab..65789dd 100644 --- a/right/src/usb_interfaces/usb_interface_basic_keyboard.c +++ b/right/src/usb_interfaces/usb_interface_basic_keyboard.c @@ -4,7 +4,6 @@ static usb_basic_keyboard_report_t usbBasicKeyboardReports[2]; uint32_t UsbBasicKeyboardActionCounter; usb_basic_keyboard_report_t* ActiveUsbBasicKeyboardReport = usbBasicKeyboardReports; -volatile bool IsUsbBasicKeyboardReportSent = false; static uint8_t usbBasicKeyboardInBuffer[USB_BASIC_KEYBOARD_REPORT_LENGTH]; static usb_basic_keyboard_report_t* getInactiveUsbBasicKeyboardReport(void) @@ -24,15 +23,10 @@ void ResetActiveUsbBasicKeyboardReport(void) usb_status_t UsbBasicKeyboardAction(void) { - usb_status_t status = kStatus_USB_Error; - if (!IsUsbBasicKeyboardReportSent) { - status = USB_DeviceHidSend( - UsbCompositeDevice.basicKeyboardHandle, USB_BASIC_KEYBOARD_ENDPOINT_INDEX, - (uint8_t*)getInactiveUsbBasicKeyboardReport(), USB_BASIC_KEYBOARD_REPORT_LENGTH); - IsUsbBasicKeyboardReportSent = true; - UsbBasicKeyboardActionCounter++; - } - return status; + UsbBasicKeyboardActionCounter++; + return USB_DeviceHidSend( + UsbCompositeDevice.basicKeyboardHandle, USB_BASIC_KEYBOARD_ENDPOINT_INDEX, + (uint8_t*)getInactiveUsbBasicKeyboardReport(), USB_BASIC_KEYBOARD_REPORT_LENGTH); } usb_status_t UsbBasicKeyboardCallback(class_handle_t handle, uint32_t event, void *param) diff --git a/right/src/usb_interfaces/usb_interface_basic_keyboard.h b/right/src/usb_interfaces/usb_interface_basic_keyboard.h index 49ea3f0..c72b354 100644 --- a/right/src/usb_interfaces/usb_interface_basic_keyboard.h +++ b/right/src/usb_interfaces/usb_interface_basic_keyboard.h @@ -31,7 +31,6 @@ // Variables: - extern volatile bool IsUsbBasicKeyboardReportSent; extern uint32_t UsbBasicKeyboardActionCounter; extern usb_basic_keyboard_report_t* ActiveUsbBasicKeyboardReport; diff --git a/right/src/usb_interfaces/usb_interface_media_keyboard.c b/right/src/usb_interfaces/usb_interface_media_keyboard.c index cbbfcae..f93317b 100644 --- a/right/src/usb_interfaces/usb_interface_media_keyboard.c +++ b/right/src/usb_interfaces/usb_interface_media_keyboard.c @@ -3,7 +3,6 @@ uint32_t UsbMediaKeyboardActionCounter; static usb_media_keyboard_report_t usbMediaKeyboardReports[2]; usb_media_keyboard_report_t* ActiveUsbMediaKeyboardReport = usbMediaKeyboardReports; -volatile bool IsUsbMediaKeyboardReportSent = false; static usb_media_keyboard_report_t* getInactiveUsbMediaKeyboardReport(void) { @@ -22,15 +21,10 @@ void ResetActiveUsbMediaKeyboardReport(void) usb_status_t UsbMediaKeyboardAction() { - usb_status_t status = kStatus_USB_Error; - if (!IsUsbMediaKeyboardReportSent) { - status = USB_DeviceHidSend( - UsbCompositeDevice.mediaKeyboardHandle, USB_MEDIA_KEYBOARD_ENDPOINT_INDEX, - (uint8_t*)getInactiveUsbMediaKeyboardReport(), USB_MEDIA_KEYBOARD_REPORT_LENGTH); - IsUsbMediaKeyboardReportSent = true; - UsbMediaKeyboardActionCounter++; - } - return status; + UsbMediaKeyboardActionCounter++; + return USB_DeviceHidSend( + UsbCompositeDevice.mediaKeyboardHandle, USB_MEDIA_KEYBOARD_ENDPOINT_INDEX, + (uint8_t*)getInactiveUsbMediaKeyboardReport(), USB_MEDIA_KEYBOARD_REPORT_LENGTH); } usb_status_t UsbMediaKeyboardCallback(class_handle_t handle, uint32_t event, void *param) diff --git a/right/src/usb_interfaces/usb_interface_media_keyboard.h b/right/src/usb_interfaces/usb_interface_media_keyboard.h index 3e633d9..2b51bb6 100644 --- a/right/src/usb_interfaces/usb_interface_media_keyboard.h +++ b/right/src/usb_interfaces/usb_interface_media_keyboard.h @@ -28,7 +28,6 @@ // Variables: - extern volatile bool IsUsbMediaKeyboardReportSent; extern uint32_t UsbMediaKeyboardActionCounter; extern usb_media_keyboard_report_t* ActiveUsbMediaKeyboardReport; diff --git a/right/src/usb_interfaces/usb_interface_mouse.c b/right/src/usb_interfaces/usb_interface_mouse.c index a7e8c07..ab7dea9 100644 --- a/right/src/usb_interfaces/usb_interface_mouse.c +++ b/right/src/usb_interfaces/usb_interface_mouse.c @@ -3,7 +3,6 @@ uint32_t UsbMouseActionCounter; static usb_mouse_report_t usbMouseReports[2]; usb_mouse_report_t* ActiveUsbMouseReport = usbMouseReports; -volatile bool IsUsbMouseReportSent = false; static usb_mouse_report_t* getInactiveUsbMouseReport(void) { @@ -22,15 +21,10 @@ void ResetActiveUsbMouseReport(void) usb_status_t usbMouseAction(void) { - usb_status_t status = kStatus_USB_Error; - if (!IsUsbMouseReportSent) { - status = USB_DeviceHidSend( - UsbCompositeDevice.mouseHandle, USB_MOUSE_ENDPOINT_INDEX, - (uint8_t*)getInactiveUsbMouseReport(), USB_MOUSE_REPORT_LENGTH); - IsUsbMouseReportSent = true; - UsbMouseActionCounter++; - } - return status; + UsbMouseActionCounter++; + return USB_DeviceHidSend( + UsbCompositeDevice.mouseHandle, USB_MOUSE_ENDPOINT_INDEX, + (uint8_t*)getInactiveUsbMouseReport(), USB_MOUSE_REPORT_LENGTH); } usb_status_t UsbMouseCallback(class_handle_t handle, uint32_t event, void *param) diff --git a/right/src/usb_interfaces/usb_interface_mouse.h b/right/src/usb_interfaces/usb_interface_mouse.h index 934c626..86f9eeb 100644 --- a/right/src/usb_interfaces/usb_interface_mouse.h +++ b/right/src/usb_interfaces/usb_interface_mouse.h @@ -31,7 +31,6 @@ // Variables: - extern volatile bool IsUsbMouseReportSent; extern uint32_t UsbMouseActionCounter; extern usb_mouse_report_t* ActiveUsbMouseReport; diff --git a/right/src/usb_interfaces/usb_interface_system_keyboard.c b/right/src/usb_interfaces/usb_interface_system_keyboard.c index 7a72fe3..7eda0e7 100644 --- a/right/src/usb_interfaces/usb_interface_system_keyboard.c +++ b/right/src/usb_interfaces/usb_interface_system_keyboard.c @@ -3,7 +3,6 @@ uint32_t UsbSystemKeyboardActionCounter; static usb_system_keyboard_report_t usbSystemKeyboardReports[2]; usb_system_keyboard_report_t* ActiveUsbSystemKeyboardReport = usbSystemKeyboardReports; -volatile bool IsUsbSystemKeyboardReportSent = false; static usb_system_keyboard_report_t* getInactiveUsbSystemKeyboardReport() { @@ -22,15 +21,10 @@ void ResetActiveUsbSystemKeyboardReport(void) usb_status_t UsbSystemKeyboardAction(void) { - usb_status_t status = kStatus_USB_Error; - if (!IsUsbSystemKeyboardReportSent) { - status = USB_DeviceHidSend( - UsbCompositeDevice.systemKeyboardHandle, USB_SYSTEM_KEYBOARD_ENDPOINT_INDEX, - (uint8_t*)getInactiveUsbSystemKeyboardReport(), USB_SYSTEM_KEYBOARD_REPORT_LENGTH); - IsUsbSystemKeyboardReportSent = true; - UsbSystemKeyboardActionCounter++; - } - return status; + UsbSystemKeyboardActionCounter++; + return USB_DeviceHidSend( + UsbCompositeDevice.systemKeyboardHandle, USB_SYSTEM_KEYBOARD_ENDPOINT_INDEX, + (uint8_t*)getInactiveUsbSystemKeyboardReport(), USB_SYSTEM_KEYBOARD_REPORT_LENGTH); } usb_status_t UsbSystemKeyboardCallback(class_handle_t handle, uint32_t event, void *param) diff --git a/right/src/usb_interfaces/usb_interface_system_keyboard.h b/right/src/usb_interfaces/usb_interface_system_keyboard.h index 43c0279..1e0ff6b 100644 --- a/right/src/usb_interfaces/usb_interface_system_keyboard.h +++ b/right/src/usb_interfaces/usb_interface_system_keyboard.h @@ -29,7 +29,6 @@ // Variables: - extern volatile bool IsUsbSystemKeyboardReportSent; extern uint32_t UsbSystemKeyboardActionCounter; extern usb_system_keyboard_report_t* ActiveUsbSystemKeyboardReport; diff --git a/right/src/usb_report_updater.c b/right/src/usb_report_updater.c index d45c7a5..6c450dc 100644 --- a/right/src/usb_report_updater.c +++ b/right/src/usb_report_updater.c @@ -389,8 +389,6 @@ void UpdateUsbReports(void) return; } Timer_SetCurrentTime(&lastMouseUpdateTime); - } else if (!IsUsbBasicKeyboardReportSent || !IsUsbMediaKeyboardReportSent || !IsUsbSystemKeyboardReportSent || !IsUsbMouseReportSent) { - return; } ResetActiveUsbBasicKeyboardReport(); @@ -401,38 +399,42 @@ void UpdateUsbReports(void) updateActiveUsbReports(); static usb_basic_keyboard_report_t last_basic_report = { .scancodes[0] = 0xFF }; + bool HasUsbBasicKeyboardReportChanged = false; if (memcmp(ActiveUsbBasicKeyboardReport, &last_basic_report, sizeof(usb_basic_keyboard_report_t)) != 0) { last_basic_report = *ActiveUsbBasicKeyboardReport; SwitchActiveUsbBasicKeyboardReport(); - IsUsbBasicKeyboardReportSent = false; + HasUsbBasicKeyboardReportChanged = true; UsbBasicKeyboardAction(); } static usb_media_keyboard_report_t last_media_report = { .scancodes[0] = 0xFF }; + bool HasUsbMediaKeyboardReportChanged = false; if (memcmp(ActiveUsbMediaKeyboardReport, &last_media_report, sizeof(usb_media_keyboard_report_t)) != 0) { last_media_report = *ActiveUsbMediaKeyboardReport; + HasUsbMediaKeyboardReportChanged = true; SwitchActiveUsbMediaKeyboardReport(); - IsUsbMediaKeyboardReportSent = false; UsbMediaKeyboardAction(); } static usb_system_keyboard_report_t last_system_report = { .scancodes[0] = 0xFF }; + bool HasUsbSystemKeyboardReportChanged = false; if (memcmp(ActiveUsbSystemKeyboardReport, &last_system_report, sizeof(usb_system_keyboard_report_t)) != 0) { last_system_report = *ActiveUsbSystemKeyboardReport; + HasUsbSystemKeyboardReportChanged = true; SwitchActiveUsbSystemKeyboardReport(); - IsUsbSystemKeyboardReportSent = false; UsbSystemKeyboardAction(); } static usb_mouse_report_t last_mouse_report = { .buttons = 0xFF }; + bool HasUsbMouseReportChanged = false; if (memcmp(ActiveUsbMouseReport, &last_mouse_report, sizeof(usb_mouse_report_t)) != 0) { last_mouse_report = *ActiveUsbMouseReport; + HasUsbMouseReportChanged = true; SwitchActiveUsbMouseReport(); - IsUsbMouseReportSent = false; usbMouseAction(); } - if ((previousLayer != LayerId_Base || !IsUsbBasicKeyboardReportSent || !IsUsbMediaKeyboardReportSent || !IsUsbSystemKeyboardReportSent || !IsUsbMouseReportSent) && IsHostSleeping) { + if ((previousLayer != LayerId_Base || HasUsbBasicKeyboardReportChanged || HasUsbMediaKeyboardReportChanged || HasUsbSystemKeyboardReportChanged || HasUsbMouseReportChanged) && IsHostSleeping) { WakeUpHost(true); // Wake up the host if any key is pressed and the computer is sleeping. } }