uhk/agent
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf: Cache SvgModules

Browse Source 
It will prevent them to be parsed multiple times.
This commit is contained in:
J??zsef Farkas
2017-06-17 14:28:15 +02:00
committed by József Farkas
parent 10f44f974a
commit ecd495b7c2
5 changed files with 47 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
shared/src/components/svg/keyboard/svg-keyboard.component.ts
View File

@@ -2,11 +2,7 @@ import { Component, EventEmitter, Input, OnInit, Output, ChangeDetectionStrategy
import { Module } from '../../../config-serializer/config-items/Module';
import { SvgModule } from '../module';
enum KeyboardLayout {
ANSI,
ISO
}
import { SvgModuleProviderService } from '../../../services/svg-module-provider.service';
@Component({
selector: 'svg-keyboard',
@@ -27,13 +23,13 @@ export class SvgKeyboardComponent implements OnInit {
modules: SvgModule[];
viewBox: string;
constructor() {
constructor(private svgModuleProvider: SvgModuleProviderService) {
this.modules = [];
this.viewBox = '-520 582 1100 470';
}
ngOnInit() {
this.modules = this.getSvgModules();
this.modules = this.svgModuleProvider.getSvgModules();
}
onKeyClick(moduleId: number, keyId: number, keyTarget: HTMLElement): void {
@@ -61,21 +57,4 @@ export class SvgKeyboardComponent implements OnInit {
});
}
private getSvgModules(): SvgModule[] {
const leftModule = new SvgModule(this.getLeftModule());
const rightModule = new SvgModule(this.getRightModule());
return [rightModule, leftModule];
}
private getLeftModule(layout = KeyboardLayout.ANSI): any {
if (layout === KeyboardLayout.ISO) {
return require('xml-loader!../../../../../modules/uhk60-left-half/layout-iso.svg').svg;
}
return require('xml-loader!../../../../../modules/uhk60-left-half/layout-ansi.svg').svg;
}
private getRightModule(): any {
return require('xml-loader!../../../../../modules/uhk60-right-half/layout.svg').svg;
}
}