From eac588c42c0a3b8de5a36729377af01ec594a0cb Mon Sep 17 00:00:00 2001 From: Mikko Lakomaa Date: Tue, 25 Jul 2017 21:59:00 +0300 Subject: [PATCH] Fix key capture on Firefox (#373) * Add tabindex attribute to svg-keyboard-key to allow focusing the key in Firefox * Fix typo in svg-keyboard-key.component onKeyUp method --- .../svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts | 2 +- shared/src/components/svg/module/svg-module.component.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/shared/src/components/svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts b/shared/src/components/svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts index b1abfdeb..b0c34704 100644 --- a/shared/src/components/svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts +++ b/shared/src/components/svg/keys/svg-keyboard-key/svg-keyboard-key.component.ts @@ -118,7 +118,7 @@ export class SvgKeyboardKeyComponent implements OnInit, OnChanges, OnDestroy { } @HostListener('keyup', ['$event']) - onKeyUpe(e: KeyboardEvent) { + onKeyUp(e: KeyboardEvent) { if (this.scanCodePressed) { e.preventDefault(); this.scanCodePressed = false; diff --git a/shared/src/components/svg/module/svg-module.component.html b/shared/src/components/svg/module/svg-module.component.html index 0bb2efa2..976d8430 100644 --- a/shared/src/components/svg/module/svg-module.component.html +++ b/shared/src/components/svg/module/svg-module.component.html @@ -7,6 +7,7 @@ [width]="key.width" [height]="key.height" [attr.transform]="'translate(' + key.x + ' ' + key.y + ')'" [attr.fill]="key.fill" + [attr.tabindex]="0" [keyAction]="keyActions[i]" [active]="selected && i == selectedKey.keyId" [keybindAnimationEnabled]="keybindAnimationEnabled"