auto write userconfig

This commit is contained in:
Róbert Kiss
2017-12-14 21:59:44 +01:00
parent 3e7a0ed81a
commit d57ba81d10
9 changed files with 49 additions and 29 deletions

View File

@@ -10,7 +10,7 @@ import * as url from 'url';
import * as commandLineArgs from 'command-line-args'; import * as commandLineArgs from 'command-line-args';
import { UhkHidDevice, UhkOperations } from 'uhk-usb'; import { UhkHidDevice, UhkOperations } from 'uhk-usb';
// import { ElectronDataStorageRepositoryService } from './services/electron-datastorage-repository.service'; // import { ElectronDataStorageRepositoryService } from './services/electron-datastorage-repository.service';
import { CommandLineArgs, LogRegExps } from 'uhk-common'; import { LogRegExps } from 'uhk-common';
import { DeviceService } from './services/device.service'; import { DeviceService } from './services/device.service';
import { logger } from './services/logger.service'; import { logger } from './services/logger.service';
import { AppUpdateService } from './services/app-update.service'; import { AppUpdateService } from './services/app-update.service';
@@ -18,12 +18,14 @@ import { AppService } from './services/app.service';
import { SudoService } from './services/sudo.service'; import { SudoService } from './services/sudo.service';
import { UhkBlhost } from '../../uhk-usb/src'; import { UhkBlhost } from '../../uhk-usb/src';
import * as isDev from 'electron-is-dev'; import * as isDev from 'electron-is-dev';
import { CommandLineInputs } from './models/command-line-inputs';
const optionDefinitions = [ const optionDefinitions = [
{name: 'addons', type: Boolean, defaultOption: false} {name: 'addons', type: Boolean},
{name: 'auto-write-config', type: Boolean}
]; ];
const options: CommandLineArgs = commandLineArgs(optionDefinitions); const options: CommandLineInputs = commandLineArgs(optionDefinitions);
// import './dev-extension'; // import './dev-extension';
// require('electron-debug')({ showDevTools: true, enabled: true }); // require('electron-debug')({ showDevTools: true, enabled: true });

View File

@@ -0,0 +1,4 @@
export interface CommandLineInputs {
addons?: boolean;
'auto-write-config'?: boolean;
}

View File

@@ -6,12 +6,13 @@ import { join } from 'path';
import { AppStartInfo, CommandLineArgs, IpcEvents, LogService } from 'uhk-common'; import { AppStartInfo, CommandLineArgs, IpcEvents, LogService } from 'uhk-common';
import { MainServiceBase } from './main-service-base'; import { MainServiceBase } from './main-service-base';
import { DeviceService } from './device.service'; import { DeviceService } from './device.service';
import { CommandLineInputs } from '../models/command-line-inputs';
export class AppService extends MainServiceBase { export class AppService extends MainServiceBase {
constructor(protected logService: LogService, constructor(protected logService: LogService,
protected win: Electron.BrowserWindow, protected win: Electron.BrowserWindow,
private deviceService: DeviceService, private deviceService: DeviceService,
private options: CommandLineArgs, private options: CommandLineInputs,
private uhkHidDeviceService: UhkHidDevice) { private uhkHidDeviceService: UhkHidDevice) {
super(logService, win); super(logService, win);
@@ -25,7 +26,10 @@ export class AppService extends MainServiceBase {
const packageJson = await this.getPackageJson(); const packageJson = await this.getPackageJson();
const response: AppStartInfo = { const response: AppStartInfo = {
commandLineArgs: this.options, commandLineArgs: {
addons: this.options.addons || false,
autoWriteConfig: this.options['auto-write-config'] || false
},
deviceConnected: this.deviceService.isConnected, deviceConnected: this.deviceService.isConnected,
hasPermission: this.uhkHidDeviceService.hasPermission(), hasPermission: this.uhkHidDeviceService.hasPermission(),
agentVersionInfo: { agentVersionInfo: {

View File

@@ -1,3 +1,4 @@
export interface CommandLineArgs { export interface CommandLineArgs {
addons: boolean; addons: boolean;
autoWriteConfig: boolean;
} }

View File

@@ -1,6 +1,6 @@
import { Action } from '@ngrx/store'; import { Action } from '@ngrx/store';
import { AppStartInfo, HardwareConfiguration, Notification, type, VersionInformation } from 'uhk-common'; import { AppStartInfo, CommandLineArgs, HardwareConfiguration, Notification, type, VersionInformation } from 'uhk-common';
import { ElectronLogEntry } from '../../models/xterm-log'; import { ElectronLogEntry } from '../../models/xterm-log';
const PREFIX = '[app] '; const PREFIX = '[app] ';
@@ -10,7 +10,7 @@ export const ActionTypes = {
APP_BOOTSRAPPED: type(PREFIX + 'bootstrapped'), APP_BOOTSRAPPED: type(PREFIX + 'bootstrapped'),
APP_STARTED: type(PREFIX + 'started'), APP_STARTED: type(PREFIX + 'started'),
APP_SHOW_NOTIFICATION: type(PREFIX + 'show notification'), APP_SHOW_NOTIFICATION: type(PREFIX + 'show notification'),
APP_TOGGLE_ADDON_MENU: type(PREFIX + 'toggle add-on menu'), APPLY_COMMAND_LINE_ARGS: type(PREFIX + 'apply command line args'),
APP_PROCESS_START_INFO: type(PREFIX + 'process start info'), APP_PROCESS_START_INFO: type(PREFIX + 'process start info'),
UNDO_LAST: type(PREFIX + 'undo last action'), UNDO_LAST: type(PREFIX + 'undo last action'),
UNDO_LAST_SUCCESS: type(PREFIX + 'undo last action success'), UNDO_LAST_SUCCESS: type(PREFIX + 'undo last action success'),
@@ -34,10 +34,10 @@ export class ShowNotificationAction implements Action {
constructor(public payload: Notification) { } constructor(public payload: Notification) { }
} }
export class ToggleAddonMenuAction implements Action { export class ApplyCommandLineArgsAction implements Action {
type = ActionTypes.APP_TOGGLE_ADDON_MENU; type = ActionTypes.APPLY_COMMAND_LINE_ARGS;
constructor(public payload: boolean) { } constructor(public payload: CommandLineArgs) { }
} }
export class ProcessAppStartInfoAction implements Action { export class ProcessAppStartInfoAction implements Action {
@@ -82,7 +82,7 @@ export type Actions
= AppStartedAction = AppStartedAction
| AppBootsrappedAction | AppBootsrappedAction
| ShowNotificationAction | ShowNotificationAction
| ToggleAddonMenuAction | ApplyCommandLineArgsAction
| ProcessAppStartInfoAction | ProcessAppStartInfoAction
| UndoLastAction | UndoLastAction
| UndoLastSuccessAction | UndoLastSuccessAction

View File

@@ -17,7 +17,7 @@ import {
DismissUndoNotificationAction, DismissUndoNotificationAction,
ProcessAppStartInfoAction, ProcessAppStartInfoAction,
ShowNotificationAction, ShowNotificationAction,
ToggleAddonMenuAction, ApplyCommandLineArgsAction,
UndoLastAction, UpdateAgentVersionInformationAction UndoLastAction, UpdateAgentVersionInformationAction
} from '../actions/app'; } from '../actions/app';
import { AppRendererService } from '../../services/app-renderer.service'; import { AppRendererService } from '../../services/app-renderer.service';
@@ -56,7 +56,7 @@ export class ApplicationEffects {
.mergeMap((appInfo: AppStartInfo) => { .mergeMap((appInfo: AppStartInfo) => {
this.logService.debug('[AppEffect][processStartInfo] payload:', appInfo); this.logService.debug('[AppEffect][processStartInfo] payload:', appInfo);
return [ return [
new ToggleAddonMenuAction(appInfo.commandLineArgs.addons), new ApplyCommandLineArgsAction(appInfo.commandLineArgs),
new ConnectionStateChangedAction(appInfo.deviceConnected), new ConnectionStateChangedAction(appInfo.deviceConnected),
new PermissionStateChangedAction(appInfo.hasPermission), new PermissionStateChangedAction(appInfo.hasPermission),
new UpdateAgentVersionInformationAction(appInfo.agentVersionInfo) new UpdateAgentVersionInformationAction(appInfo.agentVersionInfo)

View File

@@ -12,35 +12,27 @@ import 'rxjs/add/operator/startWith';
import 'rxjs/add/operator/withLatestFrom'; import 'rxjs/add/operator/withLatestFrom';
import 'rxjs/add/operator/mergeMap'; import 'rxjs/add/operator/mergeMap';
import 'rxjs/add/observable/of'; import 'rxjs/add/observable/of';
import 'rxjs/add/observable/empty';
import { import {
ConfigurationReply, ConfigurationReply, HardwareConfiguration, LogService, NotificationType, UhkBuffer,
HardwareConfiguration,
LogService,
NotificationType,
UhkBuffer,
UserConfiguration UserConfiguration
} from 'uhk-common'; } from 'uhk-common';
import { import {
ActionTypes, ActionTypes, LoadConfigFromDeviceReplyAction, LoadUserConfigSuccessAction, RenameUserConfigurationAction,
LoadConfigFromDeviceReplyAction,
LoadUserConfigSuccessAction,
RenameUserConfigurationAction,
SaveUserConfigSuccessAction SaveUserConfigSuccessAction
} from '../actions/user-config'; } from '../actions/user-config';
import { DataStorageRepositoryService } from '../../services/datastorage-repository.service'; import { DataStorageRepositoryService } from '../../services/datastorage-repository.service';
import { DefaultUserConfigurationService } from '../../services/default-user-configuration.service'; import { DefaultUserConfigurationService } from '../../services/default-user-configuration.service';
import { AppState, getPrevUserConfiguration, getUserConfiguration } from '../index'; import { AppState, autoWriteUserConfiguration, getPrevUserConfiguration, getUserConfiguration } from '../index';
import { KeymapAction, KeymapActions, MacroAction, MacroActions } from '../actions'; import { KeymapAction, KeymapActions, MacroAction, MacroActions } from '../actions';
import { import {
DismissUndoNotificationAction, DismissUndoNotificationAction, LoadHardwareConfigurationSuccessAction, ShowNotificationAction,
LoadHardwareConfigurationSuccessAction,
ShowNotificationAction,
UndoLastAction UndoLastAction
} from '../actions/app'; } from '../actions/app';
import { ShowSaveToKeyboardButtonAction } from '../actions/device'; import { SaveConfigurationAction, ShowSaveToKeyboardButtonAction } from '../actions/device';
import { DeviceRendererService } from '../../services/device-renderer.service'; import { DeviceRendererService } from '../../services/device-renderer.service';
import { UndoUserConfigData } from '../../models/undo-user-config-data'; import { UndoUserConfigData } from '../../models/undo-user-config-data';
@@ -193,6 +185,18 @@ export class UserConfigEffects {
saveAs(blob, 'UserConfiguration.bin'); saveAs(blob, 'UserConfiguration.bin');
}); });
@Effect() loadUserConfigurationSuccess$ = this.actions$
.ofType(ActionTypes.SAVE_USER_CONFIG_SUCCESS)
.withLatestFrom(this.store.select(autoWriteUserConfiguration))
.switchMap(([action, autoWriteUserConfig]) => {
if (autoWriteUserConfig) {
return Observable.of(new SaveConfigurationAction());
}
else {
return Observable.empty();
}
});
constructor(private actions$: Actions, constructor(private actions$: Actions,
private dataStorageRepository: DataStorageRepositoryService, private dataStorageRepository: DataStorageRepositoryService,
private store: Store<AppState>, private store: Store<AppState>,

View File

@@ -43,6 +43,7 @@ export const getDeviceName = (state: AppState) => state.userConfiguration.device
export const appState = (state: AppState) => state.app; export const appState = (state: AppState) => state.app;
export const showAddonMenu = createSelector(appState, fromApp.showAddonMenu); export const showAddonMenu = createSelector(appState, fromApp.showAddonMenu);
export const autoWriteUserConfiguration = createSelector(appState, fromApp.autoWriteUserConfiguration);
export const getUndoableNotification = createSelector(appState, fromApp.getUndoableNotification); export const getUndoableNotification = createSelector(appState, fromApp.getUndoableNotification);
export const getPrevUserConfiguration = createSelector(appState, fromApp.getPrevUserConfiguration); export const getPrevUserConfiguration = createSelector(appState, fromApp.getPrevUserConfiguration);
export const runningInElectron = createSelector(appState, fromApp.runningInElectron); export const runningInElectron = createSelector(appState, fromApp.runningInElectron);

View File

@@ -11,6 +11,7 @@ import { KeyboardLayout } from '../../keyboard/keyboard-layout.enum';
export interface State { export interface State {
started: boolean; started: boolean;
showAddonMenu: boolean; showAddonMenu: boolean;
autoWriteUserConfiguration: boolean;
undoableNotification?: Notification; undoableNotification?: Notification;
navigationCountAfterNotification: number; navigationCountAfterNotification: number;
prevUserConfig?: UserConfiguration; prevUserConfig?: UserConfiguration;
@@ -23,6 +24,7 @@ export interface State {
export const initialState: State = { export const initialState: State = {
started: false, started: false,
showAddonMenu: false, showAddonMenu: false,
autoWriteUserConfiguration: false,
navigationCountAfterNotification: 0, navigationCountAfterNotification: 0,
runningInElectron: runInElectron(), runningInElectron: runInElectron(),
configLoading: true configLoading: true
@@ -37,10 +39,11 @@ export function reducer(state = initialState, action: Action & { payload: any })
}; };
} }
case ActionTypes.APP_TOGGLE_ADDON_MENU: { case ActionTypes.APPLY_COMMAND_LINE_ARGS: {
return { return {
...state, ...state,
showAddonMenu: action.payload showAddonMenu: action.payload.addons,
autoWriteUserConfiguration: action.payload.autoWriteConfig
}; };
} }
@@ -124,6 +127,7 @@ export function reducer(state = initialState, action: Action & { payload: any })
} }
export const showAddonMenu = (state: State) => state.showAddonMenu; export const showAddonMenu = (state: State) => state.showAddonMenu;
export const autoWriteUserConfiguration = (state: State) => state.autoWriteUserConfiguration;
export const getUndoableNotification = (state: State) => state.undoableNotification; export const getUndoableNotification = (state: State) => state.undoableNotification;
export const getPrevUserConfiguration = (state: State) => state.prevUserConfig; export const getPrevUserConfiguration = (state: State) => state.prevUserConfig;
export const runningInElectron = (state: State) => state.runningInElectron; export const runningInElectron = (state: State) => state.runningInElectron;