From 9089f088b63a31cdb1e99d24c7fc5238e54b9230 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A1szl=C3=B3=20Monda?= Date: Mon, 15 Jan 2018 00:31:24 +0100 Subject: [PATCH] Clean up get-left-firmware-version.js a bit. --- packages/usb/get-left-firmware-version.js | 4 ++-- packages/usb/get-right-firmware-version.js | 13 ++++++------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/packages/usb/get-left-firmware-version.js b/packages/usb/get-left-firmware-version.js index 50e5e89d..82eacb1f 100755 --- a/packages/usb/get-left-firmware-version.js +++ b/packages/usb/get-left-firmware-version.js @@ -3,10 +3,10 @@ const uhk = require('./uhk'); const device = uhk.getUhkDevice(); const sendData = new Buffer([uhk.usbCommands.getModuleProperty, uhk.moduleSlotToId.leftHalf, uhk.modulePropertyIds.protocolVersions]); -console.log(sendData) +//console.log(sendData) device.write(uhk.getTransferData(sendData)); const response = Buffer.from(device.readSync()); -console.log(response) +//console.log(response) const moduleProtocolMajorVersion = uhk.getUint16(response, 2); const moduleProtocolMinorVersion = uhk.getUint16(response, 4); const moduleProtocolPatchVersion = uhk.getUint16(response, 6); diff --git a/packages/usb/get-right-firmware-version.js b/packages/usb/get-right-firmware-version.js index 1d4adb6c..24fa8ff0 100755 --- a/packages/usb/get-right-firmware-version.js +++ b/packages/usb/get-right-firmware-version.js @@ -3,13 +3,12 @@ const uhk = require('./uhk'); const device = uhk.getUhkDevice(); const sendData = new Buffer([uhk.usbCommands.getDeviceProperty, uhk.devicePropertyIds.protocolVersions]); +//console.log(sendData) device.write(uhk.getTransferData(sendData)); const response = Buffer.from(device.readSync()); +//console.log(response) +const firmwareMajorVersion = uhk.getUint16(response, 1); +const firmwareMinorVersion = uhk.getUint16(response, 3); +const firmwarePatchVersion = uhk.getUint16(response, 5); -const firmwareMajorVersion = response[1] + (response[2]<<8); -const firmwareMinorVersion = response[3] + (response[4]<<8); -const firmwarePatchVersion = response[5] + (response[6]<<8); - -console.log(`firmwareMajorVersion: ${firmwareMajorVersion}`); -console.log(`firmwareMinorVersion: ${firmwareMinorVersion}`); -console.log(`firmwarePatchVersion: ${firmwarePatchVersion}`); +console.log(`firmwareVersion: ${firmwareMajorVersion}.${firmwareMinorVersion}.${firmwarePatchVersion}`);