From 8bb9f7f83982745bd048e7becebffa50a7f9b488 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=B3bert=20Kiss?= Date: Fri, 22 Dec 2017 19:50:31 +0100 Subject: [PATCH] fix(updater): handle undefined error when updater not provide error content (#524) * fix(updater): check updater error is exists or not * set default error message --- packages/uhk-agent/src/services/app-update.service.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/uhk-agent/src/services/app-update.service.ts b/packages/uhk-agent/src/services/app-update.service.ts index ec7fd49d..58391056 100644 --- a/packages/uhk-agent/src/services/app-update.service.ts +++ b/packages/uhk-agent/src/services/app-update.service.ts @@ -37,8 +37,13 @@ export class AppUpdateService extends MainServiceBase { }); autoUpdater.on('error', (ev: any, err: string) => { - console.error('[AppUpdateService] error', err); - this.sendIpcToWindow(IpcEvents.autoUpdater.autoUpdateError, err.substr(0, 100)); + this.logService.error('[AppUpdateService] error', err) + let msg = 'Electron updater error'; + if (err) { + msg = err.substr(0, 100); + } + + this.sendIpcToWindow(IpcEvents.autoUpdater.autoUpdateError, msg); }); autoUpdater.on('download-progress', (progressObj: ProgressInfo) => {