fix for middle clicking links (#937)

* fix for middle clicking links

* Found another link in the app

* Converted all links to use externaUrl decorator

* Missing semicolon

* Minor fixes for compilation/linting

* Changed help link back to embedded in html

* trigger builds

* trigger build for agreement removal

packages/uhk-web/src/app/components/device/firmware/device-firmware.component.ts

@@ -3,7 +3,6 @@ import { Store } from '@ngrx/store';
 import { Observable, Subscription } from 'rxjs';
 import { Constants, HardwareModules, VersionInformation } from 'uhk-common';
 
-import { OpenUrlInNewWindowAction } from '../../../store/actions/app';
 import {
     AppState,
     firmwareUpgradeAllowed,
@@ -37,6 +36,7 @@ export class DeviceFirmwareComponent implements OnDestroy {
     firmwareUpgradeAllowed$: Observable<boolean>;
     firmwareUpgradeFailed$: Observable<boolean>;
     firmwareUpgradeSuccess$: Observable<boolean>;
+    firmwareGithubIssueUrl: string;
 
     constructor(private store: Store<AppState>) {
         this.flashFirmwareButtonDisbabled$ = store.select(flashFirmwareButtonDisbabled);
@@ -49,6 +49,7 @@ export class DeviceFirmwareComponent implements OnDestroy {
         this.firmwareUpgradeAllowed$ = store.select(firmwareUpgradeAllowed);
         this.firmwareUpgradeFailed$ = store.select(firmwareUpgradeFailed);
         this.firmwareUpgradeSuccess$ = store.select(firmwareUpgradeSuccess);
+        this.firmwareGithubIssueUrl = Constants.FIRMWARE_GITHUB_ISSUE_URL;
     }
 
     ngOnDestroy(): void {
@@ -62,9 +63,4 @@ export class DeviceFirmwareComponent implements OnDestroy {
     changeFile(data: UploadFileData): void {
         this.store.dispatch(new UpdateFirmwareWithAction(data.data));
     }
-
-    openFirmwareGitHubIssuePage(event): void {
-        event.preventDefault();
-        this.store.dispatch(new OpenUrlInNewWindowAction(Constants.FIRMWARE_GITHUB_ISSUE_URL));
-    }
 }