Use the 'handler' prefix

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>

HISTORY.rst

@@ -161,6 +161,7 @@
 * Backport search improvements.
 * Remove search elapsed time calculation.
 * Remove SEARCH_LIMIT setting.
+* Use the 'handler' prefix for all the signal handler functions.
 
 3.1.11 (2019-04-XX)
 ===================

docs/releases/3.2.rst

@@ -193,6 +193,7 @@ Other changes
 * Backport search improvements.
 * Remove search elapsed time calculation.
 * Remove SEARCH_LIMIT setting.
+* Use the 'handler' prefix for all the signal handler functions.
 
 Removals
 --------

mayan/apps/document_states/apps.py

@@ -22,7 +22,7 @@ from mayan.celery import app
 
 from .classes import DocumentStateHelper, WorkflowAction
 from .handlers import (
-    handler_index_document, handler_trigger_transition, launch_workflow
+    handler_index_document, handler_launch_workflow, handler_trigger_transition
 )
 from .links import (
     link_document_workflow_instance_list, link_setup_workflow_document_types,
@@ -352,18 +352,20 @@ class DocumentStatesApp(MayanAppConfig):
         menu_tools.bind_links(links=(link_tool_launch_all_workflows,))
 
         post_save.connect(
-            launch_workflow, dispatch_uid='launch_workflow', sender=Document
+            dispatch_uid='workflows_handler_launch_workflow',
+            receiver=handler_launch_workflow,
+            sender=Document
         )
 
         # Index updating
 
         post_save.connect(
-            handler_index_document,
+            dispatch_uid='workflows_handler_index_document_save',
-            dispatch_uid='handler_index_document_save',
+            receiver=handler_index_document,
             sender=WorkflowInstanceLogEntry
         )
         post_save.connect(
-            handler_trigger_transition,
+            dispatch_uid='workflows_handler_trigger_transition',
-            dispatch_uid='document_states_handler_trigger_transition',
+            receiver=handler_trigger_transition,
             sender=Action
         )

mayan/apps/document_states/handlers.py

@@ -15,6 +15,15 @@ def handler_index_document(sender, **kwargs):
     )
 
 
+def handler_launch_workflow(sender, instance, created, **kwargs):
+    Workflow = apps.get_model(
+        app_label='document_states', model_name='Workflow'
+    )
+
+    if created:
+        Workflow.objects.launch_for(instance)
+
+
 def handler_trigger_transition(sender, **kwargs):
     action = kwargs['instance']
 
@@ -45,12 +54,3 @@ def handler_trigger_transition(sender, **kwargs):
                 comment=_('Event trigger: %s') % EventType.get(name=action.verb).label,
                 transition=valid_transitions[0]
             )
-
-
-def launch_workflow(sender, instance, created, **kwargs):
-    Workflow = apps.get_model(
-        app_label='document_states', model_name='Workflow'
-    )
-
-    if created:
-        Workflow.objects.launch_for(instance)

mayan/apps/permissions/apps.py

@@ -15,7 +15,7 @@ from mayan.apps.common.signals import perform_upgrade
 from mayan.apps.events import ModelEventType
 
 from .events import event_role_created, event_role_edited
-from .handlers import purge_permissions
+from .handlers import handler_purge_permissions
 from .links import (
     link_group_roles, link_role_create, link_role_delete, link_role_edit,
     link_role_groups, link_role_list, link_role_permissions
@@ -77,7 +77,8 @@ class PermissionsApp(MayanAppConfig):
         menu_setup.bind_links(links=(link_role_list,))
 
         perform_upgrade.connect(
-            purge_permissions, dispatch_uid='purge_permissions'
+            dispatch_uid='permissions_handler_purge_permissions',
+            receiver=handler_purge_permissions
         )
 
         registry.register(Role)

mayan/apps/permissions/handlers.py

@@ -3,5 +3,5 @@ from __future__ import unicode_literals
 from django.core import management
 
 
-def purge_permissions(**kwargs):
+def handler_purge_permissions(**kwargs):
-    management.call_command('purgepermissions')
+    management.call_command(command_name='purgepermissions')