From f3d1faebf16b42a2b5f23176339aba3ef5346784 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Wed, 10 Feb 2016 02:27:42 -0400 Subject: [PATCH] Move metadata form value validation to .clean() and update field data may not be available yet when validatng the value field. Only validate form value if form has a metadata type associated. --- mayan/apps/metadata/forms.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/mayan/apps/metadata/forms.py b/mayan/apps/metadata/forms.py index e6efe25132..30660c5246 100644 --- a/mayan/apps/metadata/forms.py +++ b/mayan/apps/metadata/forms.py @@ -79,12 +79,15 @@ class MetadataForm(forms.Form): attrs={'readonly': 'readonly'} ) - def clean_value(self): - if self.cleaned_data.get('update'): - return self.metadata_type.validate_value( - document_type=self.document_type, value=self.cleaned_data['value'] + def clean(self): + if self.cleaned_data.get('update') and hasattr(self, 'metadata_type'): + self.cleaned_data['value'] = self.metadata_type.validate_value( + document_type=self.document_type, + value=self.cleaned_data.get('value') ) + return self.cleaned_data + MetadataFormSet = formset_factory(MetadataForm, extra=0)