From e09bd48d655ac87aae112d6606d982ce7682e924 Mon Sep 17 00:00:00 2001 From: Jesaja Everling Date: Thu, 20 Jun 2019 03:51:31 +0000 Subject: [PATCH] Fix kwargs for poplib.POP3_SSL and poplib.POP3 --- mayan/apps/sources/models/email_sources.py | 4 ++-- mayan/apps/sources/tests/test_models.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mayan/apps/sources/models/email_sources.py b/mayan/apps/sources/models/email_sources.py index 7b9f8b67d5..a681c7f721 100644 --- a/mayan/apps/sources/models/email_sources.py +++ b/mayan/apps/sources/models/email_sources.py @@ -277,10 +277,10 @@ class POP3Email(EmailBaseModel): logger.debug('ssl: %s', self.ssl) if self.ssl: - mailbox = poplib.POP3_SSL(host=self.host, post=self.port) + mailbox = poplib.POP3_SSL(host=self.host, port=self.port) else: mailbox = poplib.POP3( - host=self.host, post=self.port, timeout=self.timeout + host=self.host, port=self.port, timeout=self.timeout ) mailbox.getwelcome() diff --git a/mayan/apps/sources/tests/test_models.py b/mayan/apps/sources/tests/test_models.py index dfea4f640b..16a6282118 100644 --- a/mayan/apps/sources/tests/test_models.py +++ b/mayan/apps/sources/tests/test_models.py @@ -217,7 +217,7 @@ class POP3SourceTestCase(GenericDocumentTestCase): def user(self, username): return - @mock.patch('poplib.POP3_SSL') + @mock.patch('poplib.POP3_SSL', autospec=True) def test_download_document(self, mock_poplib): mock_poplib.return_value = POP3SourceTestCase.MockMailbox() self.source = POP3Email.objects.create(