Add keyword arguments to reverse

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-05-07 01:57:33 -04:00
parent e1e2454e2a
commit ddbb0d496a
3 changed files with 29 additions and 13 deletions

View File

@@ -383,7 +383,9 @@ class WorkflowInstance(models.Model):
def get_absolute_url(self): def get_absolute_url(self):
return reverse( return reverse(
'document_states:workflow_instance_detail', args=(str(self.pk),) viewname='document_states:workflow_instance_detail', kwargs={
'pk': self.pk
}
) )
def get_context(self): def get_context(self):

View File

@@ -18,7 +18,11 @@ def widget_transition_events(transition):
def widget_workflow_diagram(workflow): def widget_workflow_diagram(workflow):
return mark_safe( return mark_safe(
'<img class="img-responsive" src="{}" style="margin:auto;">'.format( '<img class="img-responsive" src="{}" style="margin:auto;">'.format(
reverse('document_states:workflow_image', args=(workflow.pk,)) reverse(
viewname='document_states:workflow_image', kwargs={
'pk': workflow.pk
}
)
) )
) )

View File

@@ -23,7 +23,9 @@ class OCRAPITestCase(DocumentTestMixin, BaseAPITestCase):
response = self._request_document_ocr_submit_view() response = self._request_document_ocr_submit_view()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertFalse(hasattr(self.test_document.pages.first(), 'ocr_content')) self.assertFalse(
hasattr(self.test_document.pages.first(), 'ocr_content')
)
def test_submit_document_with_access(self): def test_submit_document_with_access(self):
self.grant_access( self.grant_access(
@@ -32,19 +34,25 @@ class OCRAPITestCase(DocumentTestMixin, BaseAPITestCase):
response = self._request_document_ocr_submit_view() response = self._request_document_ocr_submit_view()
self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED) self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED)
self.assertTrue(hasattr(self.test_document.pages.first(), 'ocr_content')) self.assertTrue(
hasattr(self.test_document.pages.first(), 'ocr_content')
)
def _request_document_version_ocr_submit_view(self): def _request_document_version_ocr_submit_view(self):
return self.post( return self.post(
viewname='rest_api:document-version-ocr-submit-view', viewname='rest_api:document-version-ocr-submit-view', kwargs={
args=(self.test_document.pk, self.test_document.latest_version.pk,) 'document_pk': self.test_document.pk,
'version_pk': self.test_document.latest_version.pk
}
) )
def test_submit_document_version_no_access(self): def test_submit_document_version_no_access(self):
response = self._request_document_version_ocr_submit_view() response = self._request_document_version_ocr_submit_view()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN) self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertFalse(hasattr(self.test_document.pages.first(), 'ocr_content')) self.assertFalse(
hasattr(self.test_document.pages.first(), 'ocr_content')
)
def test_submit_document_version_with_access(self): def test_submit_document_version_with_access(self):
self.grant_access( self.grant_access(
@@ -53,15 +61,17 @@ class OCRAPITestCase(DocumentTestMixin, BaseAPITestCase):
response = self._request_document_version_ocr_submit_view() response = self._request_document_version_ocr_submit_view()
self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED) self.assertEqual(response.status_code, status.HTTP_202_ACCEPTED)
self.assertTrue(hasattr(self.test_document.pages.first(), 'ocr_content')) self.assertTrue(
hasattr(self.test_document.pages.first(), 'ocr_content')
)
def _request_document_page_content_view(self): def _request_document_page_content_view(self):
return self.get( return self.get(
viewname='rest_api:document-page-ocr-content-view', viewname='rest_api:document-page-ocr-content-view', kwargs={
args=( 'document_pk': self.test_document.pk,
self.test_document.pk, self.test_document.latest_version.pk, 'version_pk': self.test_document.latest_version.pk,
self.test_document.latest_version.pages.first().pk, 'page_pk': self.test_document.latest_version.pages.first().pk,
) }
) )
def test_get_document_version_page_content_no_access(self): def test_get_document_version_page_content_no_access(self):