Don't override the content_type CBV attribute.
These views (get method views) used it to set the content type of the response. Fixes GitLab issue #311 for the ACL list view. Note to Django developers: self.content_type should be a private attribute -> self._content_type
This commit is contained in:
@@ -121,13 +121,13 @@ class ACLDeleteView(SingleObjectDeleteView):
|
|||||||
|
|
||||||
class ACLListView(SingleObjectListView):
|
class ACLListView(SingleObjectListView):
|
||||||
def dispatch(self, request, *args, **kwargs):
|
def dispatch(self, request, *args, **kwargs):
|
||||||
self.content_type = get_object_or_404(
|
self.object_content_type = get_object_or_404(
|
||||||
ContentType, app_label=self.kwargs['app_label'],
|
ContentType, app_label=self.kwargs['app_label'],
|
||||||
model=self.kwargs['model']
|
model=self.kwargs['model']
|
||||||
)
|
)
|
||||||
|
|
||||||
try:
|
try:
|
||||||
self.content_object = self.content_type.get_object_for_this_type(
|
self.content_object = self.object_content_type.get_object_for_this_type(
|
||||||
pk=self.kwargs['object_id']
|
pk=self.kwargs['object_id']
|
||||||
)
|
)
|
||||||
except self.content_type.model_class().DoesNotExist:
|
except self.content_type.model_class().DoesNotExist:
|
||||||
@@ -153,7 +153,7 @@ class ACLListView(SingleObjectListView):
|
|||||||
|
|
||||||
def get_queryset(self):
|
def get_queryset(self):
|
||||||
return AccessControlList.objects.filter(
|
return AccessControlList.objects.filter(
|
||||||
content_type=self.content_type, object_id=self.content_object.pk
|
content_type=self.object_content_type, object_id=self.content_object.pk
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user