matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't silence exceptions in production mode.

Browse Source 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2017-06-10 18:13:23 -04:00
parent 382ee8cc1f
commit c769f7bd1b
1 changed files with 39 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
mayan/apps/metadata/views.py
View File

@@ -139,33 +139,52 @@ class DocumentMetadataAddView(MultipleObjectFormActionView):
def object_action(self, form, instance): def object_action(self, form, instance):
for metadata_type in form.cleaned_data['metadata_type']: for metadata_type in form.cleaned_data['metadata_type']:
document_metadata, created = DocumentMetadata.objects.get_or_create( try:
document=instance, document_metadata, created = DocumentMetadata.objects.get_or_create(
metadata_type=metadata_type, document=instance,
defaults={'value': ''} metadata_type=metadata_type,
) defaults={'value': ''}
)
if created: except Exception as exception:
messages.success( #if getattr(settings, 'DEBUG', False):
# raise
#else:
messages.error(
self.request, self.request,
_( _(
'Metadata type: %(metadata_type)s ' 'Error adding metadata type '
'successfully added to document %(document)s.' '"%(metadata_type)s" to document: '
'%(document)s; %(exception)s'
) % { ) % {
'metadata_type': metadata_type, 'metadata_type': metadata_type,
'document': instance 'document': instance,
'exception': ', '.join(
getattr(exception, 'messages', exception)
)
} }
) )
else: else:
messages.warning( if created:
self.request, _( messages.success(
'Metadata type: %(metadata_type)s already ' self.request,
'present in document %(document)s.' _(
) % { 'Metadata type: %(metadata_type)s '
'metadata_type': metadata_type, 'successfully added to document %(document)s.'
'document': instance ) % {
} 'metadata_type': metadata_type,
) 'document': instance
}
)
else:
messages.warning(
self.request, _(
'Metadata type: %(metadata_type)s already '
'present in document %(document)s.'
) % {
'metadata_type': metadata_type,
'document': instance
}
)
class DocumentMetadataEditView(MultipleObjectFormActionView): class DocumentMetadataEditView(MultipleObjectFormActionView):