matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use context manager to avoid open files

Browse Source 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-05-14 02:31:02 -04:00
parent 3a623ee416
commit c59f35225c
1 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mayan/apps/documents/models/document_version_models.py
View File

@@ -175,7 +175,8 @@ class DocumentVersion(models.Model):
logger.debug('Intermidiate file "%s" not found.', cache_filename) logger.debug('Intermidiate file "%s" not found.', cache_filename)
try: try:
converter = get_converter_class()(file_object=self.open()) with self.open() as version_file_object:
converter = get_converter_class()(file_object=version_file_object)
with converter.to_pdf() as pdf_file_object: with converter.to_pdf() as pdf_file_object:
# Since open "wb+" doesn't create files, check if the file # Since open "wb+" doesn't create files, check if the file