matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve how settings are loaded from config file

Browse Source 
Update the way settings are loaded. Instead of loading the
entire config file now settings are loaded from the config
file on demand when the cache misses.

Improve the smart settings classes tests and add another test
for the config file loading.

Add support for variable config file path.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
This commit is contained in:
Roberto Rosario
2018-12-15 21:00:51 -04:00
parent 8559565dca
commit b83ab1b528
7 changed files with 67 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
mayan/apps/smart_settings/tests/test_classes.py
View File

@@ -2,15 +2,39 @@ from __future__ import absolute_import, unicode_literals
import os
import yaml
from django.conf import settings
from mayan.apps.common.settings import setting_paginate_by
from mayan.apps.common.tests import BaseTestCase
from mayan.apps.common.utils import fs_cleanup, mkstemp
from .literals import ENVIRONMENT_TEST_NAME, ENVIRONMENT_TEST_VALUE
from .literals import TEST_SETTING_NAME, TEST_SETTING_VALUE
class ClassesTestCase(BaseTestCase):
def test_config_file(self):
test_config_file_descriptor, test_config_filename = mkstemp()
with open(test_config_filename, mode='w') as file_object:
file_object.write(
yaml.safe_dump(
{TEST_SETTING_NAME: TEST_SETTING_VALUE}
)
)
settings.CONFIGURATION_FILEPATH = test_config_filename
setting_value = setting_paginate_by.value
fs_cleanup(filename=test_config_filename)
self.assertEqual(setting_value, TEST_SETTING_VALUE)
def test_environment_variable(self):
os.environ[
'MAYAN_{}'.format(ENVIRONMENT_TEST_NAME)
] = ENVIRONMENT_TEST_VALUE
self.assertTrue(setting_paginate_by.value, ENVIRONMENT_TEST_VALUE)
os.environ['MAYAN_{}'.format(TEST_SETTING_NAME)] = '{}'.format(
TEST_SETTING_VALUE
)
setting_value = setting_paginate_by.value
os.environ.pop('MAYAN_{}'.format(TEST_SETTING_NAME))
self.assertEqual(setting_value, TEST_SETTING_VALUE)