Code style improvement. Test code consolidation. PEP8 cleanups.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2018-10-06 02:13:36 -04:00
parent 025fafabf4
commit a99b044555
50 changed files with 656 additions and 682 deletions

View File

@@ -16,25 +16,26 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
self.login_user()
def _upload_duplicate_document(self):
with open(TEST_SMALL_DOCUMENT_PATH, 'rb') as file_object:
with open(TEST_SMALL_DOCUMENT_PATH, mode='rb') as file_object:
self.document_duplicate = self.document_type.new_document(
file_object=file_object, label=TEST_SMALL_DOCUMENT_FILENAME
)
def _request_duplicated_document_list(self):
return self.get('documents:duplicated_document_list')
def _request_duplicated_document_list_view(self):
return self.get(viewname='documents:duplicated_document_list')
def _request_document_duplicates_list(self):
def _request_document_duplicates_list_view(self):
return self.get(
'documents:document_duplicates_list', args=(self.document.pk,)
viewname='documents:document_duplicates_list',
args=(self.document.pk,)
)
def test_duplicated_document_list_no_permissions(self):
self._upload_duplicate_document()
response = self._request_duplicated_document_list()
response = self._request_duplicated_document_list_view()
self.assertNotContains(
response, text=self.document.label, status_code=200
response=response, text=self.document.label, status_code=200
)
def test_duplicated_document_list_with_access(self):
@@ -46,15 +47,15 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
obj=self.document_duplicate,
permission=permission_document_view
)
response = self._request_duplicated_document_list()
response = self._request_duplicated_document_list_view()
self.assertContains(
response, text=self.document.label, status_code=200
response=response, text=self.document.label, status_code=200
)
def test_document_duplicates_list_no_permissions(self):
self._upload_duplicate_document()
response = self._request_document_duplicates_list()
response = self._request_document_duplicates_list_view()
self.assertEqual(response.status_code, 403)
@@ -67,8 +68,8 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
obj=self.document_duplicate,
permission=permission_document_view
)
response = self._request_document_duplicates_list()
response = self._request_document_duplicates_list_view()
self.assertContains(
response, text=self.document.label, status_code=200
response=response, text=self.document.label, status_code=200
)