matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Test simplification

Browse Source 
Unify usage of self.test_document and self.test_documents in
tests.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-05-07 00:54:59 -04:00
parent ebc68d3c36
commit a0d2000419
36 changed files with 306 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
mayan/apps/documents/tests/test_models.py
View File

@@ -23,46 +23,46 @@ from .mixins import DocumentTestMixin
class DocumentTestCase(DocumentTestMixin, BaseTestCase):
def test_natural_keys(self):
self.document.pages.first().generate_image()
self.test_document.pages.first().generate_image()
self._test_database_conversion('documents')
def test_document_creation(self):
self.assertEqual(self.document_type.label, TEST_DOCUMENT_TYPE_LABEL)
self.assertEqual(self.test_document_type.label, TEST_DOCUMENT_TYPE_LABEL)
self.assertEqual(self.document.exists(), True)
self.assertEqual(self.document.size, TEST_SMALL_DOCUMENT_SIZE)
self.assertEqual(self.test_document.exists(), True)
self.assertEqual(self.test_document.size, TEST_SMALL_DOCUMENT_SIZE)
self.assertEqual(
self.document.file_mimetype, TEST_SMALL_DOCUMENT_MIMETYPE
self.test_document.file_mimetype, TEST_SMALL_DOCUMENT_MIMETYPE
)
self.assertEqual(self.document.file_mime_encoding, 'binary')
self.assertEqual(self.document.label, TEST_SMALL_DOCUMENT_FILENAME)
self.assertEqual(self.test_document.file_mime_encoding, 'binary')
self.assertEqual(self.test_document.label, TEST_SMALL_DOCUMENT_FILENAME)
self.assertEqual(
self.document.checksum, TEST_SMALL_DOCUMENT_CHECKSUM
self.test_document.checksum, TEST_SMALL_DOCUMENT_CHECKSUM
)
self.assertEqual(self.document.page_count, 1)
self.assertEqual(self.test_document.page_count, 1)
def test_version_creation(self):
with open(TEST_SMALL_DOCUMENT_PATH, mode='rb') as file_object:
self.document.new_version(file_object=file_object)
self.test_document.new_version(file_object=file_object)
with open(TEST_SMALL_DOCUMENT_PATH, mode='rb') as file_object:
self.document.new_version(
self.test_document.new_version(
file_object=file_object, comment='test comment 1'
)
self.assertEqual(self.document.versions.count(), 3)
self.assertEqual(self.test_document.versions.count(), 3)
def test_restoring_documents(self):
self.assertEqual(Document.objects.count(), 1)
# Trash the document
self.document.delete()
self.test_document.delete()
self.assertEqual(DeletedDocument.objects.count(), 1)
self.assertEqual(Document.objects.count(), 0)
# Restore the document
self.document.restore()
self.test_document.restore()
self.assertEqual(DeletedDocument.objects.count(), 0)
self.assertEqual(Document.objects.count(), 1)
@@ -70,12 +70,12 @@ class DocumentTestCase(DocumentTestMixin, BaseTestCase):
self.assertEqual(Document.objects.count(), 1)
# Trash the document
self.document.delete()
self.test_document.delete()
self.assertEqual(DeletedDocument.objects.count(), 1)
self.assertEqual(Document.objects.count(), 0)
# Delete the document
self.document.delete()
self.test_document.delete()
self.assertEqual(DeletedDocument.objects.count(), 0)
self.assertEqual(Document.objects.count(), 0)
@@ -84,10 +84,10 @@ class DocumentTestCase(DocumentTestMixin, BaseTestCase):
Test document type trashing policies. Documents are moved to the
trash, x amount of time after being uploaded
"""
self.document_type.trash_time_period = 1
self.test_document_type.trash_time_period = 1
# 'seconds' is not a choice via the model, used here for convenience
self.document_type.trash_time_unit = 'seconds'
self.document_type.save()
self.test_document_type.trash_time_unit = 'seconds'
self.test_document_type.save()
# Needed by MySQL as milliseconds value is not store in timestamp
# field
@@ -106,15 +106,15 @@ class DocumentTestCase(DocumentTestMixin, BaseTestCase):
Test document type deletion policies. Documents are deleted from the
trash, x amount of time after being trashed
"""
self.document_type.delete_time_period = 1
self.test_document_type.delete_time_period = 1
# 'seconds' is not a choice via the model, used here for convenience
self.document_type.delete_time_unit = 'seconds'
self.document_type.save()
self.test_document_type.delete_time_unit = 'seconds'
self.test_document_type.save()
self.assertEqual(Document.objects.count(), 1)
self.assertEqual(DeletedDocument.objects.count(), 0)
self.document.delete()
self.test_document.delete()
self.assertEqual(Document.objects.count(), 0)
self.assertEqual(DeletedDocument.objects.count(), 1)
@@ -131,17 +131,17 @@ class DocumentTestCase(DocumentTestMixin, BaseTestCase):
class PDFCompatibilityTestCase(BaseTestCase):
def test_indirect_rotate(self):
self.document_type = DocumentType.objects.create(
self.test_document_type = DocumentType.objects.create(
label=TEST_DOCUMENT_TYPE_LABEL
)
with open(TEST_PDF_INDIRECT_ROTATE_PATH, mode='rb') as file_object:
self.document = self.document_type.new_document(
self.test_document = self.test_document_type.new_document(
file_object=file_object
)
self.assertQuerysetEqual(
qs=Document.objects.all(), values=(repr(self.document),)
qs=Document.objects.all(), values=(repr(self.test_document),)
)
@@ -149,106 +149,106 @@ class OfficeDocumentTestCase(BaseTestCase):
def setUp(self):
super(OfficeDocumentTestCase, self).setUp()
self.document_type = DocumentType.objects.create(
self.test_document_type = DocumentType.objects.create(
label=TEST_DOCUMENT_TYPE_LABEL
)
with open(TEST_OFFICE_DOCUMENT_PATH, mode='rb') as file_object:
self.document = self.document_type.new_document(
self.test_document = self.test_document_type.new_document(
file_object=file_object
)
def tearDown(self):
self.document_type.delete()
self.test_document_type.delete()
super(OfficeDocumentTestCase, self).tearDown()
def test_document_creation(self):
self.assertEqual(self.document.file_mimetype, 'application/msword')
self.assertEqual(self.test_document.file_mimetype, 'application/msword')
self.assertEqual(
self.document.file_mime_encoding, 'binary'
self.test_document.file_mime_encoding, 'binary'
)
self.assertEqual(
self.document.checksum,
self.test_document.checksum,
'03a7e9071d2c6ae05a6588acd7dff1d890fac2772cf61abd470c9ffa6ef71f03'
)
self.assertEqual(self.document.page_count, 2)
self.assertEqual(self.test_document.page_count, 2)
class MultiPageTiffTestCase(BaseTestCase):
def setUp(self):
super(MultiPageTiffTestCase, self).setUp()
self.document_type = DocumentType.objects.create(
self.test_document_type = DocumentType.objects.create(
label=TEST_DOCUMENT_TYPE_LABEL
)
with open(TEST_MULTI_PAGE_TIFF_PATH, mode='rb') as file_object:
self.document = self.document_type.new_document(
self.test_document = self.test_document_type.new_document(
file_object=file_object
)
def tearDown(self):
self.document_type.delete()
self.test_document_type.delete()
super(MultiPageTiffTestCase, self).tearDown()
def test_document_creation(self):
self.assertEqual(self.document.file_mimetype, 'image/tiff')
self.assertEqual(self.document.file_mime_encoding, 'binary')
self.assertEqual(self.test_document.file_mimetype, 'image/tiff')
self.assertEqual(self.test_document.file_mime_encoding, 'binary')
self.assertEqual(
self.document.checksum,
self.test_document.checksum,
'40adaa9d658b65c70a7f002dfe084a8354bb77c0dfbf1993e31fb024a285fb1d'
)
self.assertEqual(self.document.page_count, 2)
self.assertEqual(self.test_document.page_count, 2)
class DocumentVersionTestCase(GenericDocumentTestCase):
def test_add_new_version(self):
self.assertEqual(self.document.versions.count(), 1)
self.assertEqual(self.test_document.versions.count(), 1)
with open(TEST_DOCUMENT_PATH, mode='rb') as file_object:
self.document.new_version(
self.test_document.new_version(
file_object=file_object
)
self.assertEqual(self.document.versions.count(), 2)
self.assertEqual(self.test_document.versions.count(), 2)
self.assertEqual(
self.document.checksum,
self.test_document.checksum,
'c637ffab6b8bb026ed3784afdb07663fddc60099853fae2be93890852a69ecf3'
)
def test_revert_version(self):
self.assertEqual(self.document.versions.count(), 1)
self.assertEqual(self.test_document.versions.count(), 1)
# Needed by MySQL as milliseconds value is not store in timestamp
# field
time.sleep(1.01)
with open(TEST_DOCUMENT_PATH, mode='rb') as file_object:
self.document.new_version(
self.test_document.new_version(
file_object=file_object
)
self.assertEqual(self.document.versions.count(), 2)
self.assertEqual(self.test_document.versions.count(), 2)
self.document.versions.first().revert()
self.test_document.versions.first().revert()
self.assertEqual(self.document.versions.count(), 1)
self.assertEqual(self.test_document.versions.count(), 1)
class DocumentManagerTestCase(BaseTestCase):
def setUp(self):
super(DocumentManagerTestCase, self).setUp()
self.document_type = DocumentType.objects.create(
self.test_document_type = DocumentType.objects.create(
label=TEST_DOCUMENT_TYPE_LABEL
)
def tearDown(self):
self.document_type.delete()
self.test_document_type.delete()
super(DocumentManagerTestCase, self).tearDown()
def test_document_stubs_deletion(self):
document_stub = Document.objects.create(
document_type=self.document_type
document_type=self.test_document_type
)
Document.passthrough.delete_stubs()
@@ -267,19 +267,31 @@ class DocumentManagerTestCase(BaseTestCase):
class DuplicatedDocumentsTestCase(GenericDocumentTestCase):
def test_duplicates_after_delete(self):
document_2 = self.upload_document()
document_2.delete()
document_2.delete()
self.upload_document()
self.test_documents[1].delete()
self.test_documents[1].delete()
self.assertEqual(DuplicatedDocument.objects.filter(document=self.document).count(), 0)
self.assertEqual(
DuplicatedDocument.objects.filter(
document=self.test_documents[0]
).count(), 0
)
def test_duplicates_after_trash(self):
document_2 = self.upload_document()
document_2.delete()
self.upload_document()
self.test_documents[1].delete()
self.assertFalse(document_2 in DuplicatedDocument.objects.get(document=self.document).documents.all())
self.assertFalse(
self.test_documents[1] in DuplicatedDocument.objects.get(
document=self.test_documents[0]
).documents.all()
)
def test_duplicate_scan(self):
document_2 = self.upload_document()
self.upload_document()
self.assertTrue(document_2 in DuplicatedDocument.objects.get(document=self.document).documents.all())
self.assertTrue(
self.test_documents[1] in DuplicatedDocument.objects.get(
document=self.test_documents[0]
).documents.all()
)