Test simplification

Unify usage of self.test_document and self.test_documents in
tests.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-05-07 00:54:59 -04:00
parent ebc68d3c36
commit a0d2000419
36 changed files with 306 additions and 276 deletions
@@ -7,7 +7,7 @@ from .base import GenericDocumentViewTestCase
class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
def _upload_duplicate_document(self):
self.test_duplicated_document = self.upload_document()
self.upload_document()
def _request_duplicated_document_list_view(self):
return self.get(viewname='documents:duplicated_document_list')
@@ -15,7 +15,7 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
def _request_document_duplicates_list_view(self):
return self.get(
viewname='documents:document_duplicates_list',
kwargs={'pk': self.test_document.pk}
kwargs={'pk': self.test_documents[0].pk}
)
def test_duplicated_document_list_no_permissions(self):
@@ -23,22 +23,25 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
response = self._request_duplicated_document_list_view()
self.assertNotContains(
response=response, text=self.test_document.label, status_code=200
response=response, text=self.test_documents[0].label,
status_code=200
)
def test_duplicated_document_list_with_access(self):
self._upload_duplicate_document()
self.grant_access(
obj=self.test_document, permission=permission_document_view
obj=self.test_documents[0],
permission=permission_document_view
)
self.grant_access(
obj=self.test_duplicated_document,
obj=self.test_documents[1],
permission=permission_document_view
)
response = self._request_duplicated_document_list_view()
self.assertContains(
response=response, text=self.test_document.label, status_code=200
response=response, text=self.test_documents[0].label,
status_code=200
)
def test_document_duplicates_list_no_permissions(self):
@@ -50,14 +53,16 @@ class DuplicatedDocumentsViewsTestCase(GenericDocumentViewTestCase):
def test_document_duplicates_list_with_access(self):
self._upload_duplicate_document()
self.grant_access(
obj=self.test_document, permission=permission_document_view
obj=self.test_documents[0],
permission=permission_document_view
)
self.grant_access(
obj=self.test_duplicated_document,
obj=self.test_documents[1],
permission=permission_document_view
)
response = self._request_document_duplicates_list_view()
self.assertContains(
response=response, text=self.test_document.label, status_code=200
response=response, text=self.test_documents[0].label,
status_code=200
)