matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Only execute enabled actions. Store action execution errors

Browse Source 
in the error log.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2017-08-26 22:05:28 -04:00
parent 96e143208f
commit 9af5835df5
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mayan/apps/document_states/models.py
View File

@@ -244,7 +244,15 @@ class WorkflowStateAction(models.Model):
self.save() self.save()
def execute(self, context): def execute(self, context):
self.get_class_instance().execute(context=context) try:
self.get_class_instance().execute(context=context)
except Exception as exception:
self.error_logs.create(
result='{}; {}'.format(exception.__class__.__name__, exception)
)
if settings.DEBUG:
raise
def get_class(self): def get_class(self):
return import_string(self.action_path) return import_string(self.action_path)
@@ -453,10 +461,10 @@ class WorkflowInstanceLogEntry(models.Model):
def save(self, *args, **kwargs): def save(self, *args, **kwargs):
result = super(WorkflowInstanceLogEntry, self).save(*args, **kwargs) result = super(WorkflowInstanceLogEntry, self).save(*args, **kwargs)
for action in self.transition.origin_state.exit_actions.all(): for action in self.transition.origin_state.exit_actions.filter(enabled=True):
action.execute(context={'action': action, 'entry_log': self}) action.execute(context={'action': action, 'entry_log': self})
for action in self.transition.destination_state.entry_actions.all(): for action in self.transition.destination_state.entry_actions.filter(enabled=True):
action.execute(context={'action': action, 'entry_log': self}) action.execute(context={'action': action, 'entry_log': self})
return result return result