matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor the Django GPG app API views

Browse Source 
Convert the Django GPG app API view to use viewsets.

Add key-list API view test.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
This commit is contained in:
Roberto Rosario
2019-02-06 21:36:27 -04:00
parent 278f97b7e4
commit 999e164c3d
6 changed files with 58 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
mayan/apps/django_gpg/tests/test_api.py
View File

@@ -10,18 +10,10 @@ from ..permissions import (
)
from .literals import TEST_KEY_DATA, TEST_KEY_FINGERPRINT
from .mixins import KeyTestMixin
class KeyAPITestCase(BaseAPITestCase):
def setUp(self):
super(KeyAPITestCase, self).setUp()
self.login_user()
def _create_key(self):
return Key.objects.create(key_data=TEST_KEY_DATA)
# Key creation by upload
class KeyAPITestCase(KeyTestMixin, BaseAPITestCase):
def _request_key_create_view(self):
return self.post(
viewname='rest_api:key-list', data={
@@ -32,13 +24,13 @@ class KeyAPITestCase(BaseAPITestCase):
def test_key_create_view_no_permission(self):
response = self._request_key_create_view()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEqual(Key.objects.count(), 0)
def test_key_create_view_with_permission(self):
self.grant_permission(permission=permission_key_upload)
response = self._request_key_create_view()
self.assertEqual(response.status_code, status.HTTP_201_CREATED)
self.assertEqual(response.data['fingerprint'], TEST_KEY_FINGERPRINT)
@@ -46,49 +38,70 @@ class KeyAPITestCase(BaseAPITestCase):
self.assertEqual(Key.objects.count(), 1)
self.assertEqual(key.fingerprint, TEST_KEY_FINGERPRINT)
# Key deletion
def _request_key_delete_view(self):
return self.delete(
viewname='rest_api:key-detail', kwargs={'key_id': self.key.pk}
viewname='rest_api:key-detail', kwargs={'key_id': self.test_key.pk}
)
def test_key_delete_view_no_access(self):
self.key = self._create_key()
self._create_test_key()
response = self._request_key_delete_view()
self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
self.assertEqual(Key.objects.count(), 1)
def test_key_delete_view_with_access(self):
self.key = self._create_key()
self._create_test_key()
self.grant_access(
permission=permission_key_delete, obj=self.key
permission=permission_key_delete, obj=self.test_key
)
response = self._request_key_delete_view()
self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
self.assertEqual(Key.objects.count(), 0)
# Key detail
self.assertEqual(Key.objects.count(), 0)
def _request_key_detail_view(self):
return self.get(
viewname='rest_api:key-detail', kwargs={'key_id': self.key.pk}
viewname='rest_api:key-detail', kwargs={'key_id': self.test_key.pk}
)
def test_key_detail_view_no_access(self):
self.key = self._create_key()
response = self._request_key_detail_view()
self._create_test_key()
response = self._request_key_detail_view()
self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
def test_key_detail_view_with_access(self):
self.key = self._create_key()
self._create_test_key()
self.grant_access(
permission=permission_key_view, obj=self.key
permission=permission_key_view, obj=self.test_key
)
response = self._request_key_detail_view()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(
response.data['fingerprint'], self.key.fingerprint
response.data['fingerprint'], self.test_key.fingerprint
)
def _request_key_list_view(self):
return self.get(viewname='rest_api:key-list')
def test_key_list_view_no_access(self):
self._create_test_key()
response = self._request_key_list_view()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(response.json()['count'], 0)
def test_key_list_view_with_access(self):
self._create_test_key()
self.grant_access(
permission=permission_key_view, obj=self.test_key
)
response = self._request_key_list_view()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(response.json()['count'], 1)