Backport document page view improvements

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-05-07 15:27:46 -04:00
parent 28114264c1
commit 8e5b60e1c0
5 changed files with 136 additions and 150 deletions
@@ -1,12 +1,14 @@
from __future__ import unicode_literals
from django.utils.encoding import force_text
from ..permissions import permission_document_view
from .base import GenericDocumentViewTestCase
class DocumentPageViewTestCase(GenericDocumentViewTestCase):
def _document_page_list_view(self):
def _request_test_document_page_list_view(self):
return self.get(
viewname='documents:document_pages', kwargs={
'pk': self.test_document.pk
@@ -14,15 +16,42 @@ class DocumentPageViewTestCase(GenericDocumentViewTestCase):
)
def test_document_page_list_view_no_permission(self):
response = self._document_page_list_view()
self.assertEqual(response.status_code, 403)
response = self._request_test_document_page_list_view()
self.assertEqual(response.status_code, 404)
def test_document_page_list_view_with_access(self):
self.grant_access(
obj=self.test_document, permission=permission_document_view
)
response = self._document_page_list_view()
response = self._request_test_document_page_list_view()
self.assertContains(
response=response, text=self.test_document.label, status_code=200
)
def _request_test_document_page_view(self, document_page):
return self.get(
viewname='documents:document_page_view', kwargs={
'pk': document_page.pk,
}
)
def test_document_page_view_no_permissions(self):
response = self._request_test_document_page_view(
document_page=self.test_document.pages.first()
)
self.assertEqual(response.status_code, 404)
def test_document_page_view_with_access(self):
self.grant_access(
obj=self.test_document, permission=permission_document_view
)
response = self._request_test_document_page_view(
document_page=self.test_document.pages.first()
)
self.assertContains(
response=response, text=force_text(
self.test_document.pages.first()
), status_code=200
)
@@ -510,32 +510,6 @@ class DocumentsViewsTestCase(GenericDocumentViewTestCase):
self.assertEqual(DeletedDocument.objects.count(), 0)
self.assertEqual(Document.objects.count(), 0)
def _request_document_page_view(self, document_page):
return self.get(
viewname='documents:document_page_view', kwargs={
'pk': document_page.pk,
}
)
def test_document_page_view_no_permissions(self):
response = self._request_document_page_view(
document_page=self.test_document.pages.first()
)
self.assertEqual(response.status_code, 403)
def test_document_page_view_with_access(self):
self.grant_access(
obj=self.test_document, permission=permission_document_view
)
response = self._request_document_page_view(
document_page=self.test_document.pages.first()
)
self.assertContains(
response=response, text=force_text(self.test_document.pages.first()),
status_code=200
)
def _request_document_print_view(self):
return self.get(
viewname='documents:document_print', kwargs={