Remove app top level star imports

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>

HISTORY.rst

@@ -173,6 +173,7 @@
 * Rename transformation manager method get_for_model to
   get_for_object.
 * Load the converter class on demand.
+* Remove app top level star imports.
 
 3.1.11 (2019-04-XX)
 ===================

docs/releases/3.2.rst

@@ -205,6 +205,7 @@ Other changes
 * Rename transformation manager method get_for_model to
   get_for_object.
 * Load the converter class on demand.
+* Remove app top level star imports.
 
 Removals
 --------

mayan/apps/acls/apps.py

@@ -4,7 +4,7 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_object, menu_secondary
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .links import link_acl_create, link_acl_delete, link_acl_permissions
 

mayan/apps/acls/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_acl_delete, icon_acl_list, icon_acl_new
 from .permissions import permission_acl_view, permission_acl_edit

mayan/apps/authentication/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_logout, icon_password_change
 

mayan/apps/cabinets/apps.py

@@ -11,7 +11,7 @@ from mayan.apps.common.menus import (
     menu_secondary
 )
 from mayan.apps.documents.search import document_page_search, document_search
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .links import (
     link_cabinet_list, link_document_cabinet_list,

mayan/apps/cabinets/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Cabinets'), name='cabinets')
 

mayan/apps/cabinets/links.py

@@ -6,7 +6,8 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.documents.permissions import permission_document_view
-from mayan.apps.navigation import Link, get_cascade_condition
+from mayan.apps.navigation.classes import Link
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .permissions import (
     permission_cabinet_add_document, permission_cabinet_create,

mayan/apps/cabinets/menus.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Menu, get_cascade_condition
+from mayan.apps.navigation.classes import Menu
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .icons import icon_cabinet_list
 from .permissions import permission_cabinet_create, permission_cabinet_view

mayan/apps/checkouts/apps.py

@@ -12,7 +12,7 @@ from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_facet, menu_main, menu_secondary
 from mayan.apps.dashboards.dashboards import dashboard_main
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.celery import app
 
 from .dashboard_widgets import DashboardWidgetTotalCheckouts

mayan/apps/checkouts/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Checkouts'), name='checkouts')
 

mayan/apps/checkouts/links.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_check_in_document, icon_check_out_document, icon_check_out_info

mayan/apps/checkouts/tasks.py

@@ -4,7 +4,7 @@ import logging
 
 from django.apps import apps
 
-from mayan.apps.lock_manager import LockError
+from mayan.apps.lock_manager.exceptions import LockError
 from mayan.apps.lock_manager.runtime import locking_backend
 from mayan.celery import app
 

mayan/apps/common/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_about, icon_check_version, icon_current_user_locale_profile_details,

mayan/apps/common/menus.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Menu
+from mayan.apps.navigation.classes import Menu
 
 from .icons import icon_menu_about, icon_menu_user
 

mayan/apps/converter/__init__.py

@@ -1,8 +1,3 @@
 from __future__ import unicode_literals
 
-from .transformations import (  # NOQA
-    BaseTransformation, TransformationResize, TransformationRotate,
-    TransformationZoom
-)
-
 default_app_config = 'mayan.apps.converter.apps.ConverterApp'

mayan/apps/converter/apps.py

@@ -5,7 +5,7 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_object, menu_secondary
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .links import (
     link_transformation_create, link_transformation_delete,

mayan/apps/converter/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_transformation_create, permission_transformation_delete,

mayan/apps/django_gpg/apps.py

@@ -9,7 +9,7 @@ from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import (
     menu_facet, menu_object, menu_secondary, menu_setup
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .classes import KeyStub
 from .links import (

mayan/apps/django_gpg/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_key_setup, icon_key_upload, icon_keyserver_search
 from .permissions import (

mayan/apps/document_comments/apps.py

@@ -7,8 +7,8 @@ from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_facet, menu_object, menu_secondary
 from mayan.apps.documents.search import document_page_search, document_search
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .events import (
     event_document_comment_create, event_document_comment_delete

mayan/apps/document_comments/events.py

@@ -2,15 +2,15 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(
-    name='document_comments', label=_('Document comments')
+    label=_('Document comments'), name='document_comments'
 )
 
 event_document_comment_create = namespace.add_event_type(
-    name='create', label=_('Document comment created')
+    label=_('Document comment created'), name='create'
 )
 event_document_comment_delete = namespace.add_event_type(
-    name='delete', label=_('Document comment deleted')
+    label=_('Document comment deleted'), name='delete'
 )

mayan/apps/document_comments/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals, absolute_import
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_comment_add, icon_comment_delete, icon_comments_for_document
 from .permissions import (

mayan/apps/document_indexing/apps.py

@@ -16,7 +16,7 @@ from mayan.apps.common.menus import (
     menu_setup, menu_tools
 )
 from mayan.apps.documents.signals import post_document_created, post_initial_document_type
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .handlers import (

mayan/apps/document_indexing/links.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link, get_cascade_condition
+from mayan.apps.navigation.classes import Link
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .permissions import (
     permission_document_indexing_create, permission_document_indexing_edit,

mayan/apps/document_indexing/models.py

@@ -14,7 +14,7 @@ from mptt.models import MPTTModel
 from mayan.apps.acls.models import AccessControlList
 from mayan.apps.documents.models import Document, DocumentType
 from mayan.apps.documents.permissions import permission_document_view
-from mayan.apps.lock_manager import LockError
+from mayan.apps.lock_manager.exceptions import LockError
 from mayan.apps.lock_manager.runtime import locking_backend
 
 from .managers import (

mayan/apps/document_indexing/tasks.py

@@ -5,7 +5,7 @@ import logging
 from django.apps import apps
 from django.db import OperationalError
 
-from mayan.apps.lock_manager import LockError
+from mayan.apps.lock_manager.exceptions import LockError
 from mayan.celery import app
 
 from .literals import RETRY_DELAY

mayan/apps/document_parsing/apps.py

@@ -16,7 +16,7 @@ from mayan.apps.common.menus import (
 )
 from mayan.apps.documents.search import document_search, document_page_search
 from mayan.apps.documents.signals import post_version_upload
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .handlers import (

mayan/apps/document_parsing/events.py

@@ -2,10 +2,10 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(
-    name='document_parsing', label=_('Document parsing')
+    label=_('Document parsing'), name='document_parsing'
 )
 
 event_parsing_document_version_submit = namespace.add_event_type(

mayan/apps/document_parsing/links.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link, get_cascade_condition
+from mayan.apps.navigation.classes import Link
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .permissions import (
     permission_content_view, permission_document_type_parsing_setup,

mayan/apps/document_signatures/apps.py

@@ -13,7 +13,7 @@ from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import (
     menu_facet, menu_object, menu_secondary, menu_tools
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .handlers import (

mayan/apps/document_signatures/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_document_version_sign_detached,

mayan/apps/document_states/apps.py

@@ -17,7 +17,7 @@ from mayan.apps.common.menus import (
     menu_setup, menu_tools
 )
 from mayan.apps.common.permissions_runtime import permission_error_log_view
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .classes import DocumentStateHelper, WorkflowAction

mayan/apps/document_states/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_workflow_create, permission_workflow_delete,

mayan/apps/documents/apps.py

@@ -25,12 +25,12 @@ from mayan.apps.converter.permissions import (
     permission_transformation_delete, permission_transformation_edit,
     permission_transformation_view,
 )
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list,
 )
 from mayan.apps.events.permissions import permission_events_view
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.apps.rest_api.fields import DynamicSerializerField
 from mayan.celery import app
 

mayan/apps/documents/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Documents'), name='documents')
 

mayan/apps/documents/links.py

@@ -5,7 +5,7 @@ from django.utils.translation import ugettext_lazy as _
 from mayan.apps.converter.permissions import (
     permission_transformation_delete, permission_transformation_edit
 )
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_clear_image_cache,

mayan/apps/documents/menus.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Menu
+from mayan.apps.navigation.classes import Menu
 
 from .icons import icon_menu_documents
 

mayan/apps/documents/models/document_page_models.py

@@ -10,12 +10,12 @@ from django.urls import reverse
 from django.utils.encoding import force_text, python_2_unicode_compatible
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.converter import (
+from mayan.apps.converter.literals import DEFAULT_ZOOM_LEVEL, DEFAULT_ROTATION
+from mayan.apps.converter.models import Transformation
+from mayan.apps.converter.transformations import (
     BaseTransformation, TransformationResize, TransformationRotate,
     TransformationZoom
 )
-from mayan.apps.converter.literals import DEFAULT_ZOOM_LEVEL, DEFAULT_ROTATION
-from mayan.apps.converter.models import Transformation
 from mayan.apps.converter.utils import get_converter_class
 
 from ..managers import DocumentPageCachedImage, DocumentPageManager

mayan/apps/documents/models/document_version_models.py

@@ -12,9 +12,9 @@ from django.urls import reverse
 from django.utils.encoding import force_text, python_2_unicode_compatible
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.converter import TransformationRotate
 from mayan.apps.converter.exceptions import InvalidOfficeFormat, PageCountError
 from mayan.apps.converter.models import Transformation
+from mayan.apps.converter.transformations import TransformationRotate
 from mayan.apps.converter.utils import get_converter_class
 from mayan.apps.mimetype.api import get_mimetype
 

mayan/apps/documents/statistics.py

@@ -8,7 +8,9 @@ from django.utils.translation import ugettext_lazy as _
 
 import qsstats
 
-from mayan.apps.mayan_statistics import StatisticLineChart, StatisticNamespace
+from mayan.apps.mayan_statistics.classes import (
+    StatisticLineChart, StatisticNamespace
+)
 
 from .permissions import permission_document_view
 

mayan/apps/documents/tests/test_document_views.py

@@ -447,7 +447,7 @@ class DocumentsViewsTestCase(GenericDocumentViewTestCase):
         )
 
         self.assertQuerysetEqual(
-            Transformation.objects.get_for_object(obj==document_page),
+            Transformation.objects.get_for_object(obj=document_page),
             (repr(transformation),)
         )
 

mayan/apps/dynamic_search/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 link_search = Link(
     text=_('Search'), view='search:search', args='search_model.get_full_name'

mayan/apps/events/__init__.py

@@ -1,5 +1,3 @@
 from __future__ import unicode_literals
 
-from .classes import EventTypeNamespace, ModelEventType  # NOQA
-
 default_app_config = 'mayan.apps.events.apps.EventsApp'

mayan/apps/events/apps.py

@@ -8,7 +8,7 @@ from mayan.apps.common.html_widgets import TwoStateWidget
 from mayan.apps.common.menus import (
     menu_main, menu_object, menu_secondary, menu_tools, menu_user
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .html_widgets import (
     ObjectLinkWidget, widget_event_actor_link, widget_event_type_link

mayan/apps/events/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_events_list, icon_events_for_object,

mayan/apps/file_metadata/apps.py

@@ -15,8 +15,8 @@ from mayan.apps.common.menus import (
 from mayan.apps.document_indexing.handlers import handler_index_document
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.documents.signals import post_version_upload
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .drivers import *  # NOQA

mayan/apps/file_metadata/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(
     label=_('File metadata'), name='file_metadata'

mayan/apps/file_metadata/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_document_submit, icon_document_multiple_submit, icon_file_metadata

mayan/apps/linking/apps.py

@@ -11,7 +11,7 @@ from mayan.apps.common.html_widgets import TwoStateWidget
 from mayan.apps.common.menus import (
     menu_facet, menu_list_facet, menu_object, menu_secondary, menu_setup
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .links import (
     link_smart_link_create, link_smart_link_condition_create,

mayan/apps/linking/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.documents.permissions import permission_document_view
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_smart_link_condition_create, icon_smart_link_create,

mayan/apps/lock_manager/__init__.py

@@ -1,5 +1,3 @@
 from __future__ import unicode_literals
 
-from .exceptions import LockError  # NOQA
-
 default_app_config = 'mayan.apps.lock_manager.apps.LockManagerApp'

mayan/apps/mailer/apps.py

@@ -14,11 +14,11 @@ from mayan.apps.common.menus import (
     menu_list_facet, menu_multi_item, menu_object, menu_secondary, menu_setup,
     menu_tools
 )
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .classes import MailerBackend

mayan/apps/mailer/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Mailing'), name='mailing')
 

mayan/apps/mailer/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_mailing_link, permission_mailing_send_document,

mayan/apps/mayan_statistics/__init__.py

@@ -1,5 +1,3 @@
 from __future__ import unicode_literals
 
-from .classes import StatisticLineChart, StatisticNamespace  # NOQA
-
 default_app_config = 'mayan.apps.mayan_statistics.apps.StatisticsApp'

mayan/apps/mayan_statistics/apps.py

@@ -6,7 +6,7 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_object, menu_secondary, menu_tools
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .classes import StatisticLineChart, StatisticNamespace

mayan/apps/mayan_statistics/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_statistics
 from .permissions import permission_statistics_view

mayan/apps/metadata/__init__.py

@@ -1,5 +1,3 @@
 from __future__ import unicode_literals
 
-from .classes import MetadataLookup  # NOQA
-
 default_app_config = 'mayan.apps.metadata.apps.MetadataApp'

mayan/apps/metadata/apps.py

@@ -20,13 +20,13 @@ from mayan.apps.common.menus import (
 )
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.documents.signals import post_document_type_change
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list,
 )
 from mayan.apps.events.permissions import permission_events_view
 from mayan.celery import app
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .classes import DocumentMetadataHelper
 from .events import (

mayan/apps/metadata/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Metadata'), name='metadata')
 

mayan/apps/metadata/links.py

@@ -3,7 +3,7 @@ from __future__ import unicode_literals
 from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.documents.permissions import permission_document_type_edit
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_metadata_document_add, permission_metadata_document_edit,

mayan/apps/motd/apps.py

@@ -12,7 +12,7 @@ from mayan.apps.common.html_widgets import TwoStateWidget
 from mayan.apps.common.menus import (
     menu_list_facet, menu_object, menu_secondary, menu_setup
 )
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .links import (
     link_message_create, link_message_delete, link_message_edit,

mayan/apps/motd/links.py

@@ -2,7 +2,8 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link, get_cascade_condition
+from mayan.apps.navigation.classes import Link
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .permissions import (
     permission_message_create, permission_message_delete,

mayan/apps/navigation/__init__.py

@@ -1,6 +1,3 @@
 from __future__ import unicode_literals
 
-from .classes import Link, Menu, SourceColumn  # NOQA
-from .utils import get_cascade_condition  # NOQA
-
 default_app_config = 'mayan.apps.navigation.apps.NavigationApp'

mayan/apps/ocr/apps.py

@@ -16,7 +16,7 @@ from mayan.apps.common.menus import (
 )
 from mayan.apps.documents.search import document_search, document_page_search
 from mayan.apps.documents.signals import post_version_upload
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .handlers import (

mayan/apps/ocr/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('OCR'), name='ocr')
 

mayan/apps/ocr/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .permissions import (
     permission_ocr_content_view, permission_ocr_document,

mayan/apps/ocr/tasks.py

@@ -5,7 +5,7 @@ import logging
 from django.apps import apps
 from django.db import OperationalError
 
-from mayan.apps.lock_manager import LockError
+from mayan.apps.lock_manager.exceptions import LockError
 from mayan.apps.lock_manager.runtime import locking_backend
 from mayan.celery import app
 

mayan/apps/permissions/apps.py

@@ -12,7 +12,7 @@ from mayan.apps.common.menus import (
     menu_list_facet, menu_object, menu_secondary, menu_setup
 )
 from mayan.apps.common.signals import perform_upgrade
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list
 )

mayan/apps/permissions/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(
     label=_('Permissions'), name='permissions'

mayan/apps/permissions/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 from mayan.apps.user_management.permissions import permission_group_edit
 
 from .permissions import (

mayan/apps/permissions/views.py

@@ -1,22 +1,17 @@
 from __future__ import unicode_literals
 
-import itertools
-
 from django.contrib.auth.models import Group
-from django.shortcuts import get_object_or_404
 from django.template import RequestContext
 from django.urls import reverse_lazy
 from django.utils.encoding import force_text
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls.models import AccessControlList
 from mayan.apps.common.generics import (
-    AddRemoveView, AssignRemoveView, SingleObjectCreateView,
+    AddRemoveView, SingleObjectCreateView, SingleObjectDeleteView,
-    SingleObjectDeleteView, SingleObjectEditView, SingleObjectListView
+    SingleObjectEditView, SingleObjectListView
 )
 from mayan.apps.user_management.permissions import permission_group_edit
 
-from .classes import Permission, PermissionNamespace
 from .icons import icon_role_list
 from .links import link_role_create
 from .models import Role, StoredPermission
@@ -146,7 +141,6 @@ class SetupRolePermissionsView(AddRemoveView):
         }
 
 
-
 class RoleListView(SingleObjectListView):
     model = Role
     object_permission = permission_role_view

mayan/apps/rest_api/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import (
     icon_api, icon_api_documentation, icon_api_documentation_redoc

mayan/apps/smart_settings/apps.py

@@ -4,7 +4,7 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.menus import menu_secondary, menu_setup, menu_object
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .classes import Namespace, Setting
 from .links import (

mayan/apps/smart_settings/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_namespace_list
 from .permissions import permission_settings_edit, permission_settings_view

mayan/apps/sources/apps.py

@@ -14,7 +14,7 @@ from mayan.apps.common.signals import post_initial_setup, post_upgrade
 from mayan.apps.converter.links import link_transformation_list
 from mayan.apps.documents.menus import menu_documents
 from mayan.apps.documents.signals import post_version_upload
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.celery import app
 
 from .classes import StagingFile

mayan/apps/sources/classes.py

@@ -13,7 +13,7 @@ from django.urls import reverse
 from django.utils.encoding import force_text, python_2_unicode_compatible
 from django.utils.six.moves.urllib.parse import quote_plus, unquote_plus
 
-from mayan.apps.converter import TransformationResize
+from mayan.apps.converter.transformations import TransformationResize
 from mayan.apps.converter.utils import get_converter_class
 
 from .storages import storage_staging_file_image_cache

mayan/apps/sources/links.py

@@ -6,7 +6,7 @@ from django.utils.translation import ugettext_lazy as _
 from mayan.apps.documents.permissions import (
     permission_document_create, permission_document_new_version
 )
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .literals import (
     SOURCE_CHOICE_WEB_FORM, SOURCE_CHOICE_EMAIL_IMAP, SOURCE_CHOICE_EMAIL_POP3,

mayan/apps/sources/tasks.py

@@ -11,7 +11,7 @@ from mayan.celery import app
 
 from mayan.apps.common.compressed_files import Archive
 from mayan.apps.common.exceptions import NoMIMETypeMatch
-from mayan.apps.lock_manager import LockError
+from mayan.apps.lock_manager.exceptions import LockError
 from mayan.apps.lock_manager.runtime import locking_backend
 
 from .literals import (

mayan/apps/sources/views.py

@@ -25,7 +25,7 @@ from mayan.apps.documents.permissions import (
     permission_document_create, permission_document_new_version
 )
 from mayan.apps.documents.tasks import task_upload_new_version
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .exceptions import SourceException
 from .forms import (

mayan/apps/tags/apps.py

@@ -14,12 +14,12 @@ from mayan.apps.common.menus import (
     menu_secondary
 )
 from mayan.apps.documents.search import document_page_search, document_search
-from mayan.apps.events import ModelEventType
+from mayan.apps.events.classes import ModelEventType
 from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list,
 )
 from mayan.apps.events.permissions import permission_events_view
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .events import (
     event_tag_attach, event_tag_created, event_tag_edited, event_tag_remove

mayan/apps/tags/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(label=_('Tags'), name='tags')
 

mayan/apps/tags/links.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link, get_cascade_condition
+from mayan.apps.navigation.classes import Link
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .permissions import (
     permission_tag_attach, permission_tag_create, permission_tag_delete,

mayan/apps/tags/menus.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Menu, get_cascade_condition
+from mayan.apps.navigation.classes import Menu
+from mayan.apps.navigation.utils import get_cascade_condition
 
 from .icons import icon_menu_tags
 from .permissions import permission_tag_create, permission_tag_view

mayan/apps/task_manager/apps.py

@@ -5,7 +5,7 @@ from django.utils.translation import ugettext_lazy as _
 from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.html_widgets import TwoStateWidget
 from mayan.apps.common.menus import menu_object, menu_secondary, menu_tools
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 
 from .classes import CeleryQueue, Task
 from .links import (

mayan/apps/task_manager/links.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.navigation import Link
+from mayan.apps.navigation.classes import Link
 
 from .icons import icon_task_manager, icon_queue_list
 from .permissions import permission_task_view

mayan/apps/user_management/apps.py

@@ -19,8 +19,8 @@ from mayan.apps.events.links import (
     link_events_for_object, link_object_event_types_user_subcriptions_list
 )
 from mayan.apps.events.permissions import permission_events_view
-from mayan.apps.metadata import MetadataLookup
+from mayan.apps.metadata.classes import MetadataLookup
-from mayan.apps.navigation import SourceColumn
+from mayan.apps.navigation.classes import SourceColumn
 from mayan.apps.rest_api.fields import DynamicSerializerField
 
 from .events import (

mayan/apps/user_management/events.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.events import EventTypeNamespace
+from mayan.apps.events.classes import EventTypeNamespace
 
 namespace = EventTypeNamespace(
     label=_('User management'), name='user_management'