Remove star import from the ACL and Common apps

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>

HISTORY.rst

@@ -76,6 +76,7 @@
   format.
 * Move Pillow initialization from the module to the backend
   class initialization.
+* Remove star import from the ACL and Common apps.
 
 3.1.11 (2019-04-XX)
 ===================

docs/releases/3.2.rst

@@ -108,6 +108,7 @@ Other changes
   format.
 * Move Pillow initialization from the module to the backend
   class initialization.
+* Remove star import from the ACL and Common apps.
 
 Removals
 --------

mayan/apps/acls/__init__.py

@@ -1,5 +1,3 @@
 from __future__ import unicode_literals
 
-from .classes import ModelPermission  # NOQA
-
 default_app_config = 'mayan.apps.acls.apps.ACLsApp'

mayan/apps/acls/apps.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_object, menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_object, menu_sidebar
 from mayan.apps.navigation import SourceColumn
 
 from .links import link_acl_create, link_acl_delete, link_acl_permissions

mayan/apps/appearance/apps.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig
+from mayan.apps.common.apps import MayanAppConfig
 
 from .licenses import *  # NOQA
 

mayan/apps/authentication/apps.py

@@ -4,7 +4,8 @@ import logging
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_user
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_user
 from mayan.apps.navigation.classes import Separator
 
 from .links import link_logout, link_password_change

mayan/apps/autoadmin/apps.py

@@ -4,7 +4,7 @@ from django.conf import settings
 from django.db.models.signals import post_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig
+from mayan.apps.common.apps import MayanAppConfig
 
 from .handlers import handler_auto_admin_account_password_change
 

mayan/apps/cabinets/apps.py

@@ -3,11 +3,11 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_main, menu_multi_item, menu_object,
-    menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_facet, menu_main, menu_multi_item, menu_object, menu_sidebar
 )
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.navigation import SourceColumn

mayan/apps/checkouts/apps.py

@@ -8,8 +8,9 @@ from django.apps import apps
 from django.db.models.signals import pre_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
-from mayan.apps.common import MayanAppConfig, menu_facet, menu_main, menu_sidebar
+from mayan.apps.acls.classes import ModelPermission
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_facet, menu_main, menu_sidebar
 from mayan.apps.dashboards.dashboards import dashboard_main
 from mayan.apps.events import ModelEventType
 from mayan.celery import app

mayan/apps/common/__init__.py

@@ -1,7 +1,3 @@
 from __future__ import unicode_literals
 
-from .apps import MayanAppConfig  # NOQA
-from .classes import MissingItem  # NOQA
-from .menus import *  # NOQA
-
 default_app_config = 'mayan.apps.common.apps.CommonApp'

mayan/apps/converter/apps.py

@@ -3,7 +3,8 @@ from __future__ import unicode_literals
 from django.utils.encoding import force_text
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_object, menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_object, menu_sidebar
 from mayan.apps.navigation import SourceColumn
 
 from .links import (

mayan/apps/dashboards/apps.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig
+from mayan.apps.common.apps import MayanAppConfig
 
 
 class DashboardsApp(MayanAppConfig):

mayan/apps/django_gpg/apps.py

@@ -2,11 +2,12 @@ from __future__ import absolute_import, unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_object, menu_setup, menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_facet, menu_object, menu_setup, menu_sidebar
 )
 from mayan.apps.navigation import SourceColumn
 

mayan/apps/document_comments/apps.py

@@ -3,8 +3,9 @@ from __future__ import absolute_import, unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
-from mayan.apps.common import MayanAppConfig, menu_facet, menu_object, menu_sidebar
+from mayan.apps.acls.classes import ModelPermission
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_facet, menu_object, menu_sidebar
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.events import ModelEventType
 from mayan.apps.navigation import SourceColumn

mayan/apps/document_indexing/apps.py

@@ -6,12 +6,12 @@ from django.apps import apps
 from django.db.models.signals import post_delete, post_save, pre_delete
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_main, menu_object, menu_secondary,
-    menu_setup, menu_tools
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_facet, menu_main, menu_object, menu_secondary, menu_setup, menu_tools
 )
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.documents.signals import post_document_created, post_initial_document_type

mayan/apps/document_parsing/apps.py

@@ -8,12 +8,12 @@ from django.apps import apps
 from django.db.models.signals import post_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_multi_item, menu_object, menu_secondary,
-    menu_tools
-)
+from mayan.apps.acls.classes import ModelPermission
+from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.classes import ModelField
+from mayan.apps.common.menus import (
+    menu_facet, menu_multi_item, menu_object, menu_secondary, menu_tools
+)
 from mayan.apps.documents.search import document_search, document_page_search
 from mayan.apps.documents.signals import post_version_upload
 from mayan.apps.documents.widgets import document_link

mayan/apps/document_signatures/apps.py

@@ -8,9 +8,10 @@ from django.apps import apps
 from django.db.models.signals import post_save, post_delete
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_object, menu_sidebar, menu_tools
+from mayan.apps.acls.classes import ModelPermission
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_facet, menu_object, menu_sidebar, menu_tools
 )
 from mayan.apps.navigation import SourceColumn
 from mayan.celery import app

mayan/apps/document_states/apps.py

@@ -6,14 +6,15 @@ from django.utils.translation import ugettext_lazy as _
 
 from kombu import Exchange, Queue
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_main, menu_object, menu_secondary,
-    menu_setup, menu_sidebar, menu_tools
-)
+from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.classes import ModelAttribute
 from mayan.apps.common.links import link_object_error_list
+from mayan.apps.common.menus import (
+    menu_facet, menu_main, menu_object, menu_secondary, menu_setup,
+    menu_sidebar, menu_tools
+)
 from mayan.apps.common.permissions_runtime import permission_error_log_view
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.navigation import SourceColumn

mayan/apps/documents/apps.py

@@ -7,14 +7,15 @@ from kombu import Exchange, Queue
 from django.db.models.signals import post_delete
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, MissingItem, menu_facet, menu_main, menu_object,
-    menu_secondary, menu_setup, menu_sidebar, menu_multi_item, menu_tools
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.classes import MissingItem, ModelField, Template
+from mayan.apps.common.menus import (
+    menu_facet, menu_main, menu_object, menu_secondary, menu_setup,
+    menu_sidebar, menu_multi_item, menu_tools
 )
-from mayan.apps.common.classes import ModelField, Template
 from mayan.apps.common.signals import post_initial_setup
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.dashboards.dashboards import dashboard_main

mayan/apps/dynamic_search/apps.py

@@ -2,7 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_facet, menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_facet, menu_sidebar
 
 from .links import link_search, link_search_advanced, link_search_again
 

mayan/apps/events/apps.py

@@ -4,9 +4,9 @@ from django.apps import apps
 from django.contrib.auth import get_user_model
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import (
-    MayanAppConfig, menu_main, menu_object, menu_secondary, menu_tools,
-    menu_user
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_main, menu_object, menu_secondary, menu_tools, menu_user
 )
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.navigation import SourceColumn

mayan/apps/linking/apps.py

@@ -3,12 +3,12 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_object, menu_secondary, menu_setup,
-    menu_sidebar
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_facet, menu_object, menu_secondary, menu_setup, menu_sidebar
 )
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.navigation import SourceColumn

mayan/apps/mailer/apps.py

@@ -5,12 +5,12 @@ from kombu import Exchange, Queue
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_object, menu_multi_item, menu_secondary, menu_setup,
-    menu_tools
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_object, menu_multi_item, menu_secondary, menu_setup, menu_tools
 )
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.navigation import SourceColumn

mayan/apps/mayan_statistics/apps.py

@@ -4,7 +4,8 @@ from kombu import Exchange, Queue
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_object, menu_secondary, menu_tools
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_object, menu_secondary, menu_tools
 from mayan.apps.navigation import SourceColumn
 from mayan.celery import app
 

mayan/apps/metadata/apps.py

@@ -8,14 +8,15 @@ from django.apps import apps
 from django.db.models.signals import post_delete, post_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_multi_item, menu_object, menu_secondary,
-    menu_setup, menu_sidebar
-)
+from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.classes import ModelAttribute, ModelField
+from mayan.apps.common.menus import (
+    menu_facet, menu_multi_item, menu_object, menu_secondary, menu_setup,
+    menu_sidebar
+)
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.documents.signals import post_document_type_change

mayan/apps/mimetype/apps.py

@@ -2,7 +2,7 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig
+from mayan.apps.common.apps import MayanAppConfig
 
 from .licenses import *  # NOQA
 

mayan/apps/motd/apps.py

@@ -4,10 +4,11 @@ import logging
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import MayanAppConfig, menu_object, menu_secondary, menu_setup
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_object, menu_secondary, menu_setup
 from mayan.apps.navigation import SourceColumn
 
 from .links import (

mayan/apps/ocr/apps.py

@@ -8,12 +8,12 @@ from django.apps import apps
 from django.db.models.signals import post_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_multi_item, menu_object, menu_secondary,
-    menu_tools
-)
+from mayan.apps.acls.classes import ModelPermission
+from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.classes import ModelField
+from mayan.apps.common.menus import (
+    menu_facet, menu_multi_item, menu_object, menu_secondary, menu_tools
+)
 from mayan.apps.documents.search import document_search, document_page_search
 from mayan.apps.documents.signals import post_version_upload
 from mayan.apps.documents.widgets import document_link

mayan/apps/permissions/apps.py

@@ -3,12 +3,13 @@ from __future__ import unicode_literals
 from django.apps import apps
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
 
-from mayan.apps.common import (
-    MayanAppConfig, menu_multi_item, menu_object, menu_secondary, menu_setup
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_multi_item, menu_object, menu_secondary, menu_setup
 )
 from mayan.apps.common.signals import perform_upgrade
 

mayan/apps/rest_api/apps.py

@@ -5,7 +5,8 @@ from django.conf import settings
 from django.utils.module_loading import import_string
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import MayanAppConfig, menu_tools
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_tools
 
 from .links import (
     link_api, link_api_documentation, link_api_documentation_redoc

mayan/apps/smart_settings/apps.py

@@ -2,9 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import (
-    MayanAppConfig, menu_sidebar, menu_setup, menu_object
-)
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_sidebar, menu_setup, menu_object
 from mayan.apps.navigation import SourceColumn
 
 from .classes import Namespace, Setting

mayan/apps/sources/apps.py

@@ -4,9 +4,10 @@ from django.utils.translation import ugettext_lazy as _
 
 from kombu import Exchange, Queue
 
-from mayan.apps.common import (
-    MayanAppConfig, MissingItem, menu_object, menu_secondary, menu_sidebar,
-    menu_setup
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.classes import MissingItem
+from mayan.apps.common.menus import (
+    menu_object, menu_secondary, menu_sidebar, menu_setup
 )
 from mayan.apps.common.signals import post_initial_setup, post_upgrade
 from mayan.apps.converter.links import link_transformation_list

mayan/apps/sources/views.py

@@ -14,7 +14,7 @@ from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.acls.models import AccessControlList
 from mayan.apps.checkouts.models import NewVersionBlock
-from mayan.apps.common import menu_facet
+from mayan.apps.common.menus import menu_facet
 from mayan.apps.common.models import SharedUploadedFile
 from mayan.apps.common.utils import encapsulate
 from mayan.apps.common.views import (

mayan/apps/tags/apps.py

@@ -4,14 +4,14 @@ from django.apps import apps
 from django.db.models.signals import m2m_changed, pre_delete
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import (
-    MayanAppConfig, menu_facet, menu_object, menu_main, menu_multi_item,
-    menu_sidebar
-)
+from mayan.apps.common.apps import MayanAppConfig
 from mayan.apps.common.classes import ModelField
+from mayan.apps.common.menus import (
+    menu_facet, menu_object, menu_main, menu_multi_item, menu_sidebar
+)
 from mayan.apps.documents.search import document_page_search, document_search
 from mayan.apps.events import ModelEventType
 from mayan.apps.events.links import (

mayan/apps/task_manager/apps.py

@@ -2,9 +2,8 @@ from __future__ import unicode_literals
 
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.common import (
-    MayanAppConfig, menu_object, menu_secondary, menu_tools
-)
+from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import menu_object, menu_secondary, menu_tools
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.navigation import SourceColumn
 

mayan/apps/user_management/apps.py

@@ -5,11 +5,13 @@ from django.contrib.auth import get_user_model
 from django.db.models.signals import post_save
 from django.utils.translation import ugettext_lazy as _
 
-from mayan.apps.acls import ModelPermission
+from mayan.apps.acls.classes import ModelPermission
 from mayan.apps.acls.links import link_acl_list
 from mayan.apps.acls.permissions import permission_acl_edit, permission_acl_view
-from mayan.apps.common import menu_multi_item, menu_object, menu_secondary, menu_setup
 from mayan.apps.common.apps import MayanAppConfig
+from mayan.apps.common.menus import (
+    menu_multi_item, menu_object, menu_secondary, menu_setup
+)
 from mayan.apps.common.widgets import TwoStateWidget
 from mayan.apps.metadata import MetadataLookup
 from mayan.apps.navigation import SourceColumn