From 7bb708a8c3b271f74149e4e91b9bb9de23316d94 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Thu, 16 Aug 2012 07:36:12 -0400 Subject: [PATCH] Add exception for when unable to register an App --- apps/app_registry/api.py | 3 ++- apps/app_registry/exceptions.py | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 apps/app_registry/exceptions.py diff --git a/apps/app_registry/api.py b/apps/app_registry/api.py index 84392cea56..080df824e2 100644 --- a/apps/app_registry/api.py +++ b/apps/app_registry/api.py @@ -4,6 +4,7 @@ from django.db import DatabaseError, transaction from .models import App from .links import app_registry_tool_link +from .exceptions import UnableToRegister @transaction.commit_on_success @@ -12,7 +13,7 @@ def register_app(name, label, icon=None): app, created = App.objects.get_or_create(name=name) except DatabaseError: transaction.rollback() - return None + raise UnableToRegister else: app.label = label if icon: diff --git a/apps/app_registry/exceptions.py b/apps/app_registry/exceptions.py new file mode 100644 index 0000000000..78fe2fce58 --- /dev/null +++ b/apps/app_registry/exceptions.py @@ -0,0 +1,2 @@ +class UnableToRegister(Exception): + pass