Code style cleanups
Add keyword arguments. Sort arguments and models. Move literals to their own module. Prepend handler_ to signal handlers. Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
@@ -4,8 +4,8 @@ from django.utils.translation import ugettext_lazy as _
|
||||
|
||||
from mayan.apps.permissions import PermissionNamespace
|
||||
|
||||
namespace = PermissionNamespace(name='task_manager', label=_('Task manager'))
|
||||
namespace = PermissionNamespace(label=_('Task manager'), name='task_manager')
|
||||
|
||||
permission_task_view = namespace.add_permission(
|
||||
name='task_view', label=_('View tasks')
|
||||
label=_('View tasks'), name='task_view'
|
||||
)
|
||||
|
||||
@@ -14,7 +14,6 @@ class TaskManagerViewTestCase(GenericViewTestCase):
|
||||
self.test_queue = CeleryQueue(
|
||||
label=TEST_QUEUE_LABEL, name=TEST_QUEUE_NAME
|
||||
)
|
||||
self.login_user()
|
||||
|
||||
def _request_active_task_list(self):
|
||||
return self.get(
|
||||
@@ -48,43 +47,36 @@ class TaskManagerViewTestCase(GenericViewTestCase):
|
||||
self.grant_permission(permission=permission_task_view)
|
||||
|
||||
response = self._request_queue_list()
|
||||
|
||||
self.assertContains(
|
||||
response, text=self.test_queue.name, status_code=200
|
||||
)
|
||||
|
||||
def test_active_task_list_view_no_permissions(self):
|
||||
response = self._request_active_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
def test_active_task_list_view_with_permissions(self):
|
||||
self.grant_permission(permission=permission_task_view)
|
||||
|
||||
response = self._request_active_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
def test_reserved_task_list_view_no_permissions(self):
|
||||
response = self._request_reserved_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
def test_reserved_task_list_view_with_permissions(self):
|
||||
self.grant_permission(permission=permission_task_view)
|
||||
|
||||
response = self._request_reserved_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
def test_scheduled_task_list_view_no_permissions(self):
|
||||
response = self._request_scheduled_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
def test_scheduled_task_list_view_with_permissions(self):
|
||||
self.grant_permission(permission=permission_task_view)
|
||||
|
||||
response = self._request_scheduled_task_list()
|
||||
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
Reference in New Issue
Block a user