Code style cleanups
Add keyword arguments. Sort arguments and models. Move literals to their own module. Prepend handler_ to signal handlers. Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
@@ -40,13 +40,13 @@ class ResolvedSmartLinkView(DocumentListView):
|
||||
)
|
||||
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_document_view, user=request.user,
|
||||
obj=self.document
|
||||
obj=self.document, permissions=permission_document_view,
|
||||
user=request.user
|
||||
)
|
||||
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_smart_link_view, user=request.user,
|
||||
obj=self.smart_link
|
||||
obj=self.smart_link, permissions=permission_smart_link_view,
|
||||
user=request.user
|
||||
)
|
||||
|
||||
return super(
|
||||
@@ -61,8 +61,8 @@ class ResolvedSmartLinkView(DocumentListView):
|
||||
|
||||
try:
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_smart_link_edit, user=self.request.user,
|
||||
obj=self.smart_link
|
||||
obj=self.smart_link, permissions=permission_smart_link_edit,
|
||||
user=self.request.user,
|
||||
)
|
||||
except PermissionDenied:
|
||||
pass
|
||||
@@ -170,8 +170,8 @@ class DocumentSmartLinkListView(SmartLinkListView):
|
||||
self.document = get_object_or_404(klass=Document, pk=self.kwargs['pk'])
|
||||
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_document_view, user=request.user,
|
||||
obj=self.document
|
||||
obj=self.document, permissions=permission_document_view,
|
||||
user=request.user
|
||||
)
|
||||
|
||||
return super(
|
||||
@@ -277,8 +277,8 @@ class SmartLinkConditionCreateView(SingleObjectCreateView):
|
||||
|
||||
def dispatch(self, request, *args, **kwargs):
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_smart_link_edit, user=request.user,
|
||||
obj=self.get_smart_link()
|
||||
obj=self.get_smart_link(), permissions=permission_smart_link_edit,
|
||||
user=request.user
|
||||
)
|
||||
|
||||
return super(
|
||||
@@ -316,8 +316,8 @@ class SmartLinkConditionEditView(SingleObjectEditView):
|
||||
|
||||
def dispatch(self, request, *args, **kwargs):
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_smart_link_edit, user=request.user,
|
||||
obj=self.get_object().smart_link
|
||||
obj=self.get_object().smart_link,
|
||||
permissions=permission_smart_link_edit, user=request.user
|
||||
)
|
||||
|
||||
return super(
|
||||
@@ -345,8 +345,8 @@ class SmartLinkConditionDeleteView(SingleObjectDeleteView):
|
||||
|
||||
def dispatch(self, request, *args, **kwargs):
|
||||
AccessControlList.objects.check_access(
|
||||
permissions=permission_smart_link_edit, user=request.user,
|
||||
obj=self.get_object().smart_link
|
||||
obj=self.get_object().smart_link,
|
||||
permissions=permission_smart_link_edit, user=request.user
|
||||
)
|
||||
|
||||
return super(
|
||||
|
||||
Reference in New Issue
Block a user